From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuuki Harano Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] PGTK patches Date: Sun, 14 Nov 2021 22:42:33 +0900 (JST) Organization: Ingage Inc. Message-ID: <20211114.224233.1516816056723068839.masm@luna.pink.masm11.me> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25251"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: fejfighter@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 14 14:53:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmFwu-0006MB-85 for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Nov 2021 14:53:37 +0100 Original-Received: from localhost ([::1]:41086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmFws-0001D5-Bs for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Nov 2021 08:53:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmFmN-0006f2-Lf for emacs-devel@gnu.org; Sun, 14 Nov 2021 08:42:43 -0500 Original-Received: from shiro.masm11.me ([150.95.182.25]:56386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmFmJ-00087W-Kx for emacs-devel@gnu.org; Sun, 14 Nov 2021 08:42:42 -0500 Original-Received: from luna.pink.masm11.me (i153-144-34-242.s41.a033.ap.plala.or.jp [153.144.34.242]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 88C71C011D; Sun, 14 Nov 2021 22:42:33 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1636897353; bh=m/rkUAZ1zFPNxvGvALHwg9D3ou6aLYllAtm9wtaySWk=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=ENay0DUoAXhNf/1SL/Y4Zv27r7Bh+eDvSSDkhUEE7spL6olXeoB5kuPE6NXaXBBZi kzEsziQqeJ4DAsZOIil7n8WEqY8m8BSCyyfrg5ApxpICzyhclHZpTgrlkPib8avW3y kBqnX9AqycUcCWUYCCtrEOLhw+lyrxxxSEhETuu4= In-Reply-To: X-Mailer: Mew version 6.8 on Emacs 29.0 Received-SPF: pass client-ip=150.95.182.25; envelope-from=masm@masm11.me; helo=shiro.masm11.me X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 14 Nov 2021 08:52:23 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279417 Archived-At: Thanks. On Sun, 14 Nov 2021 23:34:51 +1100, Fejfighter wrote: > - if (!FRAME_GTK_OUTER_WIDGET (f)) > + if (!FRAME_GTK_OUTER_WIDGET (f)) { > + if (FRAME_WIDGET(f)) > + gtk_widget_set_can_focus(FRAME_WIDGET(f), g_no_accept_focus); > return; > + } Please fix coding style. - position of braces - insert a space between function/macro name and open-paren. > + gtk_widget_grab_focus(FRAME_GTK_WIDGET(f)); > + if (FRAME_GTK_OUTER_WIDGET(f)) > + gtk_window_present(GTK_WINDOW(FRAME_GTK_OUTER_WIDGET(f))); Here, too. -- Yuuki Harano