Re: xterm [menu] key definition

[Ergus via "Emacs development discussions." <emacs-devel@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On Tue, Aug 24, 2021 at 09:37:23AM +0300, Juri Linkov wrote:
>* Gregor Zattler <telegraph@gmx.net> [2021-08-23; 20:35]:
>>> I don't actually know about any keyboard with a print
>>> button...
>>
>> wouldn't that be the PrtSc key which is on every standard PC
>> keyboard right of F12 and above of Insert?
>>
>>> But I suppose there should be some. If someone has it;
>>> please could you check with xev and cat+xterm what it
>>> sends?
>>
>> Said key gives via cat on xterm:
>>
>> ^[[2~
>>
>> and xev says the same.
>>
>> on debian buster, that is.
>
>I have the PrtSc key that prints the screen,
>but no Menu key, so can't confirm, sorry.
>
Just to clarify.

What I am proposing is as simple as the attached patch.

I won't expect any complain about the change, but if so we then may
decide to do something like an alias between [menu] and [print]:

BTW: Juri, may we add a binding that toggles the menu when we repeat the
S-<f6> or the [menu] key (or whatever key the user pressed to activate
it)? Because a single ESC hides the menu only on gui not in term.

We can do that with C-g or ESC ESC ESC; but repeating to toggle is a
very common behavior right? and now it is free, it is better to take it
before some more fancy behavior comes for it in a while ;p.

[-- Attachment #2: menu.patch --]
[-- Type: text/plain, Size: 1858 bytes --]

diff --git a/lisp/mouse.el b/lisp/mouse.el
index 9d86681384..9e37527e70 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -452,10 +452,20 @@ context-menu-entry
   `(menu-item ,(purecopy "Context Menu") ignore
               :filter (lambda (_) (context-menu-map))))
 
+(defun context-menu-open ()
+  "Start key navigation of the context menu.
+This is the keyboard interface to \\[context-menu-map]."
+  (interactive)
+  (let ((inhibit-mouse-event-check t))
+    (popup-menu (context-menu-map) (point))))
+
+(global-set-key [S-f6] #'context-menu-open)
+
 (defvar context-menu-mode-map
   (let ((map (make-sparse-keymap)))
     (define-key map [mouse-3] nil)
     (define-key map [down-mouse-3] context-menu-entry)
+    (define-key map [menu] #'context-menu-open)
     (when (featurep 'ns)
       (define-key map [C-mouse-1] nil)
       (define-key map [C-down-mouse-1] context-menu-entry))
@@ -468,16 +478,6 @@ context-menu-mode
 When Context Menu mode is enabled, clicking the mouse button down-mouse-3
 activates the menu whose contents depends on its surrounding context."
   :global t :group 'mouse)
-
-(defun context-menu-open ()
-  "Start key navigation of the context menu.
-This is the keyboard interface to \\[context-menu-map]."
-  (interactive)
-  (let ((inhibit-mouse-event-check t))
-    (popup-menu (context-menu-map) (point))))
-
-(global-set-key [S-f10] 'context-menu-open)
-
 \f
 ;; Commands that operate on windows.
 
diff --git a/lisp/term/xterm.el b/lisp/term/xterm.el
index e63bf36cc3..d37206e018 100644
--- a/lisp/term/xterm.el
+++ b/lisp/term/xterm.el
@@ -350,7 +350,7 @@ xterm-function-map
     (define-key map "\e[5;3~" [M-prior])
     (define-key map "\e[6;3~" [M-next])
 
-    (define-key map "\e[29~" [print])
+    (define-key map "\e[29~" [menu])
 
     (define-key map "\eOj" [kp-multiply])
     (define-key map "\eOk" [kp-add])