From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: fido-vertical bindings Date: Wed, 18 Aug 2021 14:25:58 +0200 Message-ID: <20210818122558.cqhspwxrk3fmix4r@Ergus> References: <20210817000745.cpnevwj7anmarue2.ref@Ergus> <20210817000745.cpnevwj7anmarue2@Ergus> <87czqcw9x6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 18 14:27:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGKfa-0001vW-Te for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Aug 2021 14:27:47 +0200 Original-Received: from localhost ([::1]:54746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGKfZ-0003DC-6m for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Aug 2021 08:27:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGKeL-00023s-Fl for emacs-devel@gnu.org; Wed, 18 Aug 2021 08:26:29 -0400 Original-Received: from sonic316-11.consmr.mail.bf2.yahoo.com ([74.6.130.121]:39729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGKeI-0003qz-L9 for emacs-devel@gnu.org; Wed, 18 Aug 2021 08:26:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1629289584; bh=IMFXCBSutG7uZT4u39Th57jwWj7Hjzyffqu0P6Yu0gs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=K7EbZez4aJA+9PcPcTAwkCo9J1eB8lp3mzlH1vrjyOnuyfx8rRHhyLcDOQn+qjY+Wdw04RUYxGayn0uhER5mhqtYJofPBXDqHMSkPdlO+6fVpgpnLGpoocMCOYs6wl4VbRnJQaQ5hP7x6rTPCLp4NfhIai12rXzWeimzJk7PZ+3i3BAXbNoi1li2bigAahnm9lQkxv4K+HUaUiKX9fGftCo6TLgAzc5Sqm4gd4kR/v5GO3O3UYNW94Fpvt+PcfsjaF8VNphKXu9h77gKBpgSbvqEbzFJJau8UDpUiGM+jNW+kCUKyuu7Nhn1QvBSlgTEQhaFPgxNdKtQvxp8zER1yA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1629289584; bh=A//CjFndD0E0H76O69Kzshz1z7DPm9aMens3rKgL8ac=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=NCPageyrmz/bVa0fTkmo4HFCFCsYYyCcwTeHEOv4egwvoFm0Z2fbJgXwkkXvGmWlaF2p//KC5NgycOvWludP91WYvhgFBTGQSGG6E8MvsZctpu7rYCqMhSlrHl8kKx9W6ZmfDE1slsiFt8P/MPgJFrZPH7XUIYBAJ9vfa6ZHPPPmnBh6DateXc9nF1IE9ZuYPQXb/w4bBkiJFTPyppow4jvyaM2ItqKp9XUgPZPSMKIJdzHmAoDijibLyzc4HfBdaN9tleIZKznnKr2GT0QjhUnLpsRmfr3w5NpXvR3SHLoNDMo3VZFWTskUbdT8d0gDp7mcM8RjFtHoXXh2lOQVfw== X-YMail-OSG: kTb29YMVM1nn6qnibH5zsGirie3RN9kF8LQaEo0vLFsOkqlkkXMvkNdccfOfmoS C9mpsIq9f.7ooFuStlyuPIaqX0O9C5NweXa2ui.o6xtUb6a4jSF_vzJv.JyeTmRZynQkavwstYd1 zr2FznzOpLqh3u4Vga3Hoh3Qam..e3hWZ0i9umsC0J7LuRp1GvhVejWGJCZw73z0C85JGa9_o_8V HvGreFNmpCc37P_c9kTZvlPXp3c457sSkE3b8WGdugd7rB2n6XTz_uFel4bJxeCm.QEMIwvICtsh IHQ_haSke8laGxIkfzdYxy3KXt_4bQRH5uMPm_kxDxvgbOiBN9PDuWd4mXZpFy3Ez3ZKOrdvhixY 24qng46TUnVPXLZG.SoVGhVoXwoNphjrTqgQiIzUn5EA3XR2uLV.JwUPQsgAbpA4GF1SoeTUMyiH rv98gTz9aKlQUnbckln4LMJleCzy_wXSAEhHjo9OuWFDrsEtuWJlcsZwTQhTFiX2Dg0NrI5j7bEX PbXFD6ohZv2nnGTIhZhfztTvqqg0eEc2s9eKKmzUYXJtQrYEFkFzkWSvEmRv0NTq9GlxDDvf.eJr l8zKrA2YgCunxCRw4Ii_tndv_NR4OeAoaPFby8CQuFn0rjbJWxija_.PQt2IQiGC2Eje6K1FHt5Y sPFGbFYwBIalpKqd4e9xP3CGm4wkVfyzstJIEihvQE1S9O6C8nCkpYrEoebeP7RVc7pTHSLrjly4 jBv1U_D86QnrqHT0xSQ81LZWA0NLxFEFcge19nytK8uCjF_70UfSZWpbrh1TTQ.zDvSvU4V7GDZf 8rGyLZ7HUNmSFDYyzX09r3vaAnS070JZo4pypC4JGm X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Wed, 18 Aug 2021 12:26:24 +0000 Original-Received: by kubenode509.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7bba7d49483d9fd74e62216f1fa8ee1c; Wed, 18 Aug 2021 12:26:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87czqcw9x6.fsf@gmail.com> X-Mailer: WebService/1.1.18850 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.130.121; envelope-from=spacibba@aol.com; helo=sonic316-11.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272559 Archived-At: Perfect!! Very thanks Joao. On Tue, Aug 17, 2021 at 01:08:37PM +0100, Jo�o T�vora wrote: >Ergus writes: > >> I just tried the new fido-vertical you added. > >I added it some time ago, IIRC. What I've done very recently is make it >enable fido-mode automatically, so that you don't need two foo-mode >calls to get the desired functionality. So > >M-x fido-vertical-mode > >is all you need. > >> I think there is a small issue very simple to fix. In vertical mode >> either the right/left arrows and C-n/p may be switched with the actual >> up/down and maybe C-r C-s... to have a consistent behavior. > >I had a tough time understanding what you meant, but now I think I do >and I just committed the patch after my sig. > >If you use fido-vertical-mode, also notice the new goto-first/last stuff >suggested by Simon Lang in bug#49005. > >Jo�o > >diff --git a/lisp/icomplete.el b/lisp/icomplete.el >index 96b7e0f201..81fc6ff03c 100644 >--- a/lisp/icomplete.el >+++ b/lisp/icomplete.el >@@ -624,6 +624,8 @@ icomplete-vertical-mode-minibuffer-map > (let ((map (make-sparse-keymap))) > (define-key map (kbd "C-n") 'icomplete-forward-completions) > (define-key map (kbd "C-p") 'icomplete-backward-completions) >+ (define-key map (kbd "") 'icomplete-forward-completions) >+ (define-key map (kbd "") 'icomplete-backward-completions) > (define-key map (kbd "M-<") 'icomplete-vertical-goto-first) > (define-key map (kbd "M->") 'icomplete-vertical-goto-last) > map) > > >