From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: [PATCH] Display fill column indicator issue. Date: Thu, 3 Jun 2021 09:28:17 +0200 Message-ID: <20210603072817.nuff43yiaa7iy7le@Ergus> References: <20210602102423.hosk6gdzi2lpu7jt.ref@Ergus> <20210602102423.hosk6gdzi2lpu7jt@Ergus> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="i7zjjpmde7dp27xi" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20336"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 03 09:29:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lohnE-000540-K9 for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Jun 2021 09:29:28 +0200 Original-Received: from localhost ([::1]:38762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lohnD-0007jV-Mj for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Jun 2021 03:29:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lohmY-00074b-LC for emacs-devel@gnu.org; Thu, 03 Jun 2021 03:28:46 -0400 Original-Received: from sonic304-56.consmr.mail.bf2.yahoo.com ([74.6.128.31]:33164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lohmW-00068P-GT for emacs-devel@gnu.org; Thu, 03 Jun 2021 03:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1622705321; bh=P/0d8iowJI5Z5rpr4FGETAkJruds0rm9IqakAjRoMfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=gJGEKZ+WDCl7KGr6m3f1tZecxwnuSkcxhCt34FCZny3vnt5Uziyk44rUYv75EKaZrXszJr38/mJEoDICr4VC4eFMzjZhHNsVF1uL9y4knujuQclpsUqrYE3CXDtV53K1mh0wfJRIdmgLGqith4bCxNCMZn9GzlxtrJrirylfAKHgpDztmKSxNqkU7VqJHbL3CWZCt9aQiXNk9kS4TfwGebjDzJQx9PRQkIHTPPYtpatGS8G0s9HrhtjefzFhJPqjg4ZGwCD8RZfiVzZNft4VBO4YjK6XnPw2gtCGVmL4q+qoz0rrhMK/2tUzchukhNFd0Ai6pXwwDve+cOSUBsBP+w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1622705321; bh=9bMqd+DPc5TqMV3c+zvnNfwrQLCXfKwrck0rZ7XXW/c=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=f0ifE6u57iPd6gfNnkrvVon7QM1j0niqg7cYAyg/MoiE2iuumjwzLjfjFF/kUuNBxfWCXflgDRZT6VOkH2jk1WVyhXbY29XrX8xBie36ZyV01PgAiaoseR9hxbzwI3DvBCp77792RGyaJs2Z7F2isbkLxs5vsIB0CSBvTvNtm1ZBlFNV0BXcQ+VgWZctRhTw+9XOGG/UTvsAJB/W4TgLsZFVYUvNNlKrpAvq+4XlL8onIvleR43riFiwyc202yJAddhSbxOa+EXNdwuneLACnEKu+h1gSTdzOYAdPR3tiPsCQPH9BwCycByzIEWpZ8kEGdopjWgNh9ysEL3vI34C+A== X-YMail-OSG: b_DCO.8VM1mPEWHoscIwQDHaeDN1Q1AXOQPg9Nk9CaNP4nkqLR0wOHAe.PNcm0s XL6W0a__1nosI964qaBbHJ2CKo7pscE6IGQ9Lk64U41kzJtDwk9AHng_AOtYa7ZYRjaukJTMsvuV D2BwW8frjk0uSSxcGNlxATbpUAyyir8bTBKEEtxRPonqKeQtKfvqRjzOUDLn_yPXvQ3yBfing4Oj oeL4Xt0cplLuuGjMC1ynnNOTASQIWks50dJPbQ1Fnamynl07X7zHmfsJ1Xb0VxUey6va9XTPWo6V QH9xHtv2vmZms58Hfr_RF6_FFkEjY0JjmPlkZfag6WLxNoul50Ifkhg5KGL6VkdOJfM6QB6iGA6p Nr6l2bVDT6uPn35UcPCb1dniM.FPFCT81jHiqBj29ht4PzKh1ilAcWTSSganW0I7Vwz4I8EQtncH 87SiVKKLgbArjCiX9K6P2GhsxF8_QwW7nmXTf098OstuHHehLnihyqXY0.VGUepL0fOKDW5kXIrg fFT9ecEezpuWiBOrxmGs3ONjTiq9Q_up3iARWnSrraB0ERBBmhVQpdFq1JlxTjM4eyS_mRqu8xxj SNqJ.wyP.5UZQ2420if5EQ2gIiW8QBoX8yNQvFQXy3_WYHs_pyX54QqFnWW.f58yFQIK3YM6.m6l 5wbi0.DQEUEOAhJXRy5l.qtg4Bv_sQtt0kjEpCFIyTPta75wWwuHWvC.1dvpNtHdLxrHGnJhPdap okj9xV0F.4_ajOfgK0bpUfvQ9lzFGssb_s7eLiOnijqPlHfQnNZFqwmgxhi2u3_hQ6obDsWZ2_Yr bxvWIjh5IMqSYdysMtnB04V_04IpgSqHq12arDVK8W X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Thu, 3 Jun 2021 07:28:41 +0000 Original-Received: by kubenode523.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 0d6152f1c8314f2cf8aa3269a784f3b9; Thu, 03 Jun 2021 07:28:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20210602102423.hosk6gdzi2lpu7jt@Ergus> X-Mailer: WebService/1.1.18368 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.128.31; envelope-from=spacibba@aol.com; helo=sonic304-56.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270339 Archived-At: --i7zjjpmde7dp27xi Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Hi Eli: Could you check and apply this fix? Best, Ergus On Wed, Jun 02, 2021 at 12:24:23PM +0200, Ergus wrote: >Hi Eli: > >I have observed that recently the column indicator changed its behavior >(maybe it did some time ago but I haven't noticed). > >When scrolling horizontally the indicator line is supposed to scroll too >with the text; but right now it is always in the same "screen" column. > >The issue is only on terminal because in gui the line moves >correctly. So the problem should be in xdisp.c:22390 because it should >substract the horizontal offset of the current starting column (maybe >it->first_visible_x or similar). > >Could you push this fix please? I have to recover my Savannah private >keys and I don't have time now. > >Thanks in advance, >Ergus > --i7zjjpmde7dp27xi Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="fix_dfci.patch" diff --git a/src/xdisp.c b/src/xdisp.c index 0a95aa32f9..68bcbbe5d1 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -22387,7 +22387,8 @@ extend_face_to_end_of_line (struct it *it) default_face->id : face->id); /* Display fill-column indicator if needed. */ - const int indicator_column = fill_column_indicator_column (it, 1); + const int indicator_column = + fill_column_indicator_column (it, 1) - it->first_visible_x; /* Make sure our idea of current_x is in sync with the glyphs actually in the glyph row. They might differ because --i7zjjpmde7dp27xi--