From: Naoya Yamashita <conao3@gmail.com>
To: julien@danjou.info
Cc: emacs-devel@gnu.org
Subject: Re: Add oauth2 customize group (resolve FIXME)
Date: Fri, 19 Feb 2021 20:13:55 +0900 (JST) [thread overview]
Message-ID: <20210219.201355.1324938630727300892.conao3@gmail.com> (raw)
In-Reply-To: <m2o8ggz7iz.fsf@danjou.info>
> Thanks Naoya.
>
> I pushed your change.
>
Thanks, but I'm bit sad when see the commit.
http://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?h=externals/oauth2&id=dc069550616fb0a72507489ea796d0e1bd8b48c9
The commit `author` should be `Naoya Yamashita <conao3@gmail.com>`.
You may think it's a small thing, but OSS contributors are
motivated by commits being properly marked as my contribution, so
pushing inappropriate commits may demotivate them.
This time is okay, but please pay attention to the Author field next time!
next prev parent reply other threads:[~2021-02-19 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 1:16 Add oauth2 customize group (resolve FIXME) Naoya Yamashita
2021-02-19 10:17 ` Julien Danjou
2021-02-19 11:13 ` Naoya Yamashita [this message]
2021-02-19 15:14 ` Stefan Monnier
2021-02-19 16:57 ` Naoya Yamashita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219.201355.1324938630727300892.conao3@gmail.com \
--to=conao3@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).