From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Naoya Yamashita Newsgroups: gmane.emacs.devel Subject: Add oauth2 customize group (resolve FIXME) Date: Fri, 19 Feb 2021 10:16:53 +0900 (JST) Message-ID: <20210219.101653.1338518986357974746.conao3@gmail.com> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Fri_Feb_19_10_16_53_2021_913)--" Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17222"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org, julien@danjou.info Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 19 02:18:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCuRJ-0004Mt-FC for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 02:18:37 +0100 Original-Received: from localhost ([::1]:56408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCuRI-00083A-Hb for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 20:18:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCuQE-0007Og-Rc for emacs-devel@gnu.org; Thu, 18 Feb 2021 20:17:30 -0500 Original-Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:45888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCuQB-0002rJ-EU for emacs-devel@gnu.org; Thu, 18 Feb 2021 20:17:30 -0500 Original-Received: by mail-pf1-x431.google.com with SMTP id j12so2766842pfj.12 for ; Thu, 18 Feb 2021 17:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:subject:from:mime-version :content-transfer-encoding; bh=h3u+gk36Ty8JkIJL/O/GWf7QpRYF/MFns+Wkk+Ipoas=; b=cqY72YJ25EKbZxfylyMxQi8eDfsvYCpw2pEihMDpDs/pAaWeYkbRiwgQ6isPdhMwi3 vKJZFGoBRWQgCqLB+EYPwjZhpmYRf0WVa4vZBRE1fLrQCIhnXmdAAvmn0ZzXLE8Kqjm6 pC0DBkysXiFFT6KAq/+tNHqtt4OOHMFf4APePAPgAikDDgDr4K09u37po4v4P0X+ODuq RWqaVyN6Nx8d1dJwifCmeUKBUDxP3bK5Wrht5qUUfYVqw+jpRpofuWsVjJh4dPeMPNws SiS+ThHkf2OcPyB7a5d3daE0ksLU6icLhXveodeOWSMJs1sLpBX5Dhm0p0IgvUPYwxNl 3i6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:subject:from:mime-version :content-transfer-encoding; bh=h3u+gk36Ty8JkIJL/O/GWf7QpRYF/MFns+Wkk+Ipoas=; b=qZjFuaApHtCit32Lyx0qMq4wODv9Zzst70tLzgI33cnPJ2dtU5IGMdDQYDHJ2vsrqf jrntWiUUH8v2ShMa2d2Cqd0YZWJcIC084rf1II8NZRntppi1mRwzhYOVr3ciFkfglGH7 S5wFUwOVJ7IBlyidVKMQWo/b1IhD88Kut/dfwFYTfYNCs0NC0H5OwST9dN5ELkr5DxdF /T7JuoNXVpL2P7TIgMAVM+ZgBXutG00qadA+kyQIhI6B9z7LFlCvBtu2cAz7pKRZGUKz se416oRY30sSmBzmjiERoswmZ903muJsCVStY0OFi8AZ/5A9UXrgdxEtsi3Aef3wStYy SQMQ== X-Gm-Message-State: AOAM531hgnxkX11Gedrq8qpgKx+NJihRxnO4d7uEP2+khtyMpknSK0EI gJX2L5y/SGQmlT5OXUGpHifdGQCC+rQQzw== X-Google-Smtp-Source: ABdhPJysv8RQGWRFYBqtwBVB1YUvXgyr7aJ42s8RFnisFG3qBItJOHn6kaEffDK0V7JxtOJNEtlEow== X-Received: by 2002:a65:568b:: with SMTP id v11mr6323777pgs.49.1613697445339; Thu, 18 Feb 2021 17:17:25 -0800 (PST) Original-Received: from localhost (p210141-ipngn200407niho.hiroshima.ocn.ne.jp. [118.4.79.141]) by smtp.gmail.com with ESMTPSA id h10sm7663003pfq.97.2021.02.18.17.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 17:17:24 -0800 (PST) X-Mailer: Mew version 6.8 on Emacs 27.1 Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=conao3@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265204 Archived-At: ----Next_Part(Fri_Feb_19_10_16_53_2021_913)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi, thanks for maintaining such a great project! I find oauth2 ELPA package and also find a easy FIXME comment. This patch add a new group and changed all customization variables to belong to it. Regards, Naoya ----Next_Part(Fri_Feb_19_10_16_53_2021_913)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-packages-oauth2-oauth2.el-Add-oauth2-group-and-use-i.patch" >From b6619724abc1f268eb3b68bc9077f899f9d70bea Mon Sep 17 00:00:00 2001 From: Naoya Yamashita Date: Fri, 19 Feb 2021 09:56:48 +0900 Subject: [PATCH] * packages/oauth2/oauth2.el: Add oauth2 group and use it (oauth2): New group. (oauth2-token-file): Belongs to it. --- oauth2.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/oauth2.el b/oauth2.el index 43c4e9e4d4..43e48c1dbe 100644 --- a/oauth2.el +++ b/oauth2.el @@ -47,6 +47,12 @@ (defvar url-callback-arguments) (defvar url-callback-function) +(defgroup oauth2 nil + "OAuth 2.0 Authorization Protocol." + :group 'comm + :link '(url-link :tag "Savannah" "http://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/?h=externals/oauth2") + :link '(url-link :tag "ELPA" "https://elpa.gnu.org/packages/oauth2.html")) + (defun oauth2-request-authorization (auth-url client-id &optional scope state redirect-uri) "Request OAuth authorization at AUTH-URL by launching `browse-url'. CLIENT-ID is the client id provided by the provider. @@ -149,8 +155,7 @@ TOKEN should be obtained with `oauth2-request-access'." (defcustom oauth2-token-file (concat user-emacs-directory "oauth2.plstore") "File path where store OAuth tokens." - ;; FIXME: This var doesn't belong to any group. Either add it to some - ;; pre-existing group or create an `oauth2' group for it. + :group 'oauth2 :type 'file) (defun oauth2-compute-id (auth-url token-url scope) -- 2.30.0 ----Next_Part(Fri_Feb_19_10_16_53_2021_913)----