From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Concern about new binding. Date: Tue, 2 Feb 2021 14:49:50 +0100 Message-ID: <20210202134950.vybbpf3iewbymfjo@Ergus> References: <20210202134950.vybbpf3iewbymfjo.ref@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12663"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 14:59:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6wDW-0003D0-8f for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 14:59:42 +0100 Original-Received: from localhost ([::1]:56968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6wDV-0008UU-Ak for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 08:59:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6w4K-000777-2w for emacs-devel@gnu.org; Tue, 02 Feb 2021 08:50:12 -0500 Original-Received: from sonic315-13.consmr.mail.bf2.yahoo.com ([74.6.134.123]:36553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6w4H-00036z-HR for emacs-devel@gnu.org; Tue, 02 Feb 2021 08:50:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1612273806; bh=FydvTIrH/J1oH1Q/wmoS1d9yjN8MGxxPds+yAScyJbs=; h=Date:From:To:Subject:References:From:Subject:Reply-To; b=GbZhrnG8ugFjXLgDjKGx52ARMJkOOrClMKGRvqm5Sg7JTXxSW4FE7ltUk5RPN++ML4yrBc0CmomPs48qpkD9WNdK1difm/W/eQBQrp1vV/FAkHW80RJXQt1SkkQA9g0YrECliGVePHP4cbSqJjhaB0OTm8A+CIkebOHgiwFdP9bCe5htS/VYkZfFdeZAMqQhEXcZ2A/3f0/01e494dhHJY49FYZ7sCR8lMJvSd09b4GMZDorS+kCYR/vV2bPbsOLRiM4Y7hucfEZfsAwu8gsNKon805+gUHU0AmfzrdtlRnOMmuc9fWAHxpoz2N9rH4vZlSWDQ9215G4CWHfCnyNBA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1612273806; bh=tyBggW/M+0gddmhW/u8b5EKqMMMpZqWshGRIU2WPCtH=; h=Date:From:To:Subject:From:Subject:Reply-To; b=SWD5Wd1CzzfK0XWzU8kFiYhwWNeaMzIacJwGkjr/qVYVcLTqHe9LNsLAvQMnI2TbrTHThm45musiRqcjm6G9LRTU7aSLjMOjuRn8tDIxIpwn0HJhr87ej5kcsi9+fyM8PSqBienYzErpBTH33DPIQDBI9kY+kLvQZZoZEcHRftmeGUnlsluzOVoLJO6TRyG2RJf3iVutVOQ++3iHC30RDpxIO65yUKEHjY9/cp8zdCrn4QqAbQ3NLqB3IB967HeV1Z4aTfLOiqOnd7RsCdabFugcZuzv/9/0/vIu4gw/jfd15/Eu4Xy6V/4dK/JKdoY8AcVH1NZAWieMIWiJYLLfpA== X-YMail-OSG: JbwS1AgVM1lqKFEOuQzDHuKobvg2YZfFUYWkdREv5vsHE8SxgWxToHr.Wbomu0n dnFnMooCkY0t579yHfFKH35lBeb6z8kYdeX8unfA4pafFVHP.mn5ia_DN6a6dRqcKonWlizGvtdh bv.rJ3I1j.Bbh.3nt3LTTQjFr3Wx6Xo.DTXCKxAve3ojXGSWJ4rFKBe4vE6CDYcVyqhx3KqqtsN6 IA_i0pUq18hcAwYaFZ1gE4Lc5xOHA1uO.D4SQ0U_8RvSRESQrkSYKki4akuy2Zb81BzYvlyl2qlU RGxiBDF9DTSC7y8rwl_C8AgXIgqgk0tLJgiye2Q1W.VDbWHDiBlhOzEJTJD45OHAe67N7V7wBgKd GWJT4nc67nIVwcRJUmoJt_E0F6tXGGhWOC7MDyOFYfWgDUYUHcM_nBdKUGpz4T_iArT8B4gWF38X q2KeFAuitY1IMFI72ziC3Euj1PKJABgg0gzZZMSPVlTnTRE3A13mp8BTZ0uWvm9adC4oHSpQv9mt Rcd7O0_uFrQwUmYGYVeZUnXBllZc_LFdIyp9tzol4TNeuh20jVSoemj3EJzg1DGvnXGnYR2.U0MH kkRbuuJK5P.UwUdjMYsCpKuqOjtrZmZHUoFnADYRYaXD92dpvBM7bVZHe47ZB1XGQ8fOVaCfEqCf v0jYzr8l7TgDCQ95tiYKEtL0Zn8uZS.5BK0Sf956p_uPSJ9MalpC_0rn3p8HSq6JVvtib.EtYkZb 3GveGROP5SOT07Adk6UMxKRMR73hUZBQEKbN6qHPNyqw8jHJYrqIrOCumr3y_AdLCuIqinoy0W62 je5QuvzHBKz84bBneEURG_t8SZjL.RCI70OBAFnNyI Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.bf2.yahoo.com with HTTP; Tue, 2 Feb 2021 13:50:06 +0000 Original-Received: by smtp420.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 6de659cb47c8d70a10f6dec00a9852f9; Tue, 02 Feb 2021 13:50:05 +0000 (UTC) Content-Disposition: inline X-Mailer: WebService/1.1.17648 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.134.123; envelope-from=spacibba@aol.com; helo=sonic315-13.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263715 Archived-At: Hi: In a recent commit I see that the C-x g binding was taken for revert-buffer. I suppose this should have been discussed previously, unless I don't find the thread... but I have some concerns about this. 1) In general `C-x g` is used by magit; I know this is not a priority (cause magit is an external package), but magit is a very popular package. 2) In some threads before we have discussed that relative short combinations must be reserved to maps in order to economize them... 3) In spite of revert-buffer is a very useful command it is useless in many conditions like when auto-revert-mode is enable... so maybe it makes sense to bind it to something longer (ex: C-x g r)?? There are more commands that could be set in a map inside C-x g IMHO: toggle-read-only revert-buffer-with-fine-grain something to enable/disable font-lock etc This way instead of limiting; could open a big spot to set useful commands. I understand that longer commands are harder to discover, but hopefully we could have which-key in the next release? I hope I am writing this soon enough that the author could consider revert this change maybe with something more "general" does it makes sense?? Best, Ergus.