From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: The Emacs master is much slower than the emacs-27 branch. Date: Sat, 5 Dec 2020 15:56:22 +0100 Message-ID: <20201205145622.e4clewt4iq27q7g6@Ergus> References: <83wnxxcmjr.fsf@gnu.org> <83tut0d7e9.fsf@gnu.org> <83h7p0d37y.fsf@gnu.org> <83ft4kd2ym.fsf@gnu.org> <83eek4d2co.fsf@gnu.org> <87wnxwuzt0.fsf@tcd.ie> <83360kconl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38526"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , ghe@sdf.org, acm@muc.de, stephen.berman@gmx.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 05 15:58:23 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klZ0v-0009uR-9r for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Dec 2020 15:58:21 +0100 Original-Received: from localhost ([::1]:55906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klZ0u-0003Rp-Cr for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Dec 2020 09:58:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klYzM-0002gC-MG for emacs-devel@gnu.org; Sat, 05 Dec 2020 09:56:45 -0500 Original-Received: from sonic304-9.consmr.mail.bf2.yahoo.com ([74.6.128.32]:42983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klYzJ-0006yQ-TI for emacs-devel@gnu.org; Sat, 05 Dec 2020 09:56:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1607180199; bh=6Z13MSDZ0C4nW47OMU90Ao45ZexSi1usxexltQI0bRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=OZFajh1InHhSxorauGJKqXPypJSJ/iHdJz9WPRwCa0DcDYNZwLaMxbXFMA1ABP9ZPSKcSFQ0rzZQyKTDqRY55aOOQO9l+PGhjHnlsBYpu1B6AuDQ0uFuQ1P3zJlTKemnWWeXR4FJza7DD+p/B+3GOFlNO07wS2APqVbT4+WN7RIhCWiGutyWdyk0t/wD0cH2XzHNLUOwxZun2tZRcVQhUh82cqmExZ8bHrO3KG8MjYIH2/CwnU5Gbx3g+xDZocMrjP6vT4basF0dN/vBqnNVof4mNCPWdtD6Boi+oJ1sliLlkCvZ/ydxvH5o6ceb+eFMgp6c7NxGbXdoGMLx7FbDJA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1607180199; bh=shOumJsLj3Czy6IWsnHPuCInS83/sQFGW25Cf+e2pF1=; h=Date:From:To:Subject:From:Subject; b=MnOMIkcsv52FUzCtlWVq5OpM43beqIFWvTAp98SozQOLrEbAAjy8NGQcSHMXa4GW9kE/kUTDcWKUcLXkmlAFBrUOTMVr7MYWSj4ZfPP+s+VE+wkvc10t5B2+3AmvwNLiYZusEpyuzj6jSLc57i09ZFALLHqD6L84sz+QUaDHbsHJ+VswQplEHAocoZqfg/u/xM/jSlHNBe/SW8tgzObyU+QWMN2swiVEvxjUZwOHrsNJQX4sVdrCBrxR+Xc01PkU2NzNY75iAAIDZYDl3cfe/cSN7skNc+kJLAxF1RyLIzLrpK6Ru1FjAXFCh+OJyGtF/u9dZX1yYaAeTXaR1aSuhQ== X-YMail-OSG: JsTQFVEVM1lOtuAk6PmNjvtfAORdbQPiAbDxWhmElxbe.k8cjBT1EDDxdHXzRNV CSyFBwZfP7z8lKf_n05x47dWUTorKsSLbCehrWbfjXr30Z9bAVUYZrc9e9q1FqSfq2NQstoWR9N3 nwfmh5RQUqqWQ9GtBlFaG5rv3UdB1PuljV0U.E1ihn6WXkJSQjk8BrnhFQSLEiT6Pyc1FW1DH1V. rrop3C0SB4arbWGGHMYa.cr1.1RVMwSgvb_10xMeNlUdYOz8eZg2uMI6ovuW2Jnv6EfyJAhbjJbB KFjWrWJ9PW9Fohd5U8sznKJtprOcY6bFlToV7IgslgS6a.t9ktPnjiEQoNXO9qGgYrKRrUeP8OaG h43nzj7t957Qu3iv2dJU0toNDWwQIumRFpgGvWAK3Xmo6k6jQYgrK04cWV6btnvPNH_Py9LjqKa1 rDI.CY9_M.UdGZwLerBOUNJjZ5MnHD1_dFfFld5_9oY1D2dIjL5cIcyvQToMkkbl8M8J6ynzqO9_ 0s_AxTTQqJlQpmedy36ZOen7LMfD3TTiB572pz.xyIXAPoQ9CqQNBNkHGM6rG9p7BdF6rkO6aTfi oBmMlpItTrkViPfAPsMwMGDHqkEbJp5o6KiOvOgexqzYghxFM1MOuNzfSQ9IYGK6RqbaJ.BqwpZG Cl9jMUiDuigWSBKsQcQAjZh8dIXiMpmrqm09PB5fl6k0WONRZ70bbJiAgHu9DpWmO0sGlDuwuRg7 r4R4CInA.raG80P9OuTggku_wqsb.dk9dUq9iFStoMveFUKiykHj9Hd3EgGCgDSlR4V21efoBdXJ Q9r_FyJC5rYNdchEpF64BzIShM9QLUEV_36iYEu8vT Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Sat, 5 Dec 2020 14:56:39 +0000 Original-Received: by smtp413.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID e5a29c1ca4c5fdc78ff98b1b2a99ae5c; Sat, 05 Dec 2020 14:56:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83360kconl.fsf@gnu.org> X-Mailer: WebService/1.1.17111 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.128.32; envelope-from=spacibba@aol.com; helo=sonic304-9.consmr.mail.bf2.yahoo.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260364 Archived-At: On Sat, Dec 05, 2020 at 04:29:02PM +0200, Eli Zaretskii wrote: >> From: "Basil L. Contovounesios" >> Cc: ghe@sdf.org, acm@muc.de, stephen.berman@gmx.net, emacs-devel@gnu.org >> Date: Sat, 05 Dec 2020 13:50:51 +0000 >> >> $ for t in /tmp/timings*.txt; do awk '{s+=$1}END{print FILENAME,s/NR}' "$t"; done >> /tmp/timings-27.txt 28.3246 >> /tmp/timings-28.txt 31.7968 > >Thanks, so this indicates a 12% slowdown in Emacs 28. >Which isn't too bad, I guess. > IMHO it depends. If we know the source of the slowdown (for example, a change introduced like using a new library, a new mode enabled, changes in rendering/display engine or so) and the change worth it, then maybe 12% is absolutely fine. But if the slowdown is somehow "unjustified" then 12% is not negligible at all. Because It could be produced by wrong assumptions and get worth in the future and harder to detect (like for example excessive GC, extra redisplay, bad optimizations). The best approach is maybe what Gregory did. Bisect the history to find the source of the slowdown. Actually in my work we have a log where we register the changes and the commits hashes that impacted performance more than 5-7% either to improve or degrade it. Best, Ergus