From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
ghe@sdf.org, acm@muc.de, stephen.berman@gmx.net,
emacs-devel@gnu.org
Subject: Re: The Emacs master is much slower than the emacs-27 branch.
Date: Sat, 5 Dec 2020 15:56:22 +0100 [thread overview]
Message-ID: <20201205145622.e4clewt4iq27q7g6@Ergus> (raw)
In-Reply-To: <83360kconl.fsf@gnu.org>
On Sat, Dec 05, 2020 at 04:29:02PM +0200, Eli Zaretskii wrote:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Cc: ghe@sdf.org, acm@muc.de, stephen.berman@gmx.net, emacs-devel@gnu.org
>> Date: Sat, 05 Dec 2020 13:50:51 +0000
>>
>> $ for t in /tmp/timings*.txt; do awk '{s+=$1}END{print FILENAME,s/NR}' "$t"; done
>> /tmp/timings-27.txt 28.3246
>> /tmp/timings-28.txt 31.7968
>
>Thanks, so this indicates a 12% slowdown in Emacs 28.
>Which isn't too bad, I guess.
>
IMHO it depends. If we know the source of the slowdown (for example, a
change introduced like using a new library, a new mode enabled, changes
in rendering/display engine or so) and the change worth it, then maybe
12% is absolutely fine.
But if the slowdown is somehow "unjustified" then 12% is not negligible
at all. Because It could be produced by wrong assumptions and get worth
in the future and harder to detect (like for example excessive GC, extra
redisplay, bad optimizations).
The best approach is maybe what Gregory did. Bisect the history to find
the source of the slowdown.
Actually in my work we have a log where we register the changes and the
commits hashes that impacted performance more than 5-7% either to
improve or degrade it.
Best,
Ergus
next prev parent reply other threads:[~2020-12-05 14:56 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 18:15 The Emacs master is much slower than the emacs-27 branch Alan Mackenzie
2020-12-03 20:17 ` Eli Zaretskii
2020-12-04 9:13 ` Alan Mackenzie
2020-12-03 20:59 ` Mattias Engdegård
2020-12-04 9:24 ` Alan Mackenzie
2020-12-04 10:46 ` Alan Third
2020-12-04 11:07 ` Mattias Engdegård
2020-12-03 21:09 ` Ergus
2020-12-04 9:19 ` Alan Mackenzie
2020-12-03 22:17 ` Stephen Berman
2020-12-04 9:04 ` Alan Mackenzie
2020-12-04 9:32 ` Stephen Berman
2020-12-04 9:53 ` Alan Mackenzie
2020-12-04 10:14 ` Stephen Berman
2020-12-04 11:45 ` Eli Zaretskii
2020-12-04 12:54 ` Stephen Berman
2020-12-04 13:28 ` Eli Zaretskii
2020-12-04 13:53 ` Stephen Berman
2020-12-04 14:05 ` Stephen Berman
2020-12-04 15:51 ` Eli Zaretskii
2020-12-04 16:03 ` Stephen Berman
2020-12-04 16:28 ` Óscar Fuentes
2020-12-04 18:51 ` Eli Zaretskii
2020-12-04 21:37 ` Stephen Berman
2020-12-05 8:05 ` Eli Zaretskii
2020-12-04 16:49 ` Stefan Monnier
2020-12-05 14:04 ` Basil L. Contovounesios
2020-12-05 14:38 ` Stefan Monnier
[not found] ` <837dpxedmz.fsf@gnu.org>
2020-12-04 17:03 ` Stephen Berman
2020-12-04 17:59 ` Stephen Berman
2020-12-04 20:47 ` Óscar Fuentes
2020-12-04 21:33 ` Stephen Berman
2020-12-04 17:07 ` Eli Zaretskii
2020-12-04 19:27 ` Gregory Heytings via Emacs development discussions.
2020-12-04 19:34 ` Stephen Berman
2020-12-04 19:58 ` Eli Zaretskii
2020-12-04 20:33 ` Gregory Heytings via Emacs development discussions.
2020-12-04 20:47 ` Eli Zaretskii
2020-12-04 20:59 ` Gregory Heytings via Emacs development discussions.
2020-12-04 21:02 ` Eli Zaretskii
2020-12-04 21:20 ` Gregory Heytings via Emacs development discussions.
2020-12-05 7:44 ` Eli Zaretskii
2020-12-05 8:14 ` Gregory Heytings via Emacs development discussions.
2020-12-05 8:44 ` Gregory Heytings via Emacs development discussions.
2020-12-05 9:14 ` Eli Zaretskii
2020-12-05 9:20 ` Eli Zaretskii
2020-12-05 9:33 ` Eli Zaretskii
2020-12-05 13:50 ` Basil L. Contovounesios
2020-12-05 14:29 ` Eli Zaretskii
2020-12-05 14:56 ` Ergus [this message]
2020-12-05 15:14 ` Eli Zaretskii
2020-12-05 15:29 ` Andrea Corallo via Emacs development discussions.
2020-12-05 15:15 ` Gregory Heytings via Emacs development discussions.
2020-12-05 15:31 ` Óscar Fuentes
2020-12-05 9:05 ` Eli Zaretskii
2020-12-05 9:23 ` martin rudalics
2020-12-05 12:55 ` Gregory Heytings via Emacs development discussions.
2020-12-05 13:41 ` Eli Zaretskii
2020-12-05 15:17 ` Gregory Heytings via Emacs development discussions.
2020-12-05 15:55 ` Eli Zaretskii
2020-12-05 14:47 ` Óscar Fuentes
2020-12-05 15:07 ` martin rudalics
2020-12-05 15:24 ` Gregory Heytings via Emacs development discussions.
2020-12-05 15:36 ` martin rudalics
2020-12-05 15:39 ` Gregory Heytings via Emacs development discussions.
2020-12-05 15:47 ` Óscar Fuentes
2020-12-05 17:21 ` Gregory Heytings via Emacs development discussions.
2020-12-05 15:57 ` Eli Zaretskii
2020-12-05 16:04 ` Gregory Heytings via Emacs development discussions.
2020-12-05 15:08 ` Eli Zaretskii
2020-12-04 14:55 ` Arthur Miller
2020-12-04 15:00 ` Arthur Miller
2020-12-04 9:59 ` Gregory Heytings via Emacs development discussions.
2020-12-09 4:23 ` andres.ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205145622.e4clewt4iq27q7g6@Ergus \
--to=spacibba@aol.com \
--cc=acm@muc.de \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ghe@sdf.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).