From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.devel Subject: [PATCH 08/10] Make cache_long_scans buffer-local when setting it Date: Thu, 19 Nov 2020 10:38:12 -0500 Message-ID: <20201119153814.17541-9-sbaugh@catern.com> References: <87mtzil519.fsf@catern.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30949"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , Arnold Noronha , Stefan Monnier , Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 19 16:39:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfm23-0007tq-9q for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 16:39:35 +0100 Original-Received: from localhost ([::1]:48820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfm22-000757-BP for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 10:39:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfm0s-0005LU-PJ for emacs-devel@gnu.org; Thu, 19 Nov 2020 10:38:22 -0500 Original-Received: from venus.catern.com ([68.183.49.163]:54700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfm0q-0000eF-BI for emacs-devel@gnu.org; Thu, 19 Nov 2020 10:38:22 -0500 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1605800299; bh=wO9/AQXuvPYvUjmARGKFCHnWuGKmEyqU9KNPZc63aeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KZeLGqzSyqMXNarKrCwTeLnIDMnqsQ1XqAbXFxS0wyyoCA9q85WdTFNUdAX2phS7G ygNBvDLy1Ux3a5FKXDcWZGpQRiUZIT6I5/+OGxZ1S568fHVZQ3egu79oIUqP7RJ27W yv3ygdVRGZ8Cio68mKx4HFmQvuaeLwEJI585hdm4= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 80B1F2DDABD; Thu, 19 Nov 2020 15:38:19 +0000 (UTC) X-Mailer: git-send-email 2.28.0 In-Reply-To: <87mtzil519.fsf@catern.com> Received-SPF: pass client-ip=68.183.49.163; envelope-from=sbaugh@catern.com; helo=venus.catern.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/19 09:22:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259431 Archived-At: If we set a value for a variable on some buffer, it necessarily means that that value is buffer-local - it might be, and probably is, different from what's in buffer_defaults. Without further changes, I think this has no effect. But it's required for correct behavior when we change BVAR to fall back to buffer_defaults for non-buffer-local variables; without this change, we would always use buffer_defaults for cache_long_scans even though it's been set in a per-buffer way. --- src/buffer.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/buffer.h b/src/buffer.h index 6e384640b7..077edb893a 100644 --- a/src/buffer.h +++ b/src/buffer.h @@ -863,6 +863,7 @@ INLINE void bset_cache_long_scans (struct buffer *b, Lisp_Object val) { b->cache_long_scans_ = val; + SET_PER_BUFFER_VALUE_P (b, PER_BUFFER_VAR_IDX(cache_long_scans), 1); } INLINE void bset_case_canon_table (struct buffer *b, Lisp_Object val) -- 2.28.0