From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.devel Subject: [PATCH 03/10] Use bset_last_selected_window everywhere Date: Thu, 19 Nov 2020 10:38:07 -0500 Message-ID: <20201119153814.17541-4-sbaugh@catern.com> References: <87mtzil519.fsf@catern.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , Arnold Noronha , Stefan Monnier , Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 19 16:42:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfm4X-0000Hi-S4 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 16:42:09 +0100 Original-Received: from localhost ([::1]:55872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfm4W-0001hw-Un for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 10:42:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfm0q-0005Iy-MJ for emacs-devel@gnu.org; Thu, 19 Nov 2020 10:38:20 -0500 Original-Received: from venus.catern.com ([68.183.49.163]:54666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfm0o-0000cr-Ed for emacs-devel@gnu.org; Thu, 19 Nov 2020 10:38:20 -0500 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1605800297; bh=HoY+VRGaG/xdA6A24VOtumsakWu834tXY9pEuqsfSbo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ULowiKOhw7FFC5LaEfuW+TbuPBlJQMe+EHefNUzcBzLD9aDdJ+DwI1IMk/hXmkOtA FqmMG0VXCNqxKM29gqqaVdb2EzBKniu7pVfn20qMXvl2zKRIwtw3Sd+6q/wxfZ7qg9 UBRn4pAKNI1S3/YOkysebiuXtidMevp/p7abIqek= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id C4BC32DDAB0; Thu, 19 Nov 2020 15:38:17 +0000 (UTC) X-Mailer: git-send-email 2.28.0 In-Reply-To: <87mtzil519.fsf@catern.com> Received-SPF: pass client-ip=68.183.49.163; envelope-from=sbaugh@catern.com; helo=venus.catern.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/19 09:22:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259433 Archived-At: This function already existed; we just needed to use it in more places. --- src/window.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/window.c b/src/window.c index a6de34f3db..d24d1a546f 100644 --- a/src/window.c +++ b/src/window.c @@ -7111,9 +7111,8 @@ the return value is nil. Otherwise the value is t. */) Do not record the buffer here. We do that in a separate call to select_window below. See also Bug#16207. */ select_window (data->current_window, Qt, true); - BVAR (XBUFFER (XWINDOW (selected_window)->contents), - last_selected_window) - = selected_window; + bset_last_selected_window (XBUFFER (XWINDOW (selected_window)->contents), + selected_window); if (NILP (data->focus_frame) || (FRAMEP (data->focus_frame) -- 2.28.0