From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Mon, 16 Nov 2020 11:27:29 +0100 Message-ID: <20201116102729.ywubtda6cqdzc45z@Ergus> References: <20201115023629.19537.77471@vcs0.savannah.gnu.org> <20201115023631.C78AB20A27@vcs0.savannah.gnu.org> <20201115224943.o5r7lkkblmyt2ox4@Ergus> <20201116033719.63dryvqm4ozfer2r@Ergus> <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36247"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Drew Adams , Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 16 11:29:35 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keblP-0009Jf-HV for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 11:29:35 +0100 Original-Received: from localhost ([::1]:58228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keblO-0003Ev-JT for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 05:29:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kebjp-0002ig-0K for emacs-devel@gnu.org; Mon, 16 Nov 2020 05:27:57 -0500 Original-Received: from sonic311-13.consmr.mail.bf2.yahoo.com ([74.6.131.123]:45186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kebjh-00037b-9A for emacs-devel@gnu.org; Mon, 16 Nov 2020 05:27:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1605522467; bh=Yl2LxHydL2zmGeOQJW/7BEYqYUQ37uuKZtyPluMjmXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=SZ6WAQczJ5iTOe1wc4cc0ozKcFbM6lwxuIEFLJMxnaisnhVvS4JTY6wSxtto5ov+/8xeJLuAQczF6uPMfKv8OpyiA3U8zLIgaoZFwetimhqCx1NusmVHAHCortw3GnWyeM4Loqt1lIq6Z7ZPuCSHgsJTzfLWrVaXG5RDsZU3tdnFTb9U/VBq2sqaUSbt60Bhq98fvBeiFz+swUmsERK8xXgnC3inbJJ7CuH7Mt9gpbEcYm7PlXlLhooM0sA0iNnAg6dFIzVYmGN6zUq7k4CVs68jTeozk9PU6zvJfVBHCgZMZ/TTXTRmMa9sldjvbAmmaizhgDz2lR8gSAuAGRbhvQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1605522467; bh=+ElxmFBdXh4Y6m8Ggqf4ti0+JpEfuGeKMeNsydqdBAN=; h=Date:From:To:Subject:From:Subject; b=q5VG8E9CPfylbOMd7AX79U/SfOYA4AMHn6G2hCMOiPcmKYdYn18kRP2KxvfIZscyAgT/g+sVEYsfPVWAIwUy961tL65JrxMQ4bxzucEZg5MmGjThoZZUZnq+9u9ZBMwr1WSWAkn+ydgFzqTWkQvj/WMN6yFfT14RHCESy6H5vRl72KzLesaGR6FpqxCw1KKBPhxvBFJlzSHsfqo9XghUp0juM9EnmJSih0BC8ysAOpV2jSKRllE/zNBZA9JEKnAzDDR5np21cfTqRc8e8bHo7FmWJR1QFbDGAZzORNcs64nf9JAvA+jMAFbIj62/ZpVqEI++iwA3gB+8yVAmD3Jwkw== X-YMail-OSG: o3q6.zUVM1lDT6FTOudSJeCycMy9kkngFDGnechPampJZi9VRUf_A5yWI.qYMC_ J3Lb3ImF.zt1XRTG29Xq2XAyzVFmG9k0bEH7VkVIob8EocWqGYU2enWvcTDmshbq7y9WJE6v_ML0 zwULlkvxJZNZrt4_O.hyIMROQjlXeXDx9khcm5TdBUDpuBD_48QxlJBNETbaZYIeDCfufkrA.T2T lOAjwHaL_VIf7ngi3U6syd9Mp.rWx.uOu12Q47zPHe0LXdypZsf24VazGqOAw0jgvoCUap0FmU_n L.ZPxT4mJgjNuNq.odoQcENlXdOqbKDm33YhJEf0rLxU7f64KGrZxEDYoxzVZLKE4Yphfqjw54Kz q0imKT9WetY_hTqIqVY5LpktWR1eKH1TX0oNC7C0xDhymPUv.fkEMzf4fHgorjnQ8L6UU5IJKJTW KDC6holLM4sZkQ2T5GaW6HltmpfXJZH60JMW4H0KnmYPtTXjuahIr5e1eI4mW6Ayr2okviJiWaSt mIe8CGBKBnh3Aufx98_.uBkBjAIHuT.9X6lRZQpMYBmdnFynMLybgn29h0VPkqi0f_ENu2gA3pzX _oF4hfP9Q8tSZBJBbkbKpFSyv0zXfZJudAq9VAXsq7PXUDnL1gtayBwvLxQ1s5WNo5Zhc8OnHyJ8 jgjrXLdPMicldItbtFObYrpkG2NV_eZmM9cfPSLsin6DlGYbP79gEMKzBz.qwuOyKsdV26AsYm7D wy0tyfR3LYLyWGs75M4hJr4oIvkrVGJYnRERCYlGzPQ_iLz3JuSkZXsDpy75zSIFMJabFJxaEH9m yAKPlvW2n.XNhaoFnoa.fZVTZKeEljEwdMHlGS20NY Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Mon, 16 Nov 2020 10:27:47 +0000 Original-Received: by smtp419.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 3507184bc51e1ac1a06c75ada30ce677; Mon, 16 Nov 2020 10:27:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87v9e5herj.fsf@mail.linkov.net> X-Mailer: WebService/1.1.16944 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.131.123; envelope-from=spacibba@aol.com; helo=sonic311-13.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 05:00:25 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259226 Archived-At: On Mon, Nov 16, 2020 at 10:54:48AM +0200, Juri Linkov wrote: >> Cycling is actually a fairly inefficient, unconscious >> way to navigate among candidates. It's handy, but >> dumb cycling shouldn't be the only or the main way to >> get around. > >I agree. I tried the completions-highlight-modifications branch, but >unfortunately restricting a set of navigation keys limits the freedom of >using any navigation key for browsing completion candidates that is >available today. What I mean is that currently it's possible in the >minibuffer to type (switch-to-completions), and then all keys >are available for selecting a completion: arrow keys, page scrolling >keys - even completion drop-down combo in browser's address bar allows >page scrolling. > Hi Juri: With the current implementation this is not supposed to change. Of course there is space for improvement and there are bugs, but so far, all navigation still works in *Completions* buffer as usual because I just added some commands. If there is anything that breaks the normal previous behavior somehow, please tell me; because I put special attention to prevent that. We could add a custom to disable the new bindings in the *Completions* if you think is better; because IMO the most important thing is to "navigate" with arrows the completions from the minibuffer without leaving it; and the overlay. WDYT?? The code is extremely simple, so, if you think you could improve anything it is more tan welcome. Ergus