From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: master 3de31e7: Fix compilation of image.c on MS-Windows Date: Mon, 9 Nov 2020 16:28:14 +0000 Message-ID: <20201109162814.GA36769@breton.holly.idiocy.org> References: <20201109153652.21064.52372@vcs0.savannah.gnu.org> <20201109153654.3EADA20A27@vcs0.savannah.gnu.org> <87pn4mjz3m.fsf@gnus.org> <83k0uu4i4q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37670"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 17:30:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcA3Q-0009eV-VC for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 17:30:04 +0100 Original-Received: from localhost ([::1]:35070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcA3P-0008Tu-VN for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 11:30:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcA1o-0007AE-G2 for emacs-devel@gnu.org; Mon, 09 Nov 2020 11:28:24 -0500 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:54926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcA1m-0001gT-Ao; Mon, 09 Nov 2020 11:28:24 -0500 Original-Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id 43873AAE; Mon, 9 Nov 2020 17:28:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1604939299; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1094; bh=+SR4kH2pbLkxdDISD+zb8Q4GLN0S9on/Lt2CnUBjq+o=; b=WKzvUqcbiDuKfHstne/5kIjloS2rN9Rdi4Cx1UZnwseWw2CvR3GG+3LAM3yyOp8I Cg4ceE6jqFurp/M16XJVNVOVJYFgVV4DgAjEBIeBM9A6ZCIViqJtfqh/UKul/IzSWk9 S47AiOcmHXD7OTYynSf4GAUNbUxSde7j2SLClzkjhzA3hPzdanVqq1sVrvJ387bmkxH 0DNRSaglZB4iQmROx5frSy6tkVfnuKj+h9WvEcE9jBOmOY9rZZ2C9zH+w/p019/I0zy pZZ/CrS/yTrzQsQlfCMe1vzLisEfoawhlA2R54VmIDcfE5OVJao5T/IyDHGv3WJSrs8 UCaFbfMi0g== Original-Received: by smtp.mailfence.com with ESMTPA ; Mon, 9 Nov 2020 17:28:15 +0100 (CET) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 8080420265E513; Mon, 9 Nov 2020 16:28:14 +0000 (GMT) Mail-Followup-To: Alan Third , Eli Zaretskii , Lars Ingebrigtsen , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <83k0uu4i4q.fsf@gnu.org> X-ContactOffice-Account: com:241649512 Received-SPF: pass client-ip=212.3.242.68; envelope-from=alan@idiocy.org; helo=wilbur.contactoffice.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 11:28:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258952 Archived-At: On Mon, Nov 09, 2020 at 06:20:05PM +0200, Eli Zaretskii wrote: > > From: Lars Ingebrigtsen > > Cc: Eli Zaretskii > > Date: Mon, 09 Nov 2020 17:04:29 +0100 > > > > eliz@gnu.org (Eli Zaretskii) writes: > > > > > Fix compilation of image.c on MS-Windows > > > > > > This is a followup to last change in image.c. > > > * src/image.c (rsvg_handle_get_intrinsic_dimensions): Define to > > > call fn_rsvg_handle_get_intrinsic_dimensions. > > > (svg_css_length_to_pixels): Compile only for librsvg >= 2.46.0, as > > > RsvgLength type was not defined before. > > > > This leads to the following warnings on Debian bullseye, apparently: > > > > image.c: In function ‘svg_css_length_to_pixels’: > > image.c:9769:13: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Surely, not my change led to this: I only made that code be > conditionally compiled. > > Alan, can you take a look, please? Di d you mean for the control flow > to fall-though in these places? My mistake. I've pushed a fix. Thanks. -- Alan Third