unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master 3de31e7: Fix compilation of image.c on MS-Windows
Date: Mon, 9 Nov 2020 16:28:14 +0000	[thread overview]
Message-ID: <20201109162814.GA36769@breton.holly.idiocy.org> (raw)
In-Reply-To: <83k0uu4i4q.fsf@gnu.org>

On Mon, Nov 09, 2020 at 06:20:05PM +0200, Eli Zaretskii wrote:
> > From: Lars Ingebrigtsen <larsi@gnus.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>
> > Date: Mon, 09 Nov 2020 17:04:29 +0100
> > 
> > eliz@gnu.org (Eli Zaretskii) writes:
> > 
> > >     Fix compilation of image.c on MS-Windows
> > >
> > >     This is a followup to last change in image.c.
> > >     * src/image.c (rsvg_handle_get_intrinsic_dimensions): Define to
> > >     call fn_rsvg_handle_get_intrinsic_dimensions.
> > >     (svg_css_length_to_pixels): Compile only for librsvg >= 2.46.0, as
> > >     RsvgLength type was not defined before.
> > 
> > This leads to the following warnings on Debian bullseye, apparently:
> > 
> > image.c: In function ‘svg_css_length_to_pixels’:
> > image.c:9769:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Surely, not my change led to this: I only made that code be
> conditionally compiled.
> 
> Alan, can you take a look, please?  Di d you mean for the control flow
> to fall-though in these places?

My mistake. I've pushed a fix.

Thanks.

-- 
Alan Third



  reply	other threads:[~2020-11-09 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201109153652.21064.52372@vcs0.savannah.gnu.org>
     [not found] ` <20201109153654.3EADA20A27@vcs0.savannah.gnu.org>
2020-11-09 16:04   ` master 3de31e7: Fix compilation of image.c on MS-Windows Lars Ingebrigtsen
2020-11-09 16:20     ` Eli Zaretskii
2020-11-09 16:28       ` Alan Third [this message]
2020-11-09 23:44       ` Andy Moreton
2020-11-10 15:13         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109162814.GA36769@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).