From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Support "\n" in icomplete-separator Date: Fri, 6 Nov 2020 01:04:10 +0100 Message-ID: <20201106000410.2uvq6x2iktdglq22@Ergus> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1312"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrii Kolomoiets , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 01:05:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kapG0-0000Da-Vx for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 01:05:33 +0100 Original-Received: from localhost ([::1]:45324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kapG0-0004gW-0J for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 19:05:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kapF7-0004CU-4B for emacs-devel@gnu.org; Thu, 05 Nov 2020 19:04:37 -0500 Original-Received: from sonic308-3.consmr.mail.bf2.yahoo.com ([74.6.130.42]:42453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kapF3-0007uP-Gl for emacs-devel@gnu.org; Thu, 05 Nov 2020 19:04:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1604621069; bh=e7Ss/V0Q2/T1PZu9/CyZKXiijEUZMd8V5F39WCF8VTY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=bZCsAXI+ym3QUebh71YNTT8Mdh3RvetFv9EDxSmf2KEGWmPjJoRSH7sYRql9oT71IiNcwwyxEdp2q+3I3IuKU6Z2EWgdrGS/6/j4USv7zz/4QAd8oeYNsobWt+TpbvwP9DThkAgchc53Vtd8QxmG/dyb/vJFUQSEMtUI3vbmuDABnv9Pbzd51CU19zUsiS51E9nh74ViSEfoMOJD9x2L7SPi8hmtPegyW4hdboltPAN0bmn89CpU5aWC0syY/mJYoimTAfiw8sU6ljhlHsakpbXDvco2MGwtqg8eYXxA5jCJUc2s+fW5fmULD5hDxoY81+gQARrvV0gok8/OR/lCuw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1604621069; bh=8kIpD1QbDuKd5zRqrQpEosrSD6KBLbNgN76lwgZvY4E=; h=Date:From:To:Subject; b=VbYgfEhPiA+IYcuDmyXUdGnSKx8ZCosgp661VjLLr29lkf+CjVHYD9Iz6Asm+Z359Ni/TCdiVLvCdju5p2COlG3cXwgZctHs5NW+nYMhf7KeEQQBFsas6DeQUxLTnKRfQuNSKMOTF+DajUM6VJ1XRWNVrGDz4D9JZm0ICMkX6a05SFUnqa8d/7kHPMGucutUaq41rB7pI5yE4X3k9d8VCP++pgUD7HpkN8Iigh2Q1+MTSrXwXrRz+3D+omJov607ATcg4Z3l1FSht1YyH3sgm0No++pJyNNJgitCs9eBpRvutREJao97g8iqTjLC27q0lynepv3uSxem5OLB7w437A== X-YMail-OSG: D1C.IGgVM1nH7lT3YAu8ytOFFrAPFXMQNTYk9iYT6Hobfv0psStL.Jk5xSnL7nU BjMgLkXi_YlXOWH57Z94C_lDQmdcqKQIWBq_WuYx27vBo8pV.I2cXr66T71uyiKu2XtBJZXzjIIC A1BJYpr2Cvcumm.7F9oUTXn75nEPIkLZMXhuIVAS5UluksoUX00MAO_PtcUQ_lcGppicDPBIWZFW 13f8pdnZbPuEXxN7D2dGSBibZqL5Pxjq3gbKnsNYlqy4Tl7ZvO1no2a2ANhhp5pT2bJ8fqnDLBpP 4kcaLEs8.qYczu1jVshdSpIwHA2Fw51Kx6mG6IdO.H.QyZsKDvXwo3KFQOeTyDKNKFPCGntoZDh2 5l010yTBc4BxN3zb1Dc6Komp7G2SXTbBlFL7T4UB8gUkWYDTTgbC326a1e41wUpilq69eMAHipfd i.O4REMj_uZ4buG4.Dy7omUa_.wwQwUuVKxaU1RWZ9HhNI4eivC9uMXWFNQfvQu4hyj_fgxfhwpV 8JyF5zwoqu8H_p5ArjPo2ux3gGgifynokKJl_Ya1JHz076ox2jW2GQnwWtC4rHY.54uqOO91A991 VZlr7Ig7L2Gesc2_dkuacFquR6b_ujwdLJIhNPqc5kwxtB_RO6HiJq0riROlBHomlxB7DG.cJJUX 9W0M9JYiJtsaU7sR5xy4cEXqJfE46CFKqxzakcGm1N62Z1i0SPz1B8VafmeLNLpsCn.iQdL5BDKY 6GPH0JAez9quX1KRP2jDKDDYeEIgGlLb3MsZb7sjIURbqcAtXTXtPNFlQtZpGOlkOn5.KGj_ggcz gXjmlpwumM0WUUtE2WTv24.89SpuVBmy93pfTOXL3w Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.bf2.yahoo.com with HTTP; Fri, 6 Nov 2020 00:04:29 +0000 Original-Received: by smtp419.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8b63b9748f2abf3ed81dc8d03a2d9d72; Fri, 06 Nov 2020 00:04:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16944 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.130.42; envelope-from=spacibba@aol.com; helo=sonic308-3.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 19:04:29 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258772 Archived-At: On Thu, Nov 05, 2020 at 06:29:47PM -0500, Stefan Monnier wrote: >> I'm a bit late to the icomplete-vertical party, but please let me show >> you my approach at supporting "\n" in 'icomplete-separator'. > >A side-note: I think the use of "..." to indicate that there are more >entries is a bad idea. Better represent it with the absence of >a terminator (e.g. in the normal icomplete-mode, it basically means >replace "...}" with ""). It will make the code simpler, more robust, >and a side benefit is that it will make slightly more efficient use of >the screen real estate. > > > Stefan > Hi Stefan I agree that taking a like only for the ellipsis is inefficient witht he space. Actually the ellipsis is something I would like to discuss, but nobody put attention on it before ;(, so I was basically waiting to receive some feedback (and complains) respecting to that maybe after pushing into master.. The problem in vertical is that it will be "better" if we don't add {} or if it is at least customizable (to have a more ivy-like experience). What I thought maybe would be to add the ellipsis in the same line of the last candidate like: aaa bbb ccc... or so... But it was not good enough in my opinion. WDYT?