From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 5 Nov 2020 23:36:15 +0100 Message-ID: <20201105223615.xg43vj3o733x5uqc@Ergus> References: <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> <20201105210915.3rl3z6jngsrzgbwv@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25118"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , "Gregory Heytings via Emacs development discussions." , Manuel Uberti , Jean Louis To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 23:37:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kansz-0006Rv-48 for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 23:37:41 +0100 Original-Received: from localhost ([::1]:49610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kansy-0004Ko-6l for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 17:37:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kans3-0003sf-Jt for emacs-devel@gnu.org; Thu, 05 Nov 2020 17:36:43 -0500 Original-Received: from sonic301-3.consmr.mail.bf2.yahoo.com ([74.6.129.42]:45663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kanry-0006MF-Sl for emacs-devel@gnu.org; Thu, 05 Nov 2020 17:36:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1604615793; bh=n/4SmUXLFsdroXBKlg14f7HHl+GeIqQCYVo/oVFyYPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=rf9hB4wTPbUph4x1Lf8YoyANrUG5OCJXAQJ9/0S15mL0sDX9Bj8iGyhTaVhm7Ym8wZH7VT+IT5uV5wDx3/cF1jgZmzBJyLDNXaUcQ01wziFv381i5+/hxHFafZtRxqml6PeYc0hGaLuTyee/zRSKK7xi/2BsKbCTi1xwKIffDZnLmb5aXWEDH7x16vFxAdji7gfvroM5MSRYyFCwPoctp7j4EFZFH+jXwYuubrpi/Ll4CCsVIbfBD4B9V7y4ILRQghPY/asndcV5tSnbI94swnBmQC93fIpA8OYbjpjkn3PukGBwwCg7qjWL8sNwxeWluPc9h12jId/rBw8k2fK/lg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1604615793; bh=zed6aA8sc9CoqqU1oRt6RHr9bCbtLyzNKQMJrqk5+Cn=; h=Date:From:To:Subject; b=UL88l+9WsvStPjUBJgXJjAvKmLudOcuatsg8NEVMO2+4byg/N1bbbdA8UXTuciFkpNsPlXrfbFBtnopq5aJEEk8rPH/UwWx1VPV9RrC6HRrlU4YueCAjixX87KeE/wCO7dcESiC/4FBmGwni5PLooGJaCM3vnymzGFJmUuYCKNbKoDqHnfpHX0Ivzs2SC0e9XkFjHRxMiBIAp0A5vcFwRKrPnANYiSvy1zDNdb0EfjlqPqoLyy2/1z77ik44WLoqVkjT5xMBLDUvUgASW4DlPswwYHYTgyALooFH6ZXMm3WPDYByffpzMEIhSMm36XNwGK396FynEAtzFoWcVrQqOg== X-YMail-OSG: lAH3tzoVM1kl9SzO_EM.Rei39Lx5de.oaRume45yujSny_d5hJ9VNL.8gDs.Sn6 diS0CRZUC23mW_uUMUQ95drlbPHyWjeHsqGpGWTo8AWhNMC4c5kPi7EKY5dVW_Usku946g14ZFKT 8UKJB7gisHXUA_T_s3GcFpirsDdWpyj.2fJXHoIOtwxgoFfM3Ja0.mOVy5qRGpDG9W_G7gVmU90j RkIJWeZr0iRZoNPg2dHd_IrHeKBeRUF1RGpjikjiPl4PosHUmMozTCy5RsraQsF.QZxOAJMBXUce V_ZbxeTiaCi0M8gVqUBHYDYnTkCGRtHiZDpQ.yT9HWEUsWL1F3xpGhB3WWVeRrpqBW0TAiVzdEVw gVOQ3RBE4N9ZfdEvwDXlW8ARpi1LrYGUEjQTJHUyg3K2dPK5m_V22CdzGgQV6pCnCMLl9OAL7Y.c YddINhEB36TbZayfUSDYul3L21.zJavggYqS1twAqQcg55wpCxgivi3jEY7GPOKo_QooalFAAdjP v1KRGSmshQ5DA19rWcyKtAJvC.6yKlCWLA4x1kVWvw8rvlfVm0fHURogkE9hTtyjXSHFTEhX3Bpb Xwsckxih1yTL77xSxumjj2uwSxvfUl1Y7Q4IzD.sbD60yw27OJ1NQD8L3m6wLedHK9ThqNeMYDML Y.M76wwTgZzBkm0xMQs5UM3CmJlX1MV7dvHEScSOz6DA0g5jj1UHDfV7v4f_8C4eszu8SrWSSU0s bYcEjRAQEhDb_8uF71Sylk09yK.9ykFhX6IRFPP7TZ3aYlmGsq8vZXZvld1ahmNtlcyXlcrT2b_S TFDmwkhmvMYaVavwi3doTiLb7OEj8s2R3pf7rbjYmL Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Thu, 5 Nov 2020 22:36:33 +0000 Original-Received: by smtp405.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 15e60569445e6ecddf6418c19e8f7011; Thu, 05 Nov 2020 22:36:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16944 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.129.42; envelope-from=spacibba@aol.com; helo=sonic301-3.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 17:36:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258768 Archived-At: On Thu, Nov 05, 2020 at 10:00:57PM +0000, Gregory Heytings via Emacs development discussions. wrote: > >>>This has been discussed at length earlier: it is in practice >>>impossible to calculate the height of the minibuffer, and to >>>calculate the size of the completion candidates list to insert in >>>the minibuffer. Yet you need to do both to have a correct >>>solution with the approach of the branch. >> >>With the current display code on `master`, I don't think the >>behaviors you refer to can qualify as incorrect. >> > >Which is why I said, in the two previous mails, "not 100% correct" and >"not always correct". I did not think it was necessary to repeat >"always" here. > >> >>You can argue that they are less often preferable than some other >>choice, but that's a far cry from incorrect, IMO, and then should be >>fairly uncommon. So it's definitely not very high priority and >>shouldn't decide whether we install a particular version of the code >>right now. >> > >My point is that now that `(setq icomplete-separator "\n")' works (in >most but not all cases), there is no need for the specific >vertical-icomplete implementation anymore. What is (or could be) >needed is an implementation that is "more correct" (correct in all >cases). > I don't totally agree is the same than the branch. The completion like "compi{compilation" with fido mode is still there, in the same line and is not intuitive; the ellipsis is not shown and the {} and [] are still there and hard coded. icomplete-prospects-height is not respected either because the number of candidates is still calculated with the window-width and adding the candidates length which actually makes no sense at all in vertical mode. The pixel calculation is just part of the modifications in the branch.