From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 5 Nov 2020 22:09:15 +0100 Message-ID: <20201105210915.3rl3z6jngsrzgbwv@Ergus> References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39000"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jean Louis , Manuel Uberti , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 22:10:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kamWv-000A3i-Bu for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 22:10:49 +0100 Original-Received: from localhost ([::1]:57528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kamWu-0008Ga-A4 for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 16:10:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kamVo-0007mB-9b for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:09:40 -0500 Original-Received: from sonic314-14.consmr.mail.bf2.yahoo.com ([74.6.132.124]:35826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kamVk-0003qV-U8 for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:09:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1604610572; bh=/8Vx553inbUepbk93s+wWglqtZsvG//2gwRU6xttRZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=RMNg16FLnHEn9hRGvW/MTmw4Q2O1iJVrWLTFMM+9D4oJG3JnKHSdOlCXrpzWHViKiucNKnfN8KpQT0hci0FwkftFlz9iUL8iozHLehKgnJtZ4ksnR1DavD0GwBumfNc+qLrZpUgm/0/5nH4oGnipV7XUKODseVwvmj6YWua/bafkUiAYgsBraDDMrmVSQ29BUVq100v/lFLZSdntEA/sHWeR422Vtuev1QcRlnsUIoEEBzjDaOfELw5aAesw9eEzWPy+AZb1om1R9Y+hAHB+BxSiMkL3hLppwI7qFn5huGcQEr06Mt3TSvznif5C7+J8WZvdilutQtz+IbTgVZ04bg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1604610572; bh=XMHzLZ0iX4Gcm/pbkYXA7jgN52ARL9thqqgt2DYE0Vv=; h=Date:From:To:Subject; b=UYrdl4X+0Xy0wccHZ5Nu3WxFeEz4zK49LZCVq4JoJPdYWZdfQzYdVbxlc/bgAawm9dySO/7KzMcjLQ5IvnP90bQueeIWM1ph8TozYpG9pjCAMAF9HWmoDgiNUDREop/GtlscnSdnRghRaRwAtjokUADma/5hF8ScqJ/QONzLel7qgiKz9g4lZCesYPJ+q7LmU1oZFCVbt+lbAir4RN/fg4r1RfIAra9MZxlSKweeuw5fyiGQkA5Y3mLrG4U5We0OsrwiTxwaBeXMcDCtt37Osfa2Gk9G3w1YCQ3yAZsG4G8NGNSI5QU/5IaRWK/3ZA3/T88YS6QovjypsHJYh7A08Q== X-YMail-OSG: GAnMlOYVM1m1i9vYGa9DWkw98gSMA38DzT0DLPixVZwjkubkX8JyTuQDauHWh24 RxpfVLkMEdGX95QVGIubG_GrYarrvlIMEFCqZ2y4LT9.74zIMFZo.dzNzsmpwFtlF2VNGC0vbV_o Fb71oDloQd4G0u8xFhQGPjB6JyxvJICmnNXrx.bI3pAzyCfwUplKYGzCv6NmwaqaldSWthImWXIV uT1DE9vfjezECR_13SEfeuZSflyuexvEQyqK4b53_1AvIZ2obmXgD2vU2P16NqrW_TLUf8cE2xNB IufETsRbvOiUEk1Y8hXjwxTutbk.1iX_TKhBZmVZHiYwjv9tmWjISsELk26sDFhxDUSTno9z.Jlr UELoYJSQy_nzv8AHVTBbKwRt9x5cFIAj9CQsd38MpVZfxCCUT7NZXRpHUg2yZpmg3H5Rw9EOKb5h sYaAkkgXmhQK2E26NVmR4eByPi98k7PGv262XtZJkdcRKLtrxaNHKbw8E5nd5HH8wbXuMCFJiqtS YMpuIS0QJv8f4FT5HQth_Fc0dsNouzgWYBorekaoC4R0.vDsO7n2LNxwwdrf8wXRW5FHKZIyoHLs 433sywCThXEnHUhA5FQEpOPR9g0rqViJSHIO1wBeF44MyFjPHY7DSWZSyUaxDOZ_ccI5s0vrKelo Bdeo6_r1Ah80SuImRzU8MVSXT_iRg5DUwcBLcJx7t7R7OFeiY9V8hKqLr2E7wOBb5OE2IpmZrCXf gt2Evdeici2aLPxDKaKA2Tn4QO4Ta7mSBRGDGNbf3vpH1eI6hGQe7luh_slcKZbLGPMfyIHk2DJX K8ow_5o_RYMdpKbLCzV08XWEmRqr1YKqLTaHXT0kS6 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Thu, 5 Nov 2020 21:09:32 +0000 Original-Received: by smtp408.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 152da399f94bbe9c2de08d5201193b24; Thu, 05 Nov 2020 21:09:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16944 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.132.124; envelope-from=spacibba@aol.com; helo=sonic314-14.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 16:09:32 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258759 Archived-At: On Thu, Nov 05, 2020 at 08:39:03PM +0000, Gregory Heytings via Emacs development discussions. wrote: > >> >>How can I checkout that branch? >> > >As I said earlier in this thread, you can have icomplete-vertical >without using that branch, with the master branch you only need to >`(setq icomplete-separator "\n")'. > >If you want a more robust solution however (neither the above nor the >branch are always correct), In which case the branch is not correct? >you'll have to wait. If you don't want to >wait, you can try my proposed solution (see attached), which works for >any version of Emacs >= 24. >(defvar-local start-display-at-beginning-of-minibuffer nil) >(defun start-display-at-beginning-of-minibuffer (&rest args) > (when (and start-display-at-beginning-of-minibuffer (minibufferp)) > (set-window-start-at-begin (point-min) (point)))) >(defun set-window-start-at-begin (beg end) > (when (< (+ beg 2) end) > (set-window-start nil beg) > (unless (pos-visible-in-window-p end nil t) > (set-window-start-at-begin (+ beg (/ (- end beg) 2)) end)))) >(add-hook 'window-scroll-functions #'start-display-at-beginning-of-minibuffer) >(add-hook 'post-command-hook #'start-display-at-beginning-of-minibuffer) > >(setq icomplete-separator "\n") >(add-hook 'icomplete-minibuffer-setup-hook (lambda () (setq start-display-at-beginning-of-minibuffer t))) >(defun icomplete-vertical-reformat-completions (completions) > (save-match-data > (if (string-match "^\\((.*)\\|\\[.*\\]\\)?{\\(\\(?:.\\|\n\\)+\\)}" completions) > (format "%s \n%s" (or (match-string 1 completions) "") (match-string 2 completions)) > completions))) >(advice-add 'icomplete-completions :filter-return #'icomplete-vertical-reformat-completions)