From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Stop frames stealing eachothers' minibuffers! Date: Sat, 31 Oct 2020 20:39:14 +0000 Message-ID: <20201031203914.GD5887@ACM> References: <83wnzrwdy5.fsf@gnu.org> <20201021151945.GA19276@ACM> <20201021200438.GF19276@ACM> <83h7qmkzla.fsf@gnu.org> <20201030220917.GA17594@ACM> <83v9eq97sj.fsf@gnu.org> <20201031161422.GA5887@ACM> <83d00ygx9c.fsf@gnu.org> <20201031194419.GC5887@ACM> <834kmago8m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39923"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 31 21:39:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYxfD-000AJH-1Q for ged-emacs-devel@m.gmane-mx.org; Sat, 31 Oct 2020 21:39:51 +0100 Original-Received: from localhost ([::1]:52370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYxfC-0007TQ-4A for ged-emacs-devel@m.gmane-mx.org; Sat, 31 Oct 2020 16:39:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYxeh-000734-Kk for emacs-devel@gnu.org; Sat, 31 Oct 2020 16:39:19 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:46144 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1kYxef-0001Iw-F2 for emacs-devel@gnu.org; Sat, 31 Oct 2020 16:39:19 -0400 Original-Received: (qmail 93007 invoked by uid 3782); 31 Oct 2020 20:39:14 -0000 Original-Received: from acm.muc.de (p2e5d5579.dip0.t-ipconnect.de [46.93.85.121]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sat, 31 Oct 2020 21:39:13 +0100 Original-Received: (qmail 19505 invoked by uid 1000); 31 Oct 2020 20:39:14 -0000 Content-Disposition: inline In-Reply-To: <834kmago8m.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/31 15:44:20 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258591 Archived-At: Hello, Eli. On Sat, Oct 31, 2020 at 22:00:09 +0200, Eli Zaretskii wrote: > > Date: Sat, 31 Oct 2020 19:44:19 +0000 > > Cc: emacs-devel@gnu.org > > From: Alan Mackenzie > > I can't remember very clearly, but I think I made this change early on in > > the project because the Fthrow (Qexit, str); left some mini-windows in a > > messy state; or something like that. That doesn't happen any more. > > So, maybe I should just remove this hunk from the proposed patch. It > > doesn't seem that important any more. > Fine with me. OK, that's done. > > How about emptying mini-windows which don't have live minibuffers on > > them? This could be tested by Fminibufferp (b, Qt). In practice, when > > minibuffer-follows-selected-frame this would empty all mini-windows but > > the current one, and when !m-f-s-f it would leave intact the mini-windows > > we want to be left intact. > let me turn the table and ask why this hunk is needed? What doesn't > work right if this code is left in place? Without that hunk (i.e. with the emptying-out code): (i) emacs -Q (ii) M-: (setq minibuffer-follows-selected-frame nil) (iii) C-x 5 2 ; giving two frames. (iv) C-x b ; leaving a minibuffer open. (v) C-x 5 o ; move to other frame. (vi) C-r in ; start an isearch. (vii) C-x 8 RET ; intending on inserting a non-keyboard character. At this point, the mini-window in Frame 1 is emptied. This is bad. There appears to be no way to get its minibuffer back again. By contrast, the same sequence of operations without (ii) (with an extra step: (v).5 C-x o ; move to the ordinary window. ), the first minibuffer is "protected" on Frame 2 underneath the C-x 8 RET minibuffer. So, when the isearch is finished, the "Switch to buffer" minibuffer appears again, and is active. -- Alan Mackenzie (Nuremberg, Germany).