From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Recommend lexical-binding in Coding Conventions Date: Wed, 21 Oct 2020 15:30:06 +0000 Message-ID: <20201021153006.GB19276@ACM> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35964"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 21 17:36:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVGAL-0009Gk-EK for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Oct 2020 17:36:41 +0200 Original-Received: from localhost ([::1]:50866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVGAK-0004c3-GW for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Oct 2020 11:36:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVG46-0000Pi-Cb for emacs-devel@gnu.org; Wed, 21 Oct 2020 11:30:15 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:14239 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1kVG42-00046o-OQ for emacs-devel@gnu.org; Wed, 21 Oct 2020 11:30:14 -0400 Original-Received: (qmail 66375 invoked by uid 3782); 21 Oct 2020 15:30:07 -0000 Original-Received: from acm.muc.de (p4fe159f6.dip0.t-ipconnect.de [79.225.89.246]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Wed, 21 Oct 2020 17:30:06 +0200 Original-Received: (qmail 19756 invoked by uid 1000); 21 Oct 2020 15:30:06 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/21 11:19:46 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258234 Archived-At: Hello, Stefan. On Wed, Oct 21, 2020 at 08:14:46 -0700, Stefan Kangas wrote: > Drew Adams writes: > >> @item > >> We recommended to enable @code{lexical-binding} in all new code, and > >> to convert existing Emacs Lisp code to enable @code{lexical-binding} > >> if it doesn't already. @xref{Using Lexical Binding}. > Yes, that is indeed more clear. Thanks. > > My suggestion is to speak only in terms of the variable, > > `lexical-binding'. > That suggestion is satisfied by the above edited text, right? Just a couple of comments on the English usage. We recommended -> we recommend. :-) The verb "recommend" needs a direct object (or gerund). That direct object can either be the thing recommended, or the person to whom the recommendation is being made. So, correct forms of your statement would be either: We recommend YOU to enable ... and to convert ..... or We recommend ENABLING .... and CONVERTING .... . English isn't always an easy language. ;-) -- Alan Mackenzie (Nuremberg, Germany).