From: Alan Mackenzie <acm@muc.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Drew Adams <drew.adams@oracle.com>,
emacs-devel@gnu.org
Subject: Re: Recommend lexical-binding in Coding Conventions
Date: Wed, 21 Oct 2020 15:30:06 +0000 [thread overview]
Message-ID: <20201021153006.GB19276@ACM> (raw)
In-Reply-To: <CADwFkm=CtJAf5Eu3ihP5fMA+rrD9ACeXBoohwn6U5RMpa-5oKA@mail.gmail.com>
Hello, Stefan.
On Wed, Oct 21, 2020 at 08:14:46 -0700, Stefan Kangas wrote:
> Drew Adams <drew.adams@oracle.com> writes:
> >> @item
> >> We recommended to enable @code{lexical-binding} in all new code, and
> >> to convert existing Emacs Lisp code to enable @code{lexical-binding}
> >> if it doesn't already. @xref{Using Lexical Binding}.
> Yes, that is indeed more clear. Thanks.
> > My suggestion is to speak only in terms of the variable,
> > `lexical-binding'.
> That suggestion is satisfied by the above edited text, right?
Just a couple of comments on the English usage.
We recommended -> we recommend. :-)
The verb "recommend" needs a direct object (or gerund). That direct
object can either be the thing recommended, or the person to whom the
recommendation is being made.
So, correct forms of your statement would be either:
We recommend YOU to enable ... and to convert .....
or
We recommend ENABLING .... and CONVERTING ....
. English isn't always an easy language. ;-)
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2020-10-21 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 1:05 Recommend lexical-binding in Coding Conventions Stefan Kangas
2020-10-21 4:32 ` Drew Adams
2020-10-21 13:33 ` Stefan Monnier
2020-10-21 14:52 ` Drew Adams
2020-10-21 15:14 ` Stefan Kangas
2020-10-21 15:30 ` Alan Mackenzie [this message]
2020-10-21 16:07 ` Robert Pluim
2020-10-21 16:19 ` Stefan Kangas
2020-10-21 16:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021153006.GB19276@ACM \
--to=acm@muc.de \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).