Incompatible change of update-file-autoloads function

Incompatible change of update-file-autoloads function

[Yasuhiro KIMURA]

Hello,

I updated emacs to current HEAD of master branch and found build of a
certain 3rd party application fails with following code.

----------------------------------------------------------------------
(defun lookup-autoload ()
  (require 'autoload)
  (setq generated-autoload-file
	(expand-file-name "lookup-autoloads.el" default-directory)
	backup-enable-predicate 'ignore)
  (mapc (lambda (file)
          (update-file-autoloads file t))
        command-line-args-left))
----------------------------------------------------------------------

I did bisect test and found the error happens after following commit.

----------------------------------------------------------------------
commit 6f36b67e4146ef4610916b7903fd292e1308daf5
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date:   Fri Oct 2 04:34:31 2020 +0200

    Stop using a dynamically bound 'generated-autoload-file' variable

    * doc/lispref/loading.texi (Autoload): Document change of name
    (bug#39823).

    * lisp/emacs-lisp/autoload.el (autoload-find-generated-file): Pass
    the file name in.
    (autoload-generated-file): Ditto.
    (autoload-file-load-name): Ditto.
    (generate-file-autoloads): Ditto.
    (autoload--setup-output): Ditto.
    (autoload-generate-file-autoloads): Ditto, and alter doc string to
    reflect when `generated-autoload-file' is heeded.
    (update-file-autoloads): Pass outfile in to functions.
    (autoload-find-destination): Ditto.
    (update-directory-autoloads): Make into an obsolete shim around
    `make-directory-autoloads'.
    (make-directory-autoloads): Renamed from
    `update-directory-autoloads' with new semantics.
    (batch-update-autoloads): Adjust caller.

    * lisp/emacs-lisp/package.el (package-generate-autoloads): Adjust
    caller.
----------------------------------------------------------------------

According to commit message update-file-autoloads function seems to
change incompatibly.

Then is there any way to make above lookup-autoload function work fine
with both before and after this commit?

Best Regards.

---
Yasuhiro KIMURA

Re: Incompatible change of update-file-autoloads function

[Lars Ingebrigtsen]

Yasuhiro KIMURA <yasu@utahime.org> writes:

> I updated emacs to current HEAD of master branch and found build of a
> certain 3rd party application fails with following code.
>
> ----------------------------------------------------------------------
> (defun lookup-autoload ()
>   (require 'autoload)
>   (setq generated-autoload-file
> 	(expand-file-name "lookup-autoloads.el" default-directory)
> 	backup-enable-predicate 'ignore)
>   (mapc (lambda (file)
>           (update-file-autoloads file t))
>         command-line-args-left))
> ----------------------------------------------------------------------

I've pushed a change I think should fix this bug to the trunk now.  Can
you update and check?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Incompatible change of update-file-autoloads function

[Yasuhiro KIMURA]

From: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: Incompatible change of update-file-autoloads function
Date: Sun, 04 Oct 2020 16:32:47 +0200

> I've pushed a change I think should fix this bug to the trunk now.  Can
> you update and check?

I confirmed the problem is fixed with your commit. Thank you for quick
response.

---
Yasuhiro KIMURA