From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yasuhiro KIMURA Newsgroups: gmane.emacs.devel Subject: Incompatible change of update-file-autoloads function Date: Sun, 04 Oct 2020 23:18:11 +0900 (JST) Message-ID: <20201004.231811.1933338792984225812.yasu@utahime.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11511"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 04 16:22:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP4uR-0002ti-G7 for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Oct 2020 16:22:43 +0200 Original-Received: from localhost ([::1]:43408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP4uQ-00047D-J3 for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Oct 2020 10:22:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP4tt-0003fn-8y for emacs-devel@gnu.org; Sun, 04 Oct 2020 10:22:09 -0400 Original-Received: from gate.utahime.jp ([183.180.29.210]:32913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP4tr-0006FP-1R for emacs-devel@gnu.org; Sun, 04 Oct 2020 10:22:08 -0400 Original-Received: from eastasia.home.utahime.org (eastasia.home.utahime.org [192.168.174.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by gate.utahime.jp (Postfix) with ESMTPS id 5F0CB3ED58; Sun, 4 Oct 2020 23:21:58 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=utahime.org; s=maybe2019112701; t=1601821318; bh=rzZLm2JfpOzgMpprZAwS3u9AOTuKaMSd8YJFDElhsgQ=; h=Date:To:Subject:From; b=Pb6eebI36YP6maBSt0MN65hAVtsaRnA3tYitJI3JXkfOarW7AvlRwC7Mgi7NTEEHx x2UGyV4ggu5P0sfMu2GPlM6e6FTBiQPk2N9mgGUk3hBkqnRQcyY8Y08ZyGm5wWZCZt hX2thsDlUx9WRg0vBIPo1yAnB9y84qqKnEPHijkZmavATC0u1vh2yZcqBHJDZQ2xhK 9UruUKS/f1WyYD9xelc1b+IwEzl3JacGAVGn9y67/QTNep3KbGLT1bJsuQJQFtCTO5 hEq5f4DVIA8z/tXE2WDKvJdOczXcy3pJW2TURmkuGYQkPp69EAAIvjwVGQOaTnJeKW ZnsAa0+CuGaBw== Original-Received: from localhost (rolling.home.utahime.org [192.168.174.11]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by eastasia.home.utahime.org (Postfix) with ESMTPSA id 92709219CE; Sun, 4 Oct 2020 23:21:55 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.0 at eastasia.home.utahime.org X-Mailer: Mew version 6.8 on Emacs 27.1 Received-SPF: pass client-ip=183.180.29.210; envelope-from=yasu@utahime.org; helo=gate.utahime.jp X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/04 10:21:59 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257029 Archived-At: Hello, I updated emacs to current HEAD of master branch and found build of a certain 3rd party application fails with following code. ---------------------------------------------------------------------- (defun lookup-autoload () (require 'autoload) (setq generated-autoload-file (expand-file-name "lookup-autoloads.el" default-directory) backup-enable-predicate 'ignore) (mapc (lambda (file) (update-file-autoloads file t)) command-line-args-left)) ---------------------------------------------------------------------- I did bisect test and found the error happens after following commit. ---------------------------------------------------------------------- commit 6f36b67e4146ef4610916b7903fd292e1308daf5 Author: Lars Ingebrigtsen Date: Fri Oct 2 04:34:31 2020 +0200 Stop using a dynamically bound 'generated-autoload-file' variable * doc/lispref/loading.texi (Autoload): Document change of name (bug#39823). * lisp/emacs-lisp/autoload.el (autoload-find-generated-file): Pass the file name in. (autoload-generated-file): Ditto. (autoload-file-load-name): Ditto. (generate-file-autoloads): Ditto. (autoload--setup-output): Ditto. (autoload-generate-file-autoloads): Ditto, and alter doc string to reflect when `generated-autoload-file' is heeded. (update-file-autoloads): Pass outfile in to functions. (autoload-find-destination): Ditto. (update-directory-autoloads): Make into an obsolete shim around `make-directory-autoloads'. (make-directory-autoloads): Renamed from `update-directory-autoloads' with new semantics. (batch-update-autoloads): Adjust caller. * lisp/emacs-lisp/package.el (package-generate-autoloads): Adjust caller. ---------------------------------------------------------------------- According to commit message update-file-autoloads function seems to change incompatibly. Then is there any way to make above lookup-autoload function work fine with both before and after this commit? Best Regards. --- Yasuhiro KIMURA