unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yasuhiro KIMURA <yasu@utahime.org>
To: emacs-devel@gnu.org
Subject: Incompatible change of update-file-autoloads function
Date: Sun, 04 Oct 2020 23:18:11 +0900 (JST)	[thread overview]
Message-ID: <20201004.231811.1933338792984225812.yasu@utahime.org> (raw)

Hello,

I updated emacs to current HEAD of master branch and found build of a
certain 3rd party application fails with following code.

----------------------------------------------------------------------
(defun lookup-autoload ()
  (require 'autoload)
  (setq generated-autoload-file
	(expand-file-name "lookup-autoloads.el" default-directory)
	backup-enable-predicate 'ignore)
  (mapc (lambda (file)
          (update-file-autoloads file t))
        command-line-args-left))
----------------------------------------------------------------------

I did bisect test and found the error happens after following commit.

----------------------------------------------------------------------
commit 6f36b67e4146ef4610916b7903fd292e1308daf5
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date:   Fri Oct 2 04:34:31 2020 +0200

    Stop using a dynamically bound 'generated-autoload-file' variable

    * doc/lispref/loading.texi (Autoload): Document change of name
    (bug#39823).

    * lisp/emacs-lisp/autoload.el (autoload-find-generated-file): Pass
    the file name in.
    (autoload-generated-file): Ditto.
    (autoload-file-load-name): Ditto.
    (generate-file-autoloads): Ditto.
    (autoload--setup-output): Ditto.
    (autoload-generate-file-autoloads): Ditto, and alter doc string to
    reflect when `generated-autoload-file' is heeded.
    (update-file-autoloads): Pass outfile in to functions.
    (autoload-find-destination): Ditto.
    (update-directory-autoloads): Make into an obsolete shim around
    `make-directory-autoloads'.
    (make-directory-autoloads): Renamed from
    `update-directory-autoloads' with new semantics.
    (batch-update-autoloads): Adjust caller.

    * lisp/emacs-lisp/package.el (package-generate-autoloads): Adjust
    caller.
----------------------------------------------------------------------

According to commit message update-file-autoloads function seems to
change incompatibly.

Then is there any way to make above lookup-autoload function work fine
with both before and after this commit?

Best Regards.

---
Yasuhiro KIMURA



             reply	other threads:[~2020-10-04 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04 14:18 Yasuhiro KIMURA [this message]
2020-10-04 14:32 ` Incompatible change of update-file-autoloads function Lars Ingebrigtsen
2020-10-04 15:07   ` Yasuhiro KIMURA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201004.231811.1933338792984225812.yasu@utahime.org \
    --to=yasu@utahime.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).