From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Sat, 3 Oct 2020 04:13:45 +0200 Message-ID: <20201003021345.izg3sfq5xeioyx2g@Ergus> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <9E48A84B-C05F-4C63-B775-70357788DD17@139.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9405"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: jixiuf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 03 04:14:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOX4M-0002Gu-Pb for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Oct 2020 04:14:42 +0200 Original-Received: from localhost ([::1]:59128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOX4L-00064X-Sh for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Oct 2020 22:14:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOX3n-0005fH-SQ for emacs-devel@gnu.org; Fri, 02 Oct 2020 22:14:07 -0400 Original-Received: from sonic306-3.consmr.mail.bf2.yahoo.com ([74.6.132.42]:36511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOX3k-0007IF-1b for emacs-devel@gnu.org; Fri, 02 Oct 2020 22:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1601691240; bh=RsWcyq7pvEG7MVQiogxGekbZ4ftcWewUjUvCwZIoekU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=cYA3QKrqXcZRCgrfY18IMawPJbJQClvULTHJ/QtBdOB8nmT3b1mStkRGSa6h/xHRlBCW7MyazdYeUiGwQFRWbRY4fCRJrTzDV0ycfl6R7/ubWvhFDRH+km1QEVfjcpg7ruiJbMXKFgevDaTH9zeKFYN8rBJ7kLtATr8X7lGUqAnCUsHZzkNlWxKiTVpwmHAUio/McNsewLd6Ne1eFiJbgY6K/+l3o28TqHXp7bqkMJqRIFsoagQT83pHTtl3bb9mq+6h2gJxokGaXaS0/Pdu0Gw8bqLKag6mT8lt/oGlPIAyCvmmkgbqYPh/9+p1BGBWqbxkhT/3/uWnPxsnWZtJEA== X-YMail-OSG: BCeZijEVM1kZLAIDYG2au80s5gXgpcE4hff0XCAHYHAR3QCeWxu0Rtb2MbhtywE mHWdnAaPMmRqSbOBokTlFrMRbm9FibFwDAXGJOY5ObzuigO186aDHztzPtRsvdR7d6DqYtlpY4sy Yte45bZBqMQo0D7ru424lROv3OD0ku54L9qoVLIAy24BjDLjDf6lCVdzab1cV0R6daCedyD.5nPM GxCuRTCwm.5L35D9Yec8AfibfN6CG26Dv6T3kr_DpFIp8Yoz9j_mnMKZAG_wFtdSmG74E4MVCYVS m.yo09GEjas2w0GhThJDYyNHOha_OyPYVWd.qhE6bdGpdqHJuspMjfBAy0RN2GjE71VwrPQFt3n9 jxd2cc7wEsZoaVPy4QMvhgugsxz4rumQpXCVSYWmozlIJp9aexR.3_6158S2waw2M_JLvzWiD3GT 9CY_BvOqmtqQHkXmoDhi71cuE2WCi.5JxhrYi0ALp1eg2MM7cxA6_xAW8b5wqKOEWOXQRSqs23cT T_tkzgVXa45p0VWUIq.dB6BiGRBYbpHnwAzT6L3mjrCKo4wBmiItmdYtzm.wolclPEaNy.subuhz 7aU.2NZioZ3sHmahkewQxF9cYRxw7T_TNoORPvs1sv4h9l3yWePcn13mV3TBQtI2Y6uTw88ld0CX yZLhGmunGlgNS_v0sU_q.BaVN49qCLcCq0SgqRM6lGVq7Fgxyglmw6fKuuOUOhlmAJdp8xgkPhE2 IVNn2D1hwq0XPZZOAWqOnlD.zb8rVBIpqpMNcPyCH2SZHEWb2BYVCKlNFQHFEFVIalZouvckFl9y lF9oJ2tSQrbBNjfFDlIm7B0CNPQboZyjvw_DmTd4Ba Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.bf2.yahoo.com with HTTP; Sat, 3 Oct 2020 02:14:00 +0000 Original-Received: by smtp408.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d6533181c07a45c611175fe2ee8ac777; Sat, 03 Oct 2020 02:13:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <9E48A84B-C05F-4C63-B775-70357788DD17@139.com> X-Mailer: WebService/1.1.16718 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.132.42; envelope-from=spacibba@aol.com; helo=sonic306-3.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 22:14:00 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256982 Archived-At: On Fri, Oct 02, 2020 at 12:45:41PM +0800, jixiuf wrote: > > >I have tried your branch and it worked perfectly. > >1. And Is there any plan to implements a completion style like helm or orderless(https://github.com/oantolin/orderless ). > Divides the pattern into space-separated components, and matches candidates that match all of the components in any order. > Not that I am aware of. In principle we already have some completions styles you could try... C-h v: completion-styles-alist AFAIR flex was added recently and it is similar to what you mention (just a bit different requiring the order). It is pretty straightforward to create and customize new completions and differently to icomplete-vertical; orderless does not need hacks (like advices, minibuffer resize or extra hooks) to do it's work fine. So I don't see a need to add more completions to vanilla (I am not opposed to that either; specially if the code is simple). If you want more completion styles you could make a feature request and/or contact oantolin to add part of his code to vanilla OR at least add ordeless to elpa to make the package more "official". >2. And Is there any plan to implements async-completing-read for icomplete , > one of my use cases involve an external command to generate the list of candidates, >and that command may take some time to run( like conusel-rg). > Not from me ATM. I just implemented this in the core to avoid the need of some hacks in icomplete-vertical. But I don't want to add excessive complexity to icomplete. To do that I support adding ivy+counsel to vanilla as mentioned in another thread some weeks ago. > >Hope those feature can be implemented in emacs core. > > >> >> BTW: If someone could give a look to the completions-highlight feature >> branch too and make recommendations, report issues? >> >> Best, >> Ergus >> >