From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Thu, 1 Oct 2020 18:48:04 +0200 Message-ID: <20201001164804.mqqyxtet4ttweuyv@Ergus> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33728"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , joaotavora@gmail.com, casouri@gmail.com, emacs-devel@gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 01 18:53:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO1pN-0008eF-Sc for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Oct 2020 18:53:09 +0200 Original-Received: from localhost ([::1]:52482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO1pM-000162-Se for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Oct 2020 12:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO1ks-0005cz-Bj for emacs-devel@gnu.org; Thu, 01 Oct 2020 12:48:32 -0400 Original-Received: from sonic301-3.consmr.mail.bf2.yahoo.com ([74.6.129.42]:37463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO1ko-0006sd-9l for emacs-devel@gnu.org; Thu, 01 Oct 2020 12:48:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1601570900; bh=4xGHEzdllqJOUMfy1HSNGpkihLJWTTN9LqB9+Qp1mw4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=PVfzx56gNnzSqY7RBsYpSDNBDq80dJhOUXDGuH3iRkoDdk8CTFyIh1Ubc/ftmAb76wkPZOQElNXxqPL56ehwtI4UlhyjhAffOx2En36+bEME/vgX4FX4/x/W0yuCTat61JQaRoWkgB7+giAaysYJSQ2QPIACjDVZbni+P1kceJfSkJYD3/YH1Tj7+u3EpCmxxXccMQO8p5iEPs1b0reKLpA9HSRG9LB4qB0W3lS64QvnwaE1+eNZ4vZImSYA/c70draAbVu99NYX8MKnfVLI7C2FzHdi9N91rbdrED7+JczAnhY1jPw/4HgwCzxUV4kzuD6P0nO0Y4P7qpjTqzLKFA== X-YMail-OSG: K3.ABigVM1mV0YQlzy8SFGQPWIMhZ_GqEkwtXlfLmtBAOrpKb8o70m0FY6jjjD0 WVfcL6bdgfXSi2CRvqCJlCDAYAtYMDyOwfyKMl.mdzhPWyrPoo91d5nVKOvlMU9kqnNpR5GZPV6y xAYxMaQRWtgy_emrE9Y_zOCLWpiskHhbLOn3BnSXwXvFPbN45NIDsA520Vss0mI5tL_x9ZNHb.NU WfHU4EdfMbRLQoaTfcKoHwDZt210vBOcutmqCov3y2J3MddIeOKWoXcRzexs5p2I3x6wdi3QAFCP iYmxtO0YpJucD8aEc1ul7eVioCPNjsiVBS1TH6AU8h1_7FTTPQ.y0q20IkV775edr61vrpaShQZK Yw4BctrohMCETHtxZKJSVpc0nd_4PLog05l8Eo6EbXo1msmrePG4IsyBxXl9qh5X.8TQhb32Wlfw seZTb2f0Juay1y3r67DQA0gUSnISqgabwgh8kzvhlJQSNRGwcXm.7c7Gc7rwhiu0eWl1E2MQWfXi o1Bxwsc9LXrs.t7l.SxBJbhpfVyM8DwxNxTvYa0COhJ6rsA9FTsQ6aHec43dFy7sxd5bYhLpWBmv N6HFt8BXvMeLi4PemcZQ2k6Ylctp9h5NJ8jOgMMZOLpqkdzkqnwp03qM9dnWvBHZ5jEqaSjyg3uD mN61s70YNaSccXjDcsAzW5lX4GPzOGyLpNl1mkrYvK46Z015UcR63gM4rUL9XQ2kxLg4tG6YzN5L IwJnAXXF.QFGTtlACf13X4DrRB6yoMjaGHEsiophmqSph9AlrnrnG2l_kzq4tv4h1HNs4C9kW6IZ G108FMyv95K83fMVQwis2EORimrqOUDedBVq3qoOf7 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Thu, 1 Oct 2020 16:48:20 +0000 Original-Received: by smtp413.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 4943e3f8330219a7b4d1dfe13e141a62; Thu, 01 Oct 2020 16:48:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <838sd4z6lz.fsf@gnu.org> X-Mailer: WebService/1.1.16718 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.129.42; envelope-from=spacibba@aol.com; helo=sonic301-3.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 12:48:20 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256888 Archived-At: Hi: I made some corrections to simplify the icomplete-vertical feature branch and pushed (forced) some days ago. (sorry for that, I should have used a scratch branch instead) Now the icomplete-format variable is removed and the user only needs to add at least one '\n' to the separator. I also use window-text-pixel-size to correct the issue with long lines but still perform the height calculations in pixels to properly show the ellipsis as Eli recommended. I keep the funcall approach because IMO it is cleaner, and reduces unneeded and redundant things. (And because it is compatible with something else I am working in) If some of the previous testers could give it a second try. When it is fine I will add some documentation and merge in master. BTW: If someone could give a look to the completions-highlight feature branch too and make recommendations, report issues? Best, Ergus