From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Sun, 20 Sep 2020 15:04:20 +0200 Message-ID: <20200920130420.ek2ohcuh3vqyminr@Ergus> References: <20200919154904.rrabgd37v57qrton@Ergus> <834knt3dqc.fsf@gnu.org> <20200919170645.j2eq22ggqm6a4xmm@Ergus> <83363d3con.fsf@gnu.org> <3523238A-8EEB-428A-A57F-B06294124986@aol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39445"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Eli Zaretskii , casouri@gmail.com, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 20 15:06:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJz2V-000A8q-S5 for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Sep 2020 15:05:59 +0200 Original-Received: from localhost ([::1]:54932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJz2U-0004sr-Tl for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Sep 2020 09:05:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJz1A-0004Sf-UI for emacs-devel@gnu.org; Sun, 20 Sep 2020 09:04:36 -0400 Original-Received: from sonic311-13.consmr.mail.bf2.yahoo.com ([74.6.131.123]:38545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJz16-0000m7-AD for emacs-devel@gnu.org; Sun, 20 Sep 2020 09:04:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1600607069; bh=lpaIgqinUyIGEFt6jvPdk/+2BMaGGu8ZdHCAKnT5koY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=hGImgEd/1nDky0ROansLJ7URsd+NhIk602rnWD+YD/qLO/cHC7tm86jowykLsYI+KLIHwnJCibW0ZqJoDoWx9cinMHk0Q5p4CNPVggLCV7+QYbTP9TZl+w5yg0RYeUhNs1LBKIEkd8oEmHcjZwibuDwvPcztxA+mPUlBTw+DJjz5Ukvy/QXNy/uTP5yVLtbXB4rm4r6VAv8EEmcRQFCeUOe20f1+qwrPSDs0x1FyDCwW0O0xL6V9MZFEJDjJNA1TRcPjdfk54R/u4x8VKUODdVn7Yvj99eH8s6arXhIUUz2lr86bszbmG7n5LB1peufSLS4g2v7yM2n42in34JcguA== X-YMail-OSG: mAkBqqAVM1npyuZPpsVuRxH9xCmH6IuJSqWwyAtoffNdxoPp2kewoecRxLTFmrU Xtu4MmBtT8FphKuzKIHc4pOH4KMYK9YYIl_qgs8hQqrLoSmIsyO9WrZTg4UxRdtFBS6QjXcEUIiC qZILm2eCrg7NXstnGg1ur96fQnjAnbJDAKPcMD9yuurM4fyTGZDCntP24p.TQk8TGUo4J5Te.QfX Qm4EP8spPgvXokZcpo6_VgRXmixVa3P8OoSF_6EXNdpmSVWkcWN.iCbi9g32EzNiH7xLz1NSBTu2 y5qnQMxitbxvo4kqY090SCTz61ox6cmRWqfi_vLgIUAA4ZEaYIxfYzVNyB5.7xRiDeOknGExTWXE ufqdZrWJK9djmkHCgTJ3YCMJSTT_dqkaa.ut4BwZM0FN8VwTzjLMrZP9UgeLCTvVirMC80CA6ray onr.20F1lomXOmb6GJvzotpQKtznK1eP7.SLCw9DataNj4vhY4eq6c591JXRy3reDV5xP_BTYeRu QT2H9H_fUYviR.UAv.Uchl6Yh6o35mZrBMeS_VyZjPrwgJKPIScxyZr_A3iSJFUjiraNnqPmWVBW gfGY8RYq6zG7iZ.YUq2oPxoiXh5rKuTnT9wPaQB7dnGAm_hrrxWNBHuDcoABcebmigMujE2SxjhZ zQh8JRWrr_.lnfFqf1ShDleYtXKviOm2ic4iJ_vR8rYrxD6Zk1bHbjyFhGf8WcHPvl8syzpL4Nbf aisCLVC51HjttFrdX3xcc_D.jPvN1mztADEcPrtumfasmlU_b09M.i7a0dW.KHQyO4Hdr8X5pRNa ylCKFY1gCBCQqCcijiMISamqR90oMncDqxMRqm_wuA Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Sun, 20 Sep 2020 13:04:29 +0000 Original-Received: by smtp417.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 6ebd92dba2f61702063a37aad028b537; Sun, 20 Sep 2020 13:04:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.131.123; envelope-from=spacibba@aol.com; helo=sonic311-13.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/20 09:04:29 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256245 Archived-At: On Sun, Sep 20, 2020 at 10:47:44AM +0000, Gregory Heytings via Emacs development discussions. wrote: > >Hi Ergus, > >I don't know if you're following the discussion on bug#43519, but >there is in fact an almost trivial way to implement >icomplete-vertical: > >(setq icomplete-separator "\n") >(setq icomplete-prospects-height 10) >(add-hook 'icomplete-minibuffer-setup-hook (function (lambda () (setq resize-mini-windows nil) (enlarge-window icomplete-prospects-height)))) > >It needs some tweaking, but it works. > That's indeed similar to what the external package does with some extras (remove the {} and add the extra line after the {, truncate the long ones, resize automatically when less candidates based on an option). https://github.com/oantolin/icomplete-vertical Then the only thin we need is (setq resize-mini-windows nil) and doesn't need to be in the icomplete-minibuffer-setup-hook. The problem was that I tried to avoid calling enlarge-window and I thought there was a good reason to do that... my bad.