From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Sat, 19 Sep 2020 14:57:27 +0200 Message-ID: <20200919125727.lzvv7pdntbr5t5sh@Ergus> References: <20200919015957.prffuac2jke3hp6a@Ergus> <20200919061531.oyjlbdvkbeif5fsg@Ergus> <20200919111927.v6ixssp3w2t6ow3j@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , casouri@gmail.com, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 19 14:58:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJcRe-0002Jd-UN for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 14:58:27 +0200 Original-Received: from localhost ([::1]:57204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJcRe-0003lh-0j for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 08:58:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJcQy-0003L9-8p for emacs-devel@gnu.org; Sat, 19 Sep 2020 08:57:45 -0400 Original-Received: from sonic316-11.consmr.mail.bf2.yahoo.com ([74.6.130.121]:46524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJcQt-0000wx-Td for emacs-devel@gnu.org; Sat, 19 Sep 2020 08:57:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1600520257; bh=Pj5XZIUZ88BsnG6e+wDV/cOyPTWKOriVhK//jBDwX0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=UnfCqqLT2slPZKuSDLwdfCoLFTnLHF8aj9JmVA3aQTqCVw0vpxZKM9cn7f7X2ysmso2+pGB8+A9foXvpfzVANW74J/WE2FjezyU6uCFbJTCiG/hbvI1IBqyNbTDMdYARHkgUD/EZrYS8R3LA4ShkOOKNxmWEkbs6d3OQbooWF2cMrVPfhD0HTgCwHq5oigBQYjKnB+K9Is9q0JzeE4e+tPHZ+1YoabprdDNrz9NUO7YEUe2YuRCG6ZEVWS5/Cj84c8fk0hWx6+cAJI4nfljIaRTjz8nQ2PSt8B7ZAcsiaWtsRJHlr7mLNrbulzpscfFdWUXRVveZhvZyGSL0xnFivg== X-YMail-OSG: j2QnrokVM1kZeqoqMLdAR495SIMyr3p1TdjAP3cX1uuietE.sZ.zQSbt2CjJqde QVLqlG5dNfCdKeIU.ZzKcM_YCvKCO6SNjwB03uLiKJUbeJYwKqUaC0gP_7RNfApcHz46JoSiXbDS QD5yW_5BZeOlknniP9bQEI0ecdA.pMfw31zwhwMcsPtULoXYDngN9pBnoGPhyoM.xR9wxQ8BtlEz N7zP_6PkpsNF4N4UslxWTkGr6m0BvZSo._wj_txeCMaoKd1WXGCk7zNyEFvEukeMbCH1zp69KgLm ftZv_20_8Xno_8uSFMN6qmOC5kSWjPvX6FRHNqRzfRZ1mfYCZgC1kIRAh9Lpr5poKfo9.fbJCqs9 knYjzyyAyftNdQDYfhS50J9dRzGbJuZMJbXlmnoxvUjQJhGhVhCnzASrXczCT0maqVPZX4OpepO3 NuDzq7J3pOSnCaRAsrLrDFylMVMyJAqBGAOR3EP82lTYBPdFZ3q4tvwyEFtX3lyl5ArBR1nUc6BR o95yoHlwIW6IX_zxmorZDR9BwK0pJYiu643aqtMesaHHfZIYRkPBtDbpn7Y3ejoqh6wcWAuOBql8 ksmZr2Hz01IbcQ3dthwPV4_dR1YMhBQVt0htgceeFtmqN5mSDjFowg3ixEQ1MJ_yKnndJpJQXsKw BlQrWpMJJbx7xiyNJhMZQ3yL6KaLzVyYSCeE3gTi7tU0A2wPS6LUIR5jWa9qN0nv3ieG9c6153zk 10NGj4JThmacuhL62nWVcsG.ZkQZu8b8_FtnZNoDvMzsbS16aTKlT42avt07YWpzjtmLi2jmB6bk ORHl8QZZrHofAcqkwFDwAEX9ZUhUzCNjZ5SdF3CqPQ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Sat, 19 Sep 2020 12:57:37 +0000 Original-Received: by smtp412.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID c9040ca348d67f85f65228092d801ba0; Sat, 19 Sep 2020 12:57:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.130.121; envelope-from=spacibba@aol.com; helo=sonic316-11.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 08:24:07 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256163 Archived-At: On Sat, Sep 19, 2020 at 11:56:19AM +0000, Gregory Heytings via Emacs development discussions. wrote: > >>>- when the current line after the prompt is too long the prompt >>>disappears >> >>Yes, set visual-line-mode -1 for this. Is the only solution so far >>and what I will do in the setup probably. >> > >No, it is not the only solution, my code handles that case without >using visual-line-mode. > If there is visual-lines -1 + truncate-lines that takes care of this in a consistent way using the internal infrastructure. Why should I use something else? >By the way, I just checked it (with your >code) and apparently enabling visual-line-mode does not solve that >problem. Did you added truncate-lines locally? As I said before, the patch was preliminar and needs some fixes I do slowly as I am not a lisper. I just diff my local changes to send them to you >> >>Did you applied the patch cleanly? >> > >As far as I can see yes. I already tried your code twice, did you try >mine? I attach the improved version which handles the minibuffer-only >case. > The changes indeed do only one thing at the time and it separated the vertical from the horizontal completely. Which is IMO simpler that just add if and else conditions here and there or hard code the mapcar ignoring the user separator. >Anyway, IMO you not are using the best approach on this project, you >are trying to do too many things at once. You can do it if you want. No problem with that. Actually I tried to convince the creator of the external package to do it and asked in the mailing list some months ago if anyone wanted to do it and nobody replied. >Completion mechanisms are a >very complex thing, and I believe the best way is to do small >incremental improvements with minimal changes, and to test them >thoroughly before implementing the next improvement. This is not a big change at all. This is just some cosmetics to an output. I don't interact with he completion system and the code is not complex at all. Actually it is just 2 functions. The rest is the same just in a different place. But actually your code and mine do exactly the same just using different conditions. If you see my first commits it was almost as simple as yours but then reports started coming and I needed to fix them unless some of them (like the disappearing prompt) were old bug already reported. IMO this is an incremental change, but I don't try to compete for a smaller patch but simpler and free of known issues. Like the ones you are reporting. Best Ergus