From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Sat, 19 Sep 2020 13:19:27 +0200 Message-ID: <20200919111927.v6ixssp3w2t6ow3j@Ergus> References: <20200919015957.prffuac2jke3hp6a@Ergus> <20200919061531.oyjlbdvkbeif5fsg@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , casouri@gmail.com, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 19 13:20:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJav5-0001JG-Nw for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 13:20:43 +0200 Original-Received: from localhost ([::1]:55540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJav4-0001Ve-PR for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 07:20:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJau4-00013y-2V for emacs-devel@gnu.org; Sat, 19 Sep 2020 07:19:40 -0400 Original-Received: from sonic316-13.consmr.mail.bf2.yahoo.com ([74.6.130.123]:37487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJau1-0007U9-OJ for emacs-devel@gnu.org; Sat, 19 Sep 2020 07:19:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1600514376; bh=pHzs4PillgBu9om0SoziCXggXMpo+lVIJOL5xVt3WHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=nOF+0l4EjqUqgs+jhWwWoeBkGTfHD4SxoPbOSysyLQhoxezArVOSSeAUj1eiQof9ZwwdBhyoiYoTI5awcLEmcBoSBbCp4TXKHwdTpufbUiM+XvPkx0zPhUvJldTM3CxhPW7i4msx4rMsQ3Wf9i0H2VLT0X7117RbEDsyh7vMUIH9Ae7rwzLWI2KlaVMMr1pBnQw0QLEmnqTgi+QKPJuoTqKADLhkJF+rOSK/stWnEadmmloZqe6l4E6tAsY8RFRwKmMwdiyvMpQyZEalWF/hJBaNjqpcG2EZt65slVTlTeTWeSLqKcG08uFASTNmqDd++aM8s/5EWyF9OVHHSTuGjw== X-YMail-OSG: uR_Gc1IVM1lYjdo1W2njRuDtO59fWVq481mnu3npUttLNGj6D0T_VQF2lADESWb PTez4oMC57r0rEvc7syT9BHoMrCKxr20PIVU8GtzAXjtSqRbvM3yShOkS_imPkcTIRiijWJ9io2X PPqWB8UTrzX2R9mXyovL9rYFbYpiXik0hxR37XvsfbL5VzjriPfVt1NwtwVrezc83bhrGkU4t_lt 7VGouB574Kw0tOhG6mCvg_4s6KvHO_BUpafUCOPMyhxdrcQInM6MvCaqew1uTwFqzgql1EKMXZDW 8qHPTnH7KyWJtES2rxD73iK4UkCklHW6xhHBScdbk4oq4o6MG07z5N9Lt3mlaEQ2Tf9_P8mVpSog yZKVfzJVUD5CssFAKmpTd.Jrndm.9zTh0EExPqp8jr8WM3gljW9I5swLTU6_euU920IVC_rNsbhh cnoc1BILNwxKuz9KW6J1eksD1g84wYlger8ZWERtDRzbYYyVE4nl7Hu7DmKuSo97QeUU2n_PGWmK gCaCdzPtmlm1zbo6OVekYRaOp7gI5zVLDoJORMXqV46Ib7nuMYZFD1yJpZQtR1jf6zt7y041oBVi 04GllJHn0xLmUpgoNSYv.XVi0Sn0HnzlchX210xgcRV4kM7BRdbmuOGN4AnS5l6MMlDJsitKeBhc IIOT.sy8sOl3qmagpsS2p6ccJ.7V6COqIs0EtuuUAN4GHhxU3him7ZuK1Qti7atv728edIBsUyGC krud2fWU1a3_YS3ouxXluSrlnycHTCSbm9dme.lTCqrgsfLe7SFscqmb.UehN3o1TSyxPnMszwXq DYbqrNlFSu8rxsjhLn80jhAXA63kSnCH1Frvqb5Ysk Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Sat, 19 Sep 2020 11:19:36 +0000 Original-Received: by smtp411.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 21aa8174ed33fb9c53475fca89c0e6e0; Sat, 19 Sep 2020 11:19:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.130.123; envelope-from=spacibba@aol.com; helo=sonic316-13.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 07:19:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256157 Archived-At: On Sat, Sep 19, 2020 at 10:30:13AM +0000, Gregory Heytings via Emacs development discussions. wrote: > >>>Look at the attached patch as it is partially simplified in my >>>local branch. >> >>Thanks, I'll have a look. >> > >It seems to me that it does not work as well as my code, alas. A few >points: > >- with C-x C-f the default completion, between angle brackets in the >original icomplete code, is not shown anymore, unless there is a >single candidate (for example in a directory with "foo", "bar1", >"bar2", "f" will give "f[oo]" but "b" will give "b[]"); in other >words, the "[]" after the point usually serves no purpose > >- likewise, with M-x there is a "()" after the point that usually >serves no purpose > As you can see in my patch I didn't change that part. >- if I type "M-x icomplete-m", I see the following: > >M-x icomplete-m(ode) >| > >where "|" represents the cursor (on the next line!) > I can't reproduce this, normally this happened when there was a missing space before the newline in icomplete--list-indicators-format, but it is in the patch.... >- when the current line after the prompt is too long the prompt disappears > Yes, set visual-line-mode -1 for this. Is the only solution so far and what I will do in the setup probably. >- when completing a unique completion with TAB the point is moved to >the next line > Same problem of icomplete--list-indicators-format. Did you applied the patch cleanly? >Gregory >