From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Fri, 18 Sep 2020 13:58:18 +0200 Message-ID: <20200918115818.dt6sfsfjcmgzbprz@Ergus> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <8BBE93B6-922E-44EF-B7A4-6A82C4F1DE3A@139.com> <20200914150258.4ze4ffv3afh4jd4f@Ergus> <7F366599-595E-4BF9-9C95-8E701045BAE8@139.com> <20200918005354.muskx2b7tssyqzzk@Ergus> <93DD4B50-61A2-4786-AD89-1322E51A6A90@139.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21812"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: jixiuf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 13:59:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJF2c-0005ZL-Ro for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 13:59:02 +0200 Original-Received: from localhost ([::1]:48030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJF2b-0003iy-Tc for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 07:59:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJF27-0003Jw-Ea for emacs-devel@gnu.org; Fri, 18 Sep 2020 07:58:31 -0400 Original-Received: from sonic304-9.consmr.mail.bf2.yahoo.com ([74.6.128.32]:35610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJF24-0007Qs-Dm for emacs-devel@gnu.org; Fri, 18 Sep 2020 07:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1600430306; bh=iwt3clH9UYb2tXQjukn/kjJAfOK6a9S4hBcrjBW+4G0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=b4af/z0mIC9hfHK6fUoB7O985/+Ah5Os8gUnjcQhPW+08pzY5RdKkKKM4HI8n40NHI5ptUZ8cJ1V8vQNNbAbwMETxg1U91hJ5gDy6W1crqv8/1X5qjxP/TvMixtgUe8rdLJXP1T7jkGi0i0vjL3XQavU5sQRjc743yS+ASbBVCo9jERdU2b1uZLA4IpZWkuxk0ZSlx8GhelAvjHVHTV66kOvsmW+L2K+Bp0vjTY4Pa3QLY/ZhZtGczOsyVS7VEBMEzjKS9HNoYTqrVIDNVr/1+tCmAOl0oi1SoSslmLrjlRAPQWts+fDBZJYRfk14EprIxQkq+BQx9kmVMFIEM4hUw== X-YMail-OSG: 8wOO2xsVM1koyN7f.QmY_xKggvpLOO2fQYszyZnFSb2gHK0gtkYMmCJXFGvhLs6 NqU3TOlm0MnzBvp2xugzmWgP9EdmUL7P1aa00Z8i2AqD1kYNtuCAwmbQCM3FgrtW.OZ2EV2jY.mo tC6UD67LiiQf99dMX5uH_bxf3BZkZZPUgiT2td8EpeV69iubG1ZfQf5A8IbsYNbGOFJa5PAvz_E6 scu6bDf8pCOXMulqbnAqctBBmceMuGPg1UFpuNRvZidN1_1chbFSchp2WnY7mKjGtVIqAXp88jRn xeWxZswb8tq4cyf9MDqY1K6y.jhp06ivVygPn4leLsSFvoNWOuVyVhmYmwj3wq856rfmxgPkOclC 4YjyWzhtAitF.GkGmcYqPy8Sqc3PUiDtA2IsN9ZAs6S9IUM10cKe70W9LpC4QUWnIuE2NaSicQz2 0IKp0BlT7359SPWzTpE.dFLpl2pH5RS1tzW.sqq1.Do__ZzdHWrBoIK1Wjo2es3.m7c5BgSPlAEe 5tUEuuKpU9iPKPIQrJVd4qDSH65PupQXIBUEy16F8lAzFSn.54pB7Bi2MNd6TF_UlRlZ7Lchmr4m JDJdhL7F37bb8N88i3zveToFnIcyxPQ89G_qP9jrxI4V12K3wtGnhFon0M5cZO5qkiY_g2lHxbbQ MQuRJSCvdSIcyFhGFe5AM31RWIIK7zCelri3X7qcI8tjb54tUizw5fLMGLMwQsk5fALhmOBrNHgF eXZWHbf3IRtK4V7fkDicXMrFtdTbkXoCVRfMsi4pytlS9UpIhUX6TwRpyDruZC9xpBWe6RjKc21K WBnHpphFdRwPloy9kcQV_.URLSDzRvUV.9DT94aScF Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Fri, 18 Sep 2020 11:58:26 +0000 Original-Received: by smtp403.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d5c9915e980d3f91684102528529cebb; Fri, 18 Sep 2020 11:58:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <93DD4B50-61A2-4786-AD89-1322E51A6A90@139.com> X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.128.32; envelope-from=spacibba@aol.com; helo=sonic304-9.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 07:58:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256077 Archived-At: On Fri, Sep 18, 2020 at 11:08:48AM +0800, jixiuf wrote: > > >Thanks, it is fixed . > >But the bug of "disappearing prompt and entered text problem" came back again, when I (setq max-mini-window-height 10) > Indeed this is nasty because the issue is not exactly in icomplete. I will explain a bit: max-mini-window-height sets the height of mini-windows BUT when it is set as an int it sets the minibuffer height using the number of lines but using the main frame's font height. In your case the problem is that the face in minibuffer is different than in the rest of the frame and your font is bigger. So for the moment there is only a solutions fromicomp lete I can do without forcing a resize (something I am trying to avoid): Use your font to increment the height and stop when fixed (which will not respect the 10 lines as you want because your font is bigger) Alternatively I can try to fix the resize mechanism properly by fixing where the minibuffer resize happens and how it gets the font... but this will require more time (I think it is the right thing to do.) >``` > >(setq icomplete-show-matches-on-no-input t) >(icomplete-mode 1) >(setq icomplete-format 'vertical) > >(defface vmacs-minibuffer-font > `((t :inherit default :height 1.3)) > "The default font for minibuffer buffer. >Monospaced font whihc is fixed idth and height is recommended." > :group 'minibuffer) > >(defun vmacs-minibuffer-hook() > (set (make-local-variable 'buffer-face-mode-face) 'vmacs-minibuffer-font) > (buffer-face-mode t)) > >(add-hook 'minibuffer-setup-hook #'vmacs-minibuffer-hook) > >(setq max-mini-window-height 10) ;; add this line >```