From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Changes for emacs 28 Date: Fri, 11 Sep 2020 12:15:09 +0200 Message-ID: <20200911101509.v2b7dfiq6kuqlysp@Ergus> References: <20200910231420.kvqg6ohvxetpup5c.ref@Ergus> <20200910231420.kvqg6ohvxetpup5c@Ergus> <83zh5whl5p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6201"; mail-complaints-to="usenet@ciao.gmane.io" Cc: caiohcs0@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 11 12:16:10 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGg6D-0001UO-Ih for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 12:16:09 +0200 Original-Received: from localhost ([::1]:53922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGg6C-0006yy-L0 for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 06:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGg5Q-0006Rr-WF for emacs-devel@gnu.org; Fri, 11 Sep 2020 06:15:21 -0400 Original-Received: from sonic310-13.consmr.mail.bf2.yahoo.com ([74.6.135.123]:33532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGg5O-0006QR-Lq for emacs-devel@gnu.org; Fri, 11 Sep 2020 06:15:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1599819316; bh=fBSf2XBQIUJVW3ggQ2vQziYQ+jEbN4omj/DuCkfMHas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=FFBg17pGaH1FQoG6HS6W4okY3GH70l5374VHODxc2R6CX2Qt1vmssDQ2WM7/fIcHm5Bl7G3xf9o2PYSViDDZJkVrVbzDcBzKbSqfC75Swf24cIWJ6a4hXx7BDtqT+ByPtVd42DC9t+Xt0adjbM6naqQblQLcd0iPYmSiEeSofumaIcHFb53v2C6g2GT0DGk+XOXt0BNYGFipZEAaOimU4u9GIinqn+an3qmqlCUo33NjO7YIABQYTmweeVJ6Gr0mleWjUu8Yxeoo/4JIo2D/pp6TfRIpbYmD8Oqe/yFDA0J6qKt3xvaUwxfyyQ5jybcFa33+7KBiK6hJ74Mz7JfinA== X-YMail-OSG: 92UZal0VM1m7EdMkqIioWcrxqeiPhS26jZhSLcbbQ2WUWv9f7X7nBdQWj2EWoXW etSUrrlwlRq89I_Fy73NJRKqe2x50ry4zUMGoMtG5tJjDusI_tdxoQ8dKtvQ7MgrlUkyx5XCmdXA x2fd4u5w5gvyUc8tfFnNHEWVB_TF3tuSrwud.C4Ax3oUaHHE28uKOBqLn3BgbVYKE2xJD.QTPVia JAQ46pY4Litf.4CojaBHqRYHm6KqDLEqc9JsbS5.r.tk.cIlAcCPQOwnolh7Kx4pMteLWOSmJNeS 8.gk1WANy96zkzIHzznU_lGMAc6Xj9FqtGq1cQquwxCJnPV.etwY_0Dt6cgyKmdLaeFek7MUccE1 u_.f1vbvIKRe59olxl.4G.dsP035sKi6g2krlCNg7prP.nFdP_Rnrbt5RuqiE4UXXY_zaUwQ6qJ1 KOuUv6rBrAZ6Nwzlbw2HvW4fLeA4wBoYOVdO2W8tLnbCQmL1HbTKN3Y0eaGzF2FQaaOqTVE0B1A6 byHObj1fysn7A1juccw9Ze4tectEZJLmHGj8c7rD_lj.hNegpIzy9RcBGu6FJjI0yQX7Den0s8iv zaWzZzkgoxoZ79gLdNKjTBs1VYnMDlGIP0p_zc.iDuIQ1ZqPZnlCwvnB8F9dRcRWkzi42jqCiIGP HbBSJm7Dr6pqB_MShKXAJyViN9CedaFHwLZOH9wzyHYtuvcXJBtYNyNrYHbETMcFN3AqYgd2_TUT Qn4Lo8ZIpuv3TlXqKfOGA51C.6SBm0ABV10VDIdqR8yU1wZSjeWvzJEJXLGOkL4oS5ZBIhx7CVtx e7Md9w7xdmrA6Ixt7UeJw8sRt0vhnm79ZFgvNhO8Tz Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Fri, 11 Sep 2020 10:15:16 +0000 Original-Received: by smtp410.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 9f15d6f6a879625f184121007de08150; Fri, 11 Sep 2020 10:15:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83zh5whl5p.fsf@gnu.org> X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.135.123; envelope-from=spacibba@aol.com; helo=sonic310-13.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/11 06:15:16 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255123 Archived-At: On Fri, Sep 11, 2020 at 09:39:30AM +0300, Eli Zaretskii wrote: >> Date: Fri, 11 Sep 2020 01:14:20 +0200 >> From: Ergus >> Cc: Ricardo Wurmus , Gregory Heytings , >> emacs-devel@gnu.org >> >> 3) Is it possible/should we: add a redo icon in the toolbar >> conditionally when the mode is enabled? >> >> else >> >> 4) I see a redo added in the menu-bar unconditionally... should we do >> the same in the toolbar unconditionally? > >I indeed think that the Redo icon should be added unconditionally >(enabled only when there's something to redo, like the menu item). Then Caio Henrique can add his patch from a previous mail to master. I tried it but there is a problem enabling disabling the icon. It doesn't enable automatically when I do an undo until I click with the mouse somewhere. Maybe it is a redisplay problem?