* 68033285 * .gitlab-ci.yml (test-all): Run only when needed.
@ 2020-08-30 19:22 Alan Third
2020-08-31 7:03 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Alan Third @ 2020-08-30 19:22 UTC (permalink / raw)
To: Michael Albinus; +Cc: Emacs-Devel
Hello Michael,
I think you may have made a copy/paste mistake with the wildcards in
this commit.
"- src/*.{h,m}" means any file with a .h or .m extension but I guess
you intended src/*.{h,c}. There are a lot more types of files in src/,
though, so I don't know if it should just be src/*?
The w32 files have the same problem.
Since we're now excluding the test-all job from running when NS .m
files are updated, should we add make check to the end of the
test-gnustep job?
--
Alan Third
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 68033285 * .gitlab-ci.yml (test-all): Run only when needed.
2020-08-30 19:22 68033285 * .gitlab-ci.yml (test-all): Run only when needed Alan Third
@ 2020-08-31 7:03 ` Michael Albinus
2020-08-31 8:23 ` Alan Third
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2020-08-31 7:03 UTC (permalink / raw)
To: Alan Third; +Cc: Emacs-Devel
Alan Third <alan@idiocy.org> writes:
> Hello Michael,
Hi Alan,
> I think you may have made a copy/paste mistake with the wildcards in
> this commit.
>
> "- src/*.{h,m}" means any file with a .h or .m extension but I guess
> you intended src/*.{h,c}. There are a lot more types of files in src/,
> though, so I don't know if it should just be src/*?
There aren't so many files except *.c and *.h which matter. But these
other files are changed not very often, so it might be OK.
OTOH, I don't know what happens if a file is matched in both
only/changes due to src/*, and in except/changes due to src/ns*.{h,m}.
> The w32 files have the same problem.
Oops, yes.
If you like you might fix it as proposed.
> Since we're now excluding the test-all job from running when NS .m
> files are updated, should we add make check to the end of the
> test-gnustep job?
Fine with me. Does a gnustep Emacs build runs also in a Debian environment?
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 68033285 * .gitlab-ci.yml (test-all): Run only when needed.
2020-08-31 7:03 ` Michael Albinus
@ 2020-08-31 8:23 ` Alan Third
0 siblings, 0 replies; 3+ messages in thread
From: Alan Third @ 2020-08-31 8:23 UTC (permalink / raw)
To: Michael Albinus; +Cc: Emacs-Devel
On Mon, Aug 31, 2020 at 09:03:38AM +0200, Michael Albinus wrote:
> Alan Third <alan@idiocy.org> writes:
> > I think you may have made a copy/paste mistake with the wildcards in
> > this commit.
> >
> > "- src/*.{h,m}" means any file with a .h or .m extension but I guess
> > you intended src/*.{h,c}. There are a lot more types of files in src/,
> > though, so I don't know if it should just be src/*?
>
> There aren't so many files except *.c and *.h which matter. But these
> other files are changed not very often, so it might be OK.
>
> OTOH, I don't know what happens if a file is matched in both
> only/changes due to src/*, and in except/changes due to src/ns*.{h,m}.
Yes, I'm not sure either. I've gone with {h,c}.
> > Since we're now excluding the test-all job from running when NS .m
> > files are updated, should we add make check to the end of the
> > test-gnustep job?
>
> Fine with me. Does a gnustep Emacs build runs also in a Debian environment?
Yes, although since the test environment is headless it will just be
running in -nw mode, I guess? I've left this out for now. We can see
how the changes to the only and except sections work and decide if we
need to add it later.
--
Alan Third
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-31 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-30 19:22 68033285 * .gitlab-ci.yml (test-all): Run only when needed Alan Third
2020-08-31 7:03 ` Michael Albinus
2020-08-31 8:23 ` Alan Third
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).