From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: vertical fido-mode (new branch) Date: Fri, 28 Aug 2020 12:09:20 +0200 Message-ID: <20200828100920.22wvltzgj6ruygee@Ergus> References: <87y2ouldrr.fsf@mail.linkov.net> <20200819121755.24hgq4gyba2wkt76@Ergus> <87pn7mdqbe.fsf@mail.linkov.net> <20200820103746.6n5op7dtz563k7qm@Ergus> <87pn7llbnb.fsf@mail.linkov.net> <20200821000513.xqdhsdwxm7ov7fkw@Ergus> <87y2m5jlh6.fsf@mail.linkov.net> <20200824190654.d5obxfwyehdgpr4u@Ergus> <87lfi2sg36.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19416"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 28 12:10:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBbKe-0004wQ-RB for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Aug 2020 12:10:04 +0200 Original-Received: from localhost ([::1]:45074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBbKd-0006US-Sr for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Aug 2020 06:10:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBbKB-00063L-68 for emacs-devel@gnu.org; Fri, 28 Aug 2020 06:09:35 -0400 Original-Received: from sonic301-2.consmr.mail.bf2.yahoo.com ([74.6.129.41]:33293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBbK8-0001Pi-8m for emacs-devel@gnu.org; Fri, 28 Aug 2020 06:09:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1598609370; bh=nbEyto8vHK7mI/KbRfVM+9NLMdxuXqH+7c9uxxpubyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=S3Jx6MxX9CxN1uAFbdBRMUPoCij7Croy+jWTUz3+IRtIPVQnhODyNys78qH98aVvtUdkLZMKj6eRfzCVdNRMCvqK5JY6dEas26m9LibTn5FqqbVM65CilRj0XWOKSZivpzS54ojDIjB6k3d6I30jiHKtIXrL+it6SPZN5zn3tuNElr/xtR46Aa7oxVAa+3LUxY33VmhswLZy+3yF+J+CR3S9KD4pSVAN4pAex7ryO1BTymkFhn9q/A1nRO5elbKzquEiagds46BUf+Vt6RQBf/u1BFpZoUagaeX3LZf9SEs4fvh3MgKYvCDtn4mN7IH92uZ3Q9u8mxPpSvoJPqkItA== X-YMail-OSG: .EYV6A0VM1l0HeA6l1BIT86cU6T02v8rAVuzsskwyLHsUEEo6.8phifAm.Dhi6M 39psmLajTp0L1YJUpb8HVRxEbCKG0ZDG0BCc1ZFGbkbxeopyNlIBUKVQc7NpQuKdPr2xIs3O.1NS izZCdcrioL5646dtuGHtsGBUAqidR7Il1D9yKhnc9WwTuLW0iN1_Uxu552Fwt6lQD9DOvRL1cN8V FhCBuOYFLlj7Y6jMxKPB7b_99zJAi.sno4C2vUJCiFmmR7qRqa0lb.Aukvs7gYcUVDd3UxsLmK58 f04v54d6TraZXjdwo04SxMp_.jpA8t.LcLyHg.1CWoKiBWvjulvE8ZMX9ec7HDgEO_lHQnruW31t EB.5UIJgoHDEZ.Q8cthdV9TSG7vK2.7W_L9XB2IOmdGzJpwFNzFmvoBHgqQbNdqDGM9uA0j7.c4s LSB9Qqwj1GlybsV4eJo2INduZO21jT4HrjIIazczo_raVUKDNIQPCGEFBJIrc7.gI_PXOeO7KJbx km26yfIMIDQKKeQdy5QnfHeCKihqgYFALemhlApxPDuumNS_zcnwTC7DzTMly2tQDsHLpgI8zxkl j2172rXFKRhPJchUDITNKZXA.780VTnW20jZtSlusJISldZuiIDJ03S_3jh3lhonWbYym.2Ri09V AR87_NkKU3rpkEOke6ea4YfgujrGFLIPMMQ9d9vot2YZi3tq3g3fPe3lrgUgHBuObYuRjFWsqevJ TYKVRwEKjGu_P64xEn36IGecTSu1yxwNIFJKgiJO0m5gLCs3tIe.AIsTH_SZ__6rBuMggkGVvxXm zT.OOonebqFZYaKgRbJVErXIxUpMzCGF0Yg77A_UqZ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Fri, 28 Aug 2020 10:09:30 +0000 Original-Received: by smtp402.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 77717cfa7d9a3ff6f74e6699cca348c1; Fri, 28 Aug 2020 10:09:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87lfi2sg36.fsf@mail.linkov.net> X-Mailer: WebService/1.1.16455 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.129.41; envelope-from=spacibba@aol.com; helo=sonic301-2.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/28 06:02:57 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254352 Archived-At: Hi Juri: There is a new branch with the modifications either in minibuffer.el and the new file. I followed the recommendations from Stefan and any suggestion (including names) is very welcome. Please try that and check if everything is fine to merge into master. I would like to enable this by default in emacs 28, but going into that discussion will take maybe 10 years. On Tue, Aug 25, 2020 at 09:55:41PM +0300, Juri Linkov wrote: >> Could you please try the attached patch (where the mode is enabled by default). > >Cool, now completions navigation is much easier than with anything else. > >>>Easier can be only one thing: to use arrows and navigation keys to navigate >>>completions from the minibuffer. So the main question is on what condition >>>to activate these keys (instead of allowing them to search in history)? >>> >> I enabled the keys only when the *Completions* buffer is shown and the >> highlight completions is active. And added a hook to remove the bindings >> when minibuffer-hide-completions. > >Good. > >> If this patch is too much code for adding in simple and minibuffer, I >> would try to make a separate file with a mode. WDYT? > >Maybe initially this could be a separate package to allow easier >experimentation with it. Later when it works well, this could be added >to core commands. >