From: "Herbert J. Skuhra" <herbert@gojira.at>
To: emacs-devel@gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Cc: spwhitton@spwhitton.name
Subject: Re: master 6e70b37: When decrypting non-decrypted files, make epa show the raw files
Date: Mon, 24 Aug 2020 11:16:00 +0200 [thread overview]
Message-ID: <20200824091600.GA42401@mail.bsd4all.net> (raw)
In-Reply-To: <20200823213651.GA73398@mail.bsd4all.net>
On Sun, Aug 23, 2020 at 11:36:51PM +0200, Herbert J. Skuhra wrote:
> On Sun, Aug 23, 2020 at 10:54:27PM +0200, Herbert J. Skuhra wrote:
> > On Tue, 04 Aug 2020 21:43:03 +0200, larsi@gnus.org wrote:
> > >
> > > branch: master
> > > commit 6e70b3793b9cb7730ab8a7132aa6e99f1ca13f98
> > > Author: Lars Ingebrigtsen <larsi@gnus.org>
> > > Commit: Lars Ingebrigtsen <larsi@gnus.org>
> > >
> > > When decrypting non-decrypted files, make epa show the raw files
> > >
> > > * lisp/epa-file.el (epa-file-insert-file-contents): When trying to
> > > decrypt a non-decrypted file, just show the bytes from the file
> > > instead (bug#3829).
> >
> > After this commit running 'C-x C-f ~/newfile.gpg' produces an error:
> >
> > epa-file-insert-file-contents: Wrong type argument: char-or-string-p, nil
> >
> > Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
> > epa-file-decode-and-insert(nil "/home/herbert/newfile.gpg" t nil nil nil)
> > epa-file-insert-file-contents("/home/herbert/newfile.gpg" t nil nil nil)
> > apply(epa-file-insert-file-contents ("/home/herbert/newfile.gpg" t nil nil nil))
> > epa-file-handler(insert-file-contents "/home/herbert/newfile.gpg" t nil nil nil)
> > insert-file-contents("~/newfile.gpg" t)
> > find-file-noselect-1(#<buffer newfile.gpg> "~/newfile.gpg" nil nil "~/newfile.gpg" nil)
> > find-file-noselect("~/newfile.gpg" nil nil t)
> > find-file("~/newfile.gpg" t)
> > funcall-interactively(find-file "~/newfile.gpg" t)
> > call-interactively(find-file nil nil)
> > command-execute(find-file)
> >
> > If I run the command 'find-file' again it works.
>
> But I am not asked to select a gpg key ... only symmetric encryption is
> offered!
>
> There is obviously another bug (but unrelated to this commit):
>
> If I revert the above commit and try to create and save an encrypted
> file I get:
>
> Select recipients for encryption.
> If no one is selected, symmetric encryption will be performed.
> - ‘m’ to mark a key on the line
> - ‘u’ to unmark a key on the line
> [Cancel][OK]
>
>
> How do you proceed with symmetric encryption? Just pressing OK without
> selecting a key does not work.
The second bug is obviously caused by:
commit 7479c11b4e73fcb9aa9d42788012b850ee3245c5 (HEAD)
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jul 24 13:36:39 2020 -0700
--
Herbert
next prev parent reply other threads:[~2020-08-24 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200804194302.9117.35185@vcs0.savannah.gnu.org>
[not found] ` <20200804194304.43835209B0@vcs0.savannah.gnu.org>
2020-08-23 20:54 ` master 6e70b37: When decrypting non-decrypted files, make epa show the raw files Herbert J. Skuhra
2020-08-23 21:36 ` Herbert J. Skuhra
2020-08-24 9:16 ` Herbert J. Skuhra [this message]
2020-08-24 18:57 ` Lars Ingebrigtsen
2020-08-24 19:56 ` Lars Ingebrigtsen
2020-08-24 22:39 ` Herbert J. Skuhra
2020-08-24 18:59 ` Lars Ingebrigtsen
2020-08-24 18:51 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824091600.GA42401@mail.bsd4all.net \
--to=herbert@gojira.at \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).