unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Use 65535 as scale factor for color-values on NS
Date: Sat, 6 Jun 2020 20:57:40 +0200 (CEST)	[thread overview]
Message-ID: <20200606185734.GA16539@breton.holly.idiocy.org> (raw)
In-Reply-To: <144C70D7-33AA-4840-89A6-205F1EDF4847@acm.org>

On Sat, Jun 06, 2020 at 11:57:03AM +0200, Mattias Engdegård wrote:
> Alan, it seems that only NS uses 65280 as scale factor for
> 'color-values'; all other back-ends use 65535. Do you know if there
> is any reason for keeping it this way? Otherwise, I propose we
> change it (see patch).
> 
> It is probably just a relic from when colour components were scaled
> from 8 to 16 bits by multiplication with 256 instead of 257; this
> seems to have been fixed everywhere else.

I'm not aware of any reason for this, and I don't see any immediate
problems with your (second) patch applied.
-- 
Alan Third



  parent reply	other threads:[~2020-06-06 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-06  9:57 Use 65535 as scale factor for color-values on NS Mattias Engdegård
2020-06-06 11:17 ` Mattias Engdegård
2020-06-06 18:57 ` Alan Third [this message]
2020-06-07  8:39   ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200606185734.GA16539@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).