From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Yuuki Harano Newsgroups: gmane.emacs.devel Subject: Re: emacs for pure Gtk3 Date: Mon, 27 Apr 2020 21:37:27 +0900 (JST) Organization: Ingage Inc. Message-ID: <20200427.213727.386515228111850912.masm@luna.pink.masm11.me> References: <20200426.165604.2054625945129238824.masm@luna.pink.masm11.me> <834kt673cy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="22099"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 27 14:39:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jT336-0005fQ-5h for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Apr 2020 14:39:48 +0200 Original-Received: from localhost ([::1]:43758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT335-0001iD-5Z for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Apr 2020 08:39:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38310) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT312-0006ic-UG for emacs-devel@gnu.org; Mon, 27 Apr 2020 08:37:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jT312-0004y3-9j for emacs-devel@gnu.org; Mon, 27 Apr 2020 08:37:40 -0400 Original-Received: from shiro.masm11.me ([150.95.182.25]:38998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jT30z-0004bV-2h; Mon, 27 Apr 2020 08:37:37 -0400 Original-Received: from luna.pink.masm11.me (224.232.12.61.ap.yournet.ne.jp [61.12.232.224]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 2675DC0142; Mon, 27 Apr 2020 21:37:28 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1587991048; bh=aqB+5ucEPQ0oCkthPYFcnRGJDPGCdYo+h+c2wsdJ4IA=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=A/Uid8fXFssGXwXssqD1DB0yA53ThL6Sceg5DYCeQSKQL5eIBnC26V1yKt1OuxIn3 3+xlW2Pu04F6mByEicpLFR26AEe1YB/0iyj7PeiMaxEqvE+x+qKtkQdOd/NFoI9iJH 5Y6/rljEy98KyOBpYZXmwDyGvF22KPrBcqch7OWQ= In-Reply-To: <834kt673cy.fsf@gnu.org> X-Mailer: Mew version 6.8 on Emacs 28.0 Received-SPF: pass client-ip=150.95.182.25; envelope-from=masm@masm11.me; helo=shiro.masm11.me X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/27 08:37:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 150.95.182.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247919 Archived-At: Thank you. On Sun, 26 Apr 2020 17:01:33 +0300, Eli Zaretskii wrote: > . You don't seem to have a copyright assignment on file. This would > be a significant contribution to Emacs, for which we must have > such an assignment from you before bringing this code into the > Emacs repository. Would you be willing to start the legal > paperwork now? If so, I will send you the form to fill. Yes. Please send me it. By the way, this fork contains much code written by @fejfighter. He said "for now: Yes I do agree to assign my code to the FSF." here, https://github.com/masm11/emacs/pull/11#issuecomment-600856858 . What to do? > . The code seem to be based on an relatively old version of our > master branch, which makes it hard to review (there are many > spurious changes unrelated to your work). Please rebase on the > latest HEAD of the master branch. OK, I'll rebase later. > . Would it be possible for you to describe the design of this > feature, and how that affects the various Emacs features, so that > understanding the changes would be facilitated? In particular, > can this new window-system live together with X and TTY frames in > the same session? does it support Lisp threads? etc. Also, what > are the requirements from the platforms where this could be built > and used? I started porting to pure Gtk3 about 2 years ago. I referred NS's code because X's is too complex. But I ported text rendering code from X afterwards. There are old codes because I can't follow NS and X code changes. Because I was not going to merge to mainline when I started porting, older commit messages are in Japanese. If you don't like Japanese messages, I can make one big commit instead of existing commits. Since pgtk emacs is configured with '--without-x', existing X code is disabled. If configured with '--with-x', the existing X support should be enabled as before. Pgtk emacs supports X window system too through Gtk library. It can handle Wayland, X window system, and TTY in the same session. But segmentation fault may occur when running on X and Wayland in the same session. Since Gtk does not support these functions on Wayland, they don't work on Wayland. On X, they should work. - x_set_no_focus_on_map - x_set_no_accept_focus - x_set_z_group - raise/lower - gtk_plug Since Gtk does not support this function, it doesn't work, even if on X. - vendor_specific_keysyms I don't know about Lisp threads. I have never supported it explicitly. Pgtk emacs may not support it. Pgtk emacs: - needs '--with-cairo'. - supports menubar, toolbar, scrollbar, tabbar, and fringe. - supports stipple. - supports childframe. Pgtk emacs uses cairo. It prepares a surface before rendering, render on it, and copy it on the window on a Gtk 'draw' event. X-gtk emacs uses gtkutil.c. Pgtk emacs also uses it. Since Gtk doesn't support xrdb, I implemented alternative using GNOME's gsettings. (pgtk-set-resource "background" "gray") (x-get-resource "background" "Background") Xrdb is not supported even if on X. The prefixes of functions and variables: 'pgtk-' and 'x-'. I don't have rules about which should be used for each of functions and variables. Gtk supports w32, but I have never tested on w32. -- Yuuki Harano