From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: A proposal for the future of open-paren-in-column-0-is-defun-start. Date: Sun, 5 Apr 2020 15:23:33 +0000 Message-ID: <20200405152333.GE5049@ACM> References: <20200405134735.GD5049@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30108"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier , g@acm.muc.de Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 05 17:24:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jL787-0007hE-0L for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 17:24:11 +0200 Original-Received: from localhost ([::1]:49134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL786-0006pb-3u for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 11:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38336) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL77b-0006Ox-4Q for emacs-devel@gnu.org; Sun, 05 Apr 2020 11:23:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL77a-00008L-3b for emacs-devel@gnu.org; Sun, 05 Apr 2020 11:23:39 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:11721 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1jL77Z-00007f-Qj for emacs-devel@gnu.org; Sun, 05 Apr 2020 11:23:38 -0400 Original-Received: (qmail 59080 invoked by uid 3782); 5 Apr 2020 15:23:35 -0000 Original-Received: from acm.muc.de (p2E5D5461.dip0.t-ipconnect.de [46.93.84.97]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 05 Apr 2020 17:23:33 +0200 Original-Received: (qmail 7541 invoked by uid 1000); 5 Apr 2020 15:23:33 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246463 Archived-At: Hello, Stefan. On Sun, Apr 05, 2020 at 10:33:17 -0400, Stefan Monnier wrote: > > With this mechanism in place, o-p-i-c-0-i-d-s could safely be left > > enabled, for speed's sake, > FWIW setting `comment-use-syntax-ppss` to nil is likely make things > *slower* in many cases. Anyhow, the problem with using syntax-ppss here is it involves lots and lots of scanning over large buffer portions in certain circumstances. The o-p-i-c-0-i-d-s approach wouldn't. Also, syntax-ppss doesn't (necessarily) do the right thing on narrowed buffers, thus potentially leading to errors. Why don't you make sure the buffer is widened before using syntax-ppss? > This "newish" variable was only introduced so as to have an escape hatch > if it turned out that the new functionality of relying on syntax-ppss > proved problematic. Why is the o-p-i-c-0-i-d-s mechanism made dependent on comment-use-syntax-ppss being nil? > Given that I haven't seen a single incident reported since that fateful > Dec 12 2017 night, I think we'd be better off removing > `comment-use-syntax-ppss` altogether. Er, Martin reported a delay of 10 seconds when scrolling a buffer with the mouse wheel. How does that not cound as an "incident"? What you mean by your suggestion is to remove open-paren-in-column-0-is-defun start altogether. Both Martin and Richard, who have less powerful machines than we do, are unhappy about this. Anyway, what exactly happened on 2017-12-12 that qualifies as a fateful incident? Also, you haven't commented on my proposal. > Stefan -- Alan Mackenzie (Nuremberg, Germany).