unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>, g@acm.muc.de
Cc: emacs-devel@gnu.org
Subject: Re: A proposal for the future of open-paren-in-column-0-is-defun-start.
Date: Sun, 5 Apr 2020 15:23:33 +0000	[thread overview]
Message-ID: <20200405152333.GE5049@ACM> (raw)
In-Reply-To: <jwv4ktyhurf.fsf-monnier+emacs@gnu.org>

Hello, Stefan.

On Sun, Apr 05, 2020 at 10:33:17 -0400, Stefan Monnier wrote:
> > With this mechanism in place, o-p-i-c-0-i-d-s could safely be left
> > enabled, for speed's sake,

> FWIW setting `comment-use-syntax-ppss` to nil is likely make things
> *slower* in many cases.

Anyhow, the problem with using syntax-ppss here is it involves lots and
lots of scanning over large buffer portions in certain circumstances.
The o-p-i-c-0-i-d-s approach wouldn't.

Also, syntax-ppss doesn't (necessarily) do the right thing on narrowed
buffers, thus potentially leading to errors.  Why don't you make sure
the buffer is widened before using syntax-ppss?

> This "newish" variable was only introduced so as to have an escape hatch
> if it turned out that the new functionality of relying on syntax-ppss
> proved problematic.

Why is the o-p-i-c-0-i-d-s mechanism made dependent on
comment-use-syntax-ppss being nil?

> Given that I haven't seen a single incident reported since that fateful
> Dec 12 2017 night, I think we'd be better off removing
> `comment-use-syntax-ppss` altogether.

Er, Martin reported a delay of 10 seconds when scrolling a buffer with
the mouse wheel.  How does that not cound as an "incident"?

What you mean by your suggestion is to remove
open-paren-in-column-0-is-defun start altogether.

Both Martin and Richard, who have less powerful machines than we do, are
unhappy about this.

Anyway, what exactly happened on 2017-12-12 that qualifies as a fateful
incident?

Also, you haven't commented on my proposal.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2020-04-05 15:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 13:47 A proposal for the future of open-paren-in-column-0-is-defun-start Alan Mackenzie
2020-04-05 14:33 ` Stefan Monnier
2020-04-05 15:23   ` Alan Mackenzie [this message]
2020-04-05 18:39     ` Stefan Monnier
2020-04-06  2:37   ` Richard Stallman
2020-04-06 15:40     ` Stefan Monnier
2020-04-06 16:04       ` Eli Zaretskii
2020-04-06 16:25         ` Stefan Monnier
2020-04-06 16:36           ` Eli Zaretskii
2020-04-06 17:49             ` Stefan Monnier
2020-04-06 18:16               ` Eli Zaretskii
2020-04-06 18:32               ` andres.ramirez
2020-04-07  8:33         ` martin rudalics
2020-04-07 13:47           ` Stefan Monnier
2020-04-07 14:06           ` Eli Zaretskii
2020-04-06 19:08 ` Dmitry Gutov
2020-04-06 21:42 ` Stefan Monnier
2020-04-06 21:58   ` Dmitry Gutov
2020-04-06 23:44     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200405152333.GE5049@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=g@acm.muc.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).