unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: juanjose.garciaripoll@gmail.com, emacs-devel@gnu.org
Subject: Re: Optional support for GDI+ on Windows (emacs-28)
Date: Tue, 31 Mar 2020 21:36:06 +0200 (CEST)	[thread overview]
Message-ID: <20200331193602.GA82791@breton.holly.idiocy.org> (raw)
In-Reply-To: <837dz01kxi.fsf@gnu.org>

On Tue, Mar 31, 2020 at 08:41:29PM +0300, Eli Zaretskii wrote:
> > Date: Tue, 31 Mar 2020 18:57:52 +0200 (CEST)
> > From: Alan Third <alan@idiocy.org>
> > Cc: Juan José García-Ripoll <juanjose.garciaripoll@gmail.com>,
> > 	emacs-devel@gnu.org
> > 
> > On Tue, Mar 31, 2020 at 07:47:38PM +0300, Eli Zaretskii wrote:
> > > 
> > > Like I said: this must not be a compile-time condition, we should
> > > decide whether GDI+ is supported at runtime, and we should provide
> > > variables to control whether GDI+ is used for each supported image
> > > format.  HAVE_GDIPLUS should guard code which uses GDI+, but it should
> > > NOT decide whether that code is actually used.
> > 
> > May I request that however the above is implemented, it can be
> > extended to the NS port’s use of NSImage vs libpng, etc. as well?
> 
> Can you elaborate?  I don't think I understand the request, probably
> because I know very little about how NS deals with images in Emacs.

Simply that since the proposed patch works largely the same as the NS
port, if possible leave any implementation generic. That is, rather
than create a variable called w32-png-use-gdi-plus, perhaps name it
something like image–png-use-native.

If it’s not possible then that’s fine.
-- 
Alan Third



  reply	other threads:[~2020-03-31 19:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 19:26 Optional support for GDI+ on Windows (emacs-28) Juan José García-Ripoll
2020-03-31 14:12 ` Eli Zaretskii
2020-03-31 15:35   ` Juan José García-Ripoll
2020-03-31 16:47     ` Eli Zaretskii
2020-03-31 16:57       ` Alan Third
2020-03-31 17:41         ` Eli Zaretskii
2020-03-31 19:36           ` Alan Third [this message]
2020-03-31 19:43             ` Stefan Monnier
2020-04-01  2:26             ` Eli Zaretskii
2020-04-01 18:33               ` Alan Third
2020-04-01 19:10                 ` Eli Zaretskii
2020-03-31 17:27       ` Stefan Monnier
2020-03-31 17:52         ` Eli Zaretskii
2020-03-31 19:37           ` Stefan Monnier
2020-04-01 13:31             ` Eli Zaretskii
2020-04-01 14:58               ` Stefan Monnier
2020-04-01 15:45                 ` Eli Zaretskii
2020-04-01 18:26                   ` Stefan Monnier
2020-04-01 18:39                     ` Juanma Barranquero
2020-04-01 19:22                       ` Stefan Monnier
2020-04-01 19:24                         ` Juanma Barranquero
2020-04-01 19:12                     ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2020-03-30 23:09 Angelo Graziosi
2020-03-31  8:02 ` Juan José García-Ripoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200331193602.GA82791@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juanjose.garciaripoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).