unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-27 3bce7ec: CC Mode: Protect against consecutive calls to before-change-functions ...
Date: Wed, 4 Mar 2020 21:24:47 +0000	[thread overview]
Message-ID: <20200304212447.GA26206@ACM> (raw)
In-Reply-To: <jl1rqelkjk.fsf@fencepost.gnu.org>

Hello, Glenn.

On Fri, Feb 28, 2020 at 11:54:23 -0500, Glenn Morris wrote:
> Alan Mackenzie wrote:

> > branch: emacs-27
> > commit 3bce7ec3826003fda1971224a20d7fe2cba8bf65

> >     CC Mode: Protect against consecutive calls to before-change-functions ...

> This causes srecode-utest-getset-output in
> test/lisp/cedet/srecode-utest-getset.el to fail:

> Test srecode-utest-getset-output backtrace:
>   parse-partial-sexp(1 627 nil nil nil syntax-table)
>   c-after-change-mark-abnormal-strings(100 320 0)
>   #f(compiled-function (fn) #<bytecode 0x9b5689>)(c-after-change-mark-
>   mapc(#f(compiled-function (fn) #<bytecode 0x9b5689>) (c-depropertize
>   c-after-change(100 320 0)
>   run-hook-with-args(c-after-change 100 320 0)
>   srecode-insert-fcn(#<srecode-template getset-in-class> #<srecode-dic
>   srecode-insert-getset()
>   #f(compiled-function () #<bytecode 0x9573ad>)()
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name srecode-utest-getset-output :document
>   ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te
>   ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
>   ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
>   ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
>   command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/cedet/srecode-utest-
>   command-line()
>   normal-top-level()
> Test srecode-utest-getset-output condition:
>     (args-out-of-range #<buffer srecode-utest-getset-TkO46e.cpp> 1 627)
>    FAILED  1/1  srecode-utest-getset-output (1.709802 sec)

Yes.  I've fixed this bug in the emacs-27 branch.

As a matter of interest, the scenario Mattias reported was caused by a
different bug (also fixed).

-- 
Alan Mackenzie (Nuremberg, Germany).



      parent reply	other threads:[~2020-03-04 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200223194642.5362.21709@vcs0.savannah.gnu.org>
     [not found] ` <20200223194643.A9A05206ED@vcs0.savannah.gnu.org>
2020-02-28 16:54   ` emacs-27 3bce7ec: CC Mode: Protect against consecutive calls to before-change-functions Glenn Morris
2020-03-01 11:49     ` Mattias Engdegård
2020-03-01 21:26       ` Alan Mackenzie
2020-03-04 21:30       ` Alan Mackenzie
2020-03-04 21:24     ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304212447.GA26206@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).