From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Merging the underline attribute at EOL Date: Mon, 16 Dec 2019 21:31:56 +0100 Message-ID: <20191216203156.oojz2o3uskxsgd5a@Ergus> References: <83eex771ky.fsf@gnu.org> <20191216161104.767sfxj7taabs5jl@Ergus> <83v9qg42vz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="108235"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 16 21:32:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1igx2f-000S0b-Ha for ged-emacs-devel@m.gmane.org; Mon, 16 Dec 2019 21:32:33 +0100 Original-Received: from localhost ([::1]:59578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igx2e-00031X-DO for ged-emacs-devel@m.gmane.org; Mon, 16 Dec 2019 15:32:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igx2X-00030v-Es for emacs-devel@gnu.org; Mon, 16 Dec 2019 15:32:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igx2V-0000Ei-T2 for emacs-devel@gnu.org; Mon, 16 Dec 2019 15:32:24 -0500 Original-Received: from sonic310-14.consmr.mail.bf2.yahoo.com ([74.6.135.124]:38452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igx2V-0000Da-Pa for emacs-devel@gnu.org; Mon, 16 Dec 2019 15:32:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1576528341; bh=0vwFDtZzj8FY4AzCAkQBvnBmz0TvizxZniPaNI+MB44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=ly5R1+xCXsQckyaQ4IASdsmM6lYBZ4egmIZEHY/eMAjM9llEZnGAyTPH0kHwP87TZPh1PBVH5iUfQc+WHYjDLeDU5qj7D776Wnu0PYnRnr9QKreSI8QNEQnIhmBi2ODd6gILo1wAvGWEj+hp6KRWtW6zsrFZprCSrvHeyn29r/moHJeCXxy/+d9Mi/ZvwZFjvjqR75DlnToA5RTYNTRREHhgCwSWBqUJuChS4me6KUxkGfx+OTndrICiiUpKF8B4u/w3HzCp+9o8s/lHb/yko2GnvWZGG8/0nwlSCkBSofQZHojWkw/X83sci8XF0HQS40WQGD03QC9cxqCfhiUA5Q== X-YMail-OSG: YgmVLYQVM1l195EZ_3usK5Df9wAH2aPGLnrP6Metd4xUxVEzLxWInSA15bXnA5q 1SHMlmihRGiaGjWL4hXpEjhY1GvXFVE.nIWy4bkthXQ2jpDpfY0Cs3eEwRwkp1_UWgHY4wV3wqix SvI0fleu8kMDWXmVLTBgA8cxKgySb9Fua4nFaqtfeJiMITQNi2vRXIWWq_rFRZkdIdKqFwL6r1s8 iWYT_bEtEsufw9J0r518y2O7RLbgpFS0NmvK8ZiuMu.0PSae7HNjX4jSmeroG_ZVB10OwmwOaXL4 HxscZ3GPvtzFGgSUtfdSE3gk0A9fxUwK5Pj2X4ZcfTjtW1sojt_U5S.HG7O6fGLIKw00xIbFgNY. P5HsAKtTmNSEiMRgMPaFA7X.Vt9W3kwE_EnoAsk2bJuYTTuMcY4m8YxbmNTQFoG.QGulaOVVUDnv 2nPHpGFI0e.Mqy4BTPeAm7ATrM1Cu_CYUJU9hnpRML92bMd98O2FoNSXtZ8JqZCFz1XDUyMt99Fq MtpNuVS6sgSzQ_Mitd_.p0ubufoUyT7QB7rLEAinB5cIEa.tcJAkVWfpkMe8r.KkhVAS3v1pKeJl ks74wK7B4W4p4SPPxjqsnNipWNDGGtPW562JR1msWQ9jjgAVhHrv9ghYbjNZ3qVC_CU4E2vKdHze njGU1Ycr9dNnLzana3X5bvQGcgjj949eDdw9vYMwPs5PIkpnqjN9QH9wExYD1QIbdz55vagn4grD T46DSWzdnaHg9mMIZ9C9yIQoGyaSoPXPFJw05AiWZBzSRdsVGc8xMMRscHgT2uawtL.5Pg2jZkmz F1uV58QjdOqDmReGFsv5FamisC3upg2KkvS_Ncll3N Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Mon, 16 Dec 2019 20:32:21 +0000 Original-Received: by smtp430.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 908e455e723abbbd58fd1c8e01e195ef; Mon, 16 Dec 2019 20:32:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83v9qg42vz.fsf@gnu.org> X-Mailer: WebService/1.1.14728 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.6.135.124 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243430 Archived-At: On Mon, Dec 16, 2019 at 07:05:36PM +0200, Eli Zaretskii wrote: >> Date: Mon, 16 Dec 2019 17:11:04 +0100 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> On the current master I can't reproduce the issue anymore. I don't >> remember where was my last built master before. Did you fixed this? > >What did you try, exactly? The issue I originally described, with >underline in a GUI frame, still exists. > Ohh sorry. I had build a wrong branch where I have actually added NILP (face->lface[LFACE_EXTEND_INDEX]) to the condition you mention. Actually the question is why there is only: face->box == FACE_NO_BOX Maybe we have to remove it and rely only in the extend attribute? What do you think?