From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Merging the underline attribute at EOL
Date: Mon, 16 Dec 2019 21:31:56 +0100 [thread overview]
Message-ID: <20191216203156.oojz2o3uskxsgd5a@Ergus> (raw)
In-Reply-To: <83v9qg42vz.fsf@gnu.org>
On Mon, Dec 16, 2019 at 07:05:36PM +0200, Eli Zaretskii wrote:
>> Date: Mon, 16 Dec 2019 17:11:04 +0100
>> From: Ergus <spacibba@aol.com>
>> Cc: emacs-devel@gnu.org
>>
>> On the current master I can't reproduce the issue anymore. I don't
>> remember where was my last built master before. Did you fixed this?
>
>What did you try, exactly? The issue I originally described, with
>underline in a GUI frame, still exists.
>
Ohh sorry.
I had build a wrong branch where I have actually added
NILP (face->lface[LFACE_EXTEND_INDEX])
to the condition you mention.
Actually the question is why there is only:
face->box == FACE_NO_BOX
Maybe we have to remove it and rely only in the extend attribute?
What do you think?
next prev parent reply other threads:[~2019-12-16 20:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 8:28 Merging the underline attribute at EOL Eli Zaretskii
2019-12-16 3:12 ` Ergus
2019-12-16 16:12 ` Eli Zaretskii
2019-12-16 3:49 ` Ergus
2019-12-16 16:17 ` Eli Zaretskii
2019-12-16 16:11 ` Ergus
2019-12-16 17:05 ` Eli Zaretskii
2019-12-16 20:31 ` Ergus [this message]
2019-12-17 3:22 ` Eli Zaretskii
2019-12-17 14:13 ` Ergus
2019-12-17 17:18 ` Eli Zaretskii
2019-12-19 1:19 ` Ergus
2019-12-19 15:38 ` Eli Zaretskii
2019-12-22 22:46 ` Ergus
2019-12-23 13:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216203156.oojz2o3uskxsgd5a@Ergus \
--to=spacibba@aol.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).