unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Issue with rectangle mouse selection
Date: Sat, 30 Nov 2019 18:02:40 +0100	[thread overview]
Message-ID: <20191130170240.q72zwzn5tfx4hdw7@Ergus> (raw)
In-Reply-To: <78251E2C-8618-4591-9C12-2A127295B606@acm.org>

[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]

Hi Mattias:

I tried the patch and it seems to reduce notably the issue. There is
still a small distance between the cursor arrow and the point (the arrow
stays over the rectangle's last position and the point is just after
it). But at least now the distance is small and remains more or less
constant.

Is it possible to keep the mouse and the point in the same position
without breaking too many things? (like when selecting without the C-M)

There are 3 pictures attached:

Square selection forward, backward and normal selection. Just to show
the difference.


On Sat, Nov 30, 2019 at 12:08:47PM +0100, Mattias Engdeg�rd wrote:
>29 nov. 2019 kl. 15.39 skrev Ergus <spacibba@aol.com>:
>
>> YES!!! this seems to work now. :)
>
>Perhaps the workaround should be mentioned in the docs for xterm-mouse-mode?
>
>> So the only issue now is what I reported on yesterday about the distance
>> between rectangle border (point) and pointer in white spaces (or empty
>> lines). But it seems to be related with display-line-numbers-mode.
>
>That's clearly wrong, thanks for spotting it. There were problems with side-by-side windows as well. In addition, the mouse tracking was sometimes one cell off.
>
>Please try the attached patch.
>
>I couldn't make up my mind whether to have the mouse track the cursor or the rectangle corner. Tracking the cursor mirrors the behaviour of plain (linear) text selection, but corner tracking works better up to the right margin.
>
>You can set mouse--rectangle-track-cursor to select either behaviour; I'm not sure if it should be a defcustom, or what the default should be. Right now it's nil (tracks the corner).
>



[-- Attachment #2: Normal-selection.jpg --]
[-- Type: image/jpeg, Size: 164157 bytes --]

[-- Attachment #3: Rectangle-select-backward.jpg --]
[-- Type: image/jpeg, Size: 168954 bytes --]

[-- Attachment #4: Rectangle-select-forward.jpg --]
[-- Type: image/jpeg, Size: 128241 bytes --]

  parent reply	other threads:[~2019-11-30 17:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191128100030.u5v5fto3vudkadnn.ref@Ergus>
2019-11-28 10:00 ` Issue with rectangle mouse selection Ergus
2019-11-28 11:09   ` Mattias Engdegård
2019-11-28 14:36     ` Mattias Engdegård
2019-11-28 16:10       ` Stefan Monnier
2019-11-28 16:19         ` Mattias Engdegård
2019-11-28 17:11       ` Ergus
2019-11-29 13:18         ` Mattias Engdegård
2019-11-29 14:39           ` Ergus
2019-11-30 11:08             ` Mattias Engdegård
2019-11-30 12:22               ` Eli Zaretskii
2019-11-30 14:51                 ` Ergus
2019-11-30 15:01                   ` Eli Zaretskii
2019-11-30 17:02               ` Ergus [this message]
2019-11-30 17:06                 ` Mattias Engdegård
2019-11-30 21:28                   ` Ergus
2019-11-30 21:47                     ` Mattias Engdegård
2019-12-01  6:24                       ` Ergus
2019-12-03  9:40                         ` Ergus
2019-12-03 10:12                           ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191130170240.q72zwzn5tfx4hdw7@Ergus \
    --to=spacibba@aol.com \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).