From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Wed, 30 Oct 2019 20:47:23 +0000 Message-ID: <20191030204723.GB12640@ACM> References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> <87a79itfzp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="186296"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 30 21:58:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPv2e-000mKb-52 for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 21:58:08 +0100 Original-Received: from localhost ([::1]:44350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPv2c-0007HR-Qr for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 16:58:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53983) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPusL-0004ym-NE for emacs-devel@gnu.org; Wed, 30 Oct 2019 16:47:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPusK-00075l-2l for emacs-devel@gnu.org; Wed, 30 Oct 2019 16:47:29 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:52123 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1iPusJ-00075G-NC for emacs-devel@gnu.org; Wed, 30 Oct 2019 16:47:28 -0400 Original-Received: (qmail 81736 invoked by uid 3782); 30 Oct 2019 20:47:25 -0000 Original-Received: from acm.muc.de (p4FE15A8F.dip0.t-ipconnect.de [79.225.90.143]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 30 Oct 2019 21:47:23 +0100 Original-Received: (qmail 12776 invoked by uid 1000); 30 Oct 2019 20:47:23 -0000 Content-Disposition: inline In-Reply-To: <87a79itfzp.fsf@gnus.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241647 Archived-At: Hello, Lars. On Wed, Oct 30, 2019 at 16:22:50 +0100, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > > Point is, in parse-partial-sexp the *can* be relied upon. Though I'm > > not sure how often they are used. > Yes, the doc string certainly implies that they can be relied upon if > you use that function instead. > On the other hand, perhaps I shouldn't have moved it -- > parse-partial-sexp is used a lot, too. I was only seeing syntax-ppss > everywhere, but I see that it's used less than 2x as much. More to the point, parse-partial-sexp is a primitive, an essential function upon which much is built. It MUST be documented, including its return value. syntax-ppss is not an essential function, though it might be necessary nowadays; it has had and still has its problems. > So perhaps that patch should be reverted anyway. Or have the list in > both functions. .... I think either alternative would be good. [ .... ] > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).