unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function.
Date: Wed, 30 Oct 2019 20:47:23 +0000	[thread overview]
Message-ID: <20191030204723.GB12640@ACM> (raw)
In-Reply-To: <87a79itfzp.fsf@gnus.org>

Hello, Lars.

On Wed, Oct 30, 2019 at 16:22:50 +0100, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:

> > Point is, in parse-partial-sexp the *can* be relied upon. Though I'm
> > not sure how often they are used.

> Yes, the doc string certainly implies that they can be relied upon if
> you use that function instead.

> On the other hand, perhaps I shouldn't have moved it --
> parse-partial-sexp is used a lot, too.  I was only seeing syntax-ppss
> everywhere, but I see that it's used less than 2x as much.

More to the point, parse-partial-sexp is a primitive, an essential
function upon which much is built.  It MUST be documented, including its
return value.  syntax-ppss is not an essential function, though it might
be necessary nowadays; it has had and still has its problems.

> So perhaps that patch should be reverted anyway.  Or have the list in
> both functions. ....

I think either alternative would be good.

[ .... ]

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).



      parent reply	other threads:[~2019-10-30 20:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191030121649.15369.13207@vcs0.savannah.gnu.org>
     [not found] ` <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org>
2019-10-30 14:59   ` master 305dbc7 2/4: Move description of value to syntax-ppss function Dmitry Gutov
2019-10-30 15:03     ` Lars Ingebrigtsen
2019-10-30 15:13       ` Dmitry Gutov
2019-10-30 15:22         ` Lars Ingebrigtsen
2019-10-30 15:26           ` Dmitry Gutov
2019-10-30 15:30             ` Lars Ingebrigtsen
2019-10-30 15:29           ` Lars Ingebrigtsen
2019-10-30 16:13             ` Dmitry Gutov
2019-10-30 16:17               ` Lars Ingebrigtsen
2019-10-30 16:47                 ` Dmitry Gutov
2019-10-30 17:03                   ` Lars Ingebrigtsen
2019-10-30 19:39             ` Stefan Monnier
2019-10-30 20:28               ` Lars Ingebrigtsen
2019-12-13 12:34                 ` Noam Postavsky
2019-12-13 13:03                   ` Dmitry Gutov
2019-12-17 16:28                     ` Lars Ingebrigtsen
2020-02-15 14:55                     ` Noam Postavsky
2020-02-15 15:14                       ` Dmitry Gutov
2020-02-15 16:23                         ` Noam Postavsky
2020-02-23 14:11                           ` Noam Postavsky
2019-10-30 20:34             ` Alan Mackenzie
2019-10-30 20:41               ` Dmitry Gutov
2019-10-31  1:45               ` Stefan Monnier
2019-10-31 14:06               ` Lars Ingebrigtsen
2019-10-30 20:47           ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191030204723.GB12640@ACM \
    --to=acm@muc.de \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).