From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Date: Thu, 17 Oct 2019 04:49:46 +0200 Message-ID: <20191017024946.6b7vmup4o3v3t3w6@Ergus> References: <20191017004602.22269.2935@vcs0.savannah.gnu.org> <20191017004604.866DF20BC2@vcs0.savannah.gnu.org> <875zkonpqm.fsf@gnus.org> <871rvcnmg1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="115766"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Lars Ingebrigtsen , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 17 04:50:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKvrj-000U05-2b for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 04:50:15 +0200 Original-Received: from localhost ([::1]:57718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKvrh-0004rg-Rt for ged-emacs-devel@m.gmane.org; Wed, 16 Oct 2019 22:50:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58149) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKvra-0004rQ-PF for emacs-devel@gnu.org; Wed, 16 Oct 2019 22:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKvrZ-00072s-0V for emacs-devel@gnu.org; Wed, 16 Oct 2019 22:50:05 -0400 Original-Received: from sonic310-12.consmr.mail.ir2.yahoo.com ([77.238.177.33]:39440) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKvrY-00071x-HG for emacs-devel@gnu.org; Wed, 16 Oct 2019 22:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571280602; bh=AumK9C9lV0h8pgacDCO3r9iibc+PuXE5Vy0fzGnDjEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=D8g7fnYrlUpyaplHJxvYL99LFqcOgPTpPiABh92zV1R4pul8lY5xpxcPwlLGBBgd2VrKaolp88BVExVypYjD2Xlvgopmq2SsEGFIn+9XybT/gQKkaU+k0po4vOeBkMKmXyOxyKtR7NBA8TsQKSDLLDemvGcSMfE5Rbd6hH3EaMjKqYefvBxKZcD24PAnmYjXkVVhUZAQOpk33QCYlF7Cdcf8FedqnBQvSmYQYWjMWK0KP+7LS0cZ/FqBdHS8Bi5lMEd3JEM5r6c8d/3GVYPXhzQbQqCf/KsD3T5vWFfiUH6HQ1uYOD3A6i2+HRG97CkvOh+QSjvF55PYbahiFYK8sA== X-YMail-OSG: 01KwH4YVM1kB9ehLHwfpPtsleJvc1HJteIbYq7tSAyWy5ParjtbFdbuV_L.NSW3 5qbEu.bwSmX1ca8zR25qz9dGLqas_r0bp3LtQ.DQME0TvYvC6JbfGQWgfis7uHqzhaS5lix4MLnQ f4DbngK3hRQi5zNvQtlo0GGvLQMW51_fnRRaq43iqFTpPI0hPLP9W2R6psuuqFtvA0Bgoa0uMcjb czDn7lqMth9VQ.7dLO_yPdRFz0vjs9Vksc5Yuo3hl6K1QVlFQ_rTYlp3I1qw8xi2KDN8Z9wEc.Jd lKdJwneqMpglpmTcB3HqpWVbkJuwMuKeeh4fmvRFqKuHqSsPOU6s2uEAeAYRACUCrS.aU0CN6ABS wq7CBu3IGHa.ORN7L4Fgfgm1oCIZIg8PZHs78DBEP4DXUPV2SAhu6lvwuf3.j.fOXwBkOrYdk8fh J6BgSEjqsFJGTHN7WPqoWJkQ8sTUjU_f5nO4NAsoAA7FA9zKUvDfJO8x0A0w4usNPoP9lnNk1w96 nOIg9y2NY.FDzKMiP1J20SsIEZLguHDyHflYUHUU7cDf12GC4gyu.EoSt9QFKD1F4xrEoFe5bbTr byXbzdWPyP4OPm0Pb2AfnJHc6m4BSMLKnRdvenwjUXgBgdthwNoxMgSaH8QBEPVeAp97sazwn2YD 8JZlNnPIRYorDYLZ79.K6yG9FrxJcErGwt_yktvMdr93EavaQsQ6NgJKbF9ljJqNeG3vAXMbHw7W ri6OH3PtFkrOnZhsJv58EfeliC0FgDrLB1cr6VFUX8YEGQrINRFhrTt5v94UySxYwiT1BX3aKttG hCIyTSJbkx.8uwPtV4UKzP_EoC5DBUUEDI8QLk_B_T Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Thu, 17 Oct 2019 02:50:02 +0000 Original-Received: by smtp424.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 88886330b9827506d93e971c3e2f7536; Thu, 17 Oct 2019 02:50:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.177.33 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241113 Archived-At: On Thu, Oct 17, 2019 at 04:26:34AM +0200, Juanma Barranquero wrote: >On Thu, Oct 17, 2019 at 4:19 AM Lars Ingebrigtsen wrote: > >> I thought it was kinda opposite: When it's a predicate, we only care >> about nil/non-nil. > >Most predicates are defined as t/nil, like numberp, booleanp, etc. Usually, >the code that uses them only worries about the result being nil/non-nil, >but there are some exceptions. > >Anyway, if you feel strongly about anything on my recent patches, feel free >to change it. AFAIK: In lisp true means anything non-nil for most of the purposes. This change I am not sure how convenient is it. It just ads some extra complexity to read with no benefit. Maybe it made more sense to fix the docstrings to say non-nil instead of forcing the code to return t?