From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: :extend face attribute at EOB without end-of-line char Date: Tue, 15 Oct 2019 18:38:18 +0200 Message-ID: <20191015163817.flw6sryikhktorc3@Ergus> References: <83ftjvi4yp.fsf@gnu.org> <83a7a3hzxw.fsf@gnu.org> <838spnhz64.fsf@gnu.org> <83zhi2h6up.fsf@gnu.org> <83mue2h0rl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122516"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Juanma Barranquero , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 15 19:02:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKQDR-000ViW-Tk for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 19:02:34 +0200 Original-Received: from localhost ([::1]:53310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKQDQ-00016i-7y for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 13:02:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43002) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKPqK-0004hv-W4 for emacs-devel@gnu.org; Tue, 15 Oct 2019 12:38:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKPqJ-00027N-5M for emacs-devel@gnu.org; Tue, 15 Oct 2019 12:38:40 -0400 Original-Received: from sonic307-54.consmr.mail.ir2.yahoo.com ([87.248.110.31]:34531) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKPqI-00024i-RJ for emacs-devel@gnu.org; Tue, 15 Oct 2019 12:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571157516; bh=NUuVbNd9GeCacCTLP2Oa0VJ+rE1HqJUwS9C4EFFpDbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=cigqtDy7VK9fKMbackMepKgz8ME03/utlRRSYPn8CRJasCsOhVB1qy7ps/Jn6niXp29kV2vWqBHBnguSMwiTf0ZNwrCRM0txV37Q/cD2PocYvs2NMw6+10+Bgt8vOgT8kdhniE+uKzPRmmWxiWP3o1w+eyRvLrF2uG2X33MPjX1fFUQOrUAgZd/iSVbFcS/f68q55qBP2Cob8ezseKefga6FQ4xUiqM/ARV/Qqab7Z/eucMHrGkyHnYePyEBFrrfJKi1hF/qUpaJ75r1fSPnWia+O6zSDIObWSXif96y+M02q8xBwcpPiEixR63lV52ijZyiZqKxIAicG71CHXWz4A== X-YMail-OSG: _jCNbfUVM1nZJ.o8O0w91LLjTBP4j5RZbQ2LDarmzl.kQ8cnMGusNdfjpFnf2SH vEMYuEh7MRQUsEAgQxG.XjnG.AdcevVkUScyU_loJc3UC5vSGeDroukYRmKsjqhD2x2G4Q6snCsp SSPLWBQ7UY8_jK2zg4MzuvwdoDZOTalti7EPe.J55bdUSOXckrpZIPv43Co.B1jTa6qQrJbcHIEq i.JZ5BnLJg3WZ44a8fUmZvJnlLmgcDmB6gI8fDZAT9_vtMPcXWwKqZyzcYYXaaeFEr6jqokI1lK4 piXyFXYJvl_rH_tCn..THwKqIUo4tBsTsMFeTQiEgWBr31Kb8vdJ3KZSFE1o8rwTkU9zuzWjrmxj SJz6EfGcH8psqr0HwKfDvZ51jYB7Qxm7qPdq5jX015O97ya.dV6JdLLiNEFdCT0IaCnaDElsNDy9 Nf1fK6C20Oe6jIvbYyaGi66NP2laWsi6Mhn.Z16AzgJeSrWpHwDBO8r8I9l90c24zBE566gvWTzM P37B0YCuPeOv3B_Re_zvIkPoH3gxlkv5XDaTCIMz2aX1UCyOJCKpH1FHsXtv9MWPdvW7b3K..X3C WbDgUDjjsMdki1jOHNHIG7UzB.x5jbiJtPvllkJH04j6Jb8JFvrLdC2TVsjYj99lqewKkWiKZj3U FyukgyzV3wSBA.BQ0cIzf4H3CYnxhInNMGTHFEnugAbaeANZb1g5nN3Ca4R.pUKb1rTliHz8gClb zE3aB.jQudPWQ9nXkDUM5lwPqBq8wihgoK8ETja5HjPs9_wkSiJ_hsZoVNbKs6SY1n.6LRla2Nhb rl9QiVm8hVMoDtEQpqCixsTB0Qy8WAgkj6pQgICY1_ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Tue, 15 Oct 2019 16:38:36 +0000 Original-Received: by smtp427.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 4a798038c3990b7efbf1a8568ac167af; Tue, 15 Oct 2019 16:38:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83mue2h0rl.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 87.248.110.31 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241056 Archived-At: Hi Eli: Somehow this is related with something we discussed some time ago, about the fact that we should call extend_face_to_end_of_line in the last line of the buffer if not empty in some conditions (dfci is active for example.) Maybe you remember that we don't have the indicator for the last line, which somehow we agreed must be corrected. In this case the problem is the same: the extend_face... function is not called for the latest line in the buffer but I didn't find a better condition to fix this (I didn't try very hard either) But probably it just requires to extend a condition in an if and part of this problem will be fixed (the case for the last line at least) There are some conditions in the display_line function to not call extend_face_to... when the line ends at ZV, fixing this condition we should be done right? On Tue, Oct 15, 2019 at 11:27:10AM +0300, Eli Zaretskii wrote: >> From: Juanma Barranquero >> Date: Tue, 15 Oct 2019 10:10:21 +0200 >> Cc: spacibba@aol.com, Emacs developers >> >> > OK, but still, we'd need a rationale. >> >> I'm not sure what rationale would satisfy you. In my mind, the idea of extending a face up to the margin of the >> window seems quite decoupled from whether that line has a newline at the end or not. It's purely visual. If I'm >> using a face that extends in all lines, for example, I find weird that it does or does not extend in the last one >> depending of a newline. (Again: I agree that's how it is defined now, I'm not questioning that.) > >Face extension is only a factor when it ends on the next line, >i.e. "covers" the newline that ends the line. When there's no newline >at EOB, the face ends with the last character on the line, so IMO it >makes no sense to extend it, because what would such an extension >indicate? When there's a newline, extending the face indicates that >the newline (which is otherwise invisible) is "covered" by the face.