From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Mon, 14 Oct 2019 00:27:52 +0200 Message-ID: <20191013222752.igeivpsmayfxa557@Ergus> References: <20191012222305.jpjinkd5y2lz6xiv@Ergus> <83mue5kmfx.fsf@gnu.org> <20191013154052.yzluijtwvf2ppvks@Ergus> <83a7a4ljet.fsf@gnu.org> <20191013164424.4vyxdnm6ievyvjyf@Ergus> <837e58lgql.fsf@gnu.org> <20191013182542.34euwh2gihawyots@Ergus> <831rvglbom.fsf@gnu.org> <20191013193836.jl3odnemyh6l7hzb@Ergus> <83y2xojr5x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223549"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 14 00:43:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJmaj-000w3u-5u for ged-emacs-devel@m.gmane.org; Mon, 14 Oct 2019 00:43:57 +0200 Original-Received: from localhost ([::1]:43348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJmah-0001l2-Ut for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 18:43:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJmLV-00014R-HQ for emacs-devel@gnu.org; Sun, 13 Oct 2019 18:28:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJmLT-0001pt-Vd for emacs-devel@gnu.org; Sun, 13 Oct 2019 18:28:12 -0400 Original-Received: from sonic307-7.consmr.mail.ir2.yahoo.com ([87.248.110.32]:41884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJmLT-0001pC-Gw for emacs-devel@gnu.org; Sun, 13 Oct 2019 18:28:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571005688; bh=XQc3RzCGfI9np3/ljp3FWkrfRw3ANC0bBut5lZyOjPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=CdpOl3i9R1sbDXtqlbrVAi0Z6csUgfZ16nJsWsW8pvWqhYrdt215+4X0UoXV4g+9wsd15zNfM6It27zKxs7+b+ROqnuP4tsVyTCKe9OpP2QTTYa5nCHEUiSmsEey5ygS4Pwq172KNEIhLzwBiJFyJXm02jyJKhi1+BR1V6ZatSrDjuDURNrz2YvjV0TvQcjPqo0tlsTc6BaeL6ODfK72OyYNzoApcNvDKTiRoVN/OAGz7LMwO8CKUD2Hb9BMsOiBIQal7IvdAxq7OY8R2GtKOjebFQXSQPbBeOANXwhdN4kwPz5Y3xWTkaJ9dEuUiZHcpOHqyApYvumaTgslDucRRA== X-YMail-OSG: jJCEUPgVM1kwscejarlvoAaSRi5c_wjcxSwShtGHhlEBxg7E3aQc83L.V9lWJmJ wx27.3OiY83jRTT0X0Cta.gw8sWMGJtd5XoqA5tKOy13PSQw1DM8d_5jQ4aup5grMnGVnA3J4g54 Qu_GXj8WPhcgWhRTWlSzL5HP6.1wmLfUzVNBYUKyv2mgnoCAXl1ynLM9oqfc1dCIGqDi7rjZCG2_ CUHoMb5zkGRIaA23cejwrE17d_ioY4OiMKS3UCMFIQwYjJfdi_vtSKo_r_AQaTnwFaJm1BNZsAQQ 7IV9.TUJzBxRFPOtDnqKeY0Cx6Q85KZqwmf.tagiubUp7IacfSK3FZcg0lA5WMboDreva8.0RGOA 820n8wt5tXlA.0un2WpRMocuOBMvZGzv0s13Vnl6b..oUJx0nxEG.YOj5Llkx61Ingb8ukTjex83 XqnnsY.SDmGGb1Snc8xpE5MKwDnmuclkkwEEXcVRCpl8V6R0PCvw.J1AqrvNekQSKdFJgR7paWI2 eYKhvoWHaEGVJGdTPhjnmZy.qeiZzzEhGQeSCznAZJ5bFQV61eHF7D5LZcxPV.t74kuPm.QVvWVO YTG76Cz8TJ5uIWyWzcWrUiw2gV.6uEeghc3oEaXHPlhXNLz.TKzrfOkjkmuz_p1Zq5uIbatEikIh HDGsDuJ75wAfok_feZNIDAkad.nZ04_AggIEE3HwHj6rtlsAx4tXTemdRO36Seprywar3R7u6NOV .Dk6L0rLO5AYxHju9M12uZ8Y10514vlZ2wCXBzQAmltwuqfwdszrYwstrGDvQaRHbGQ.IE.Dhf1i i75XB_VimUE2OTn6E2Ou7aRUThol3YE4mwqW2R4Iux Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Sun, 13 Oct 2019 22:28:08 +0000 Original-Received: by smtp427.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 46bb5ddbe6dc7c5571d63d04027dea00; Sun, 13 Oct 2019 22:28:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83y2xojr5x.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 87.248.110.32 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240994 Archived-At: On Mon, Oct 14, 2019 at 12:01:46AM +0300, Eli Zaretskii wrote: >> Date: Sun, 13 Oct 2019 21:38:36 +0200 >> From: Ergus >> Cc: rudalics@gmx.at, emacs-devel@gnu.org >> >> (gdb) p it->sp >> $1 = 0 >> (gdb) p it->method >> $2 = GET_FROM_C_STRING > >If we are producing glyphs from a C string, then faces should not be >used at all, because C strings cannot have faces. > >So you should to condition the call to face_at_pos on something like > > it->s == NULL > Hi: This have fixed the issue, I understand now what was happening. Should I merge into master now? maybe you should close the related issues then right?. >because there can not be any face on any position of a C string. > >> (gdb) pgrowx it->glyph_row >> TEXT: 85 glyphs >> 0 0: CHAR[-] str=0x4fab1a8f[0] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 1 1: CHAR[U] str=0x4fab18f0[1] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 2 2: CHAR[U] str=0x4fab18f0[1] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 3 3: CHAR[U] str=0x4fab18f0[1] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 4 4: CHAR[:] str=0xf2787f0[0] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 5 5: CHAR[%] str=0x4faaee54[1] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 6 6: CHAR[%] str=0x4faaede4[1] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 7 7: CHAR[-] str=0x4fab1721[1] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 8 8: CHAR[-] str=0x4fa9d9a8[0] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 9 9: CHAR[F] str=0x4fa9d9a8[2] blev=0,btyp=L w=1 a+d=0+0 face=1 >> 10 10: CHAR[1] str=0x4fa9d9a8[2] blev=0,btyp=L w=1 a+d=0+0 face=1 > >This is a mode line, so it figures out: extend_face_to_end_of_line was >called when the iterator was processing the final blanks of the mode >line, see display_mode_line. >