From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sun, 13 Oct 2019 21:41:10 +0200 Message-ID: <20191013194110.pswohb5h4ak4fyfp@Ergus> References: <20191012222305.jpjinkd5y2lz6xiv@Ergus> <83mue5kmfx.fsf@gnu.org> <20191013154052.yzluijtwvf2ppvks@Ergus> <83a7a4ljet.fsf@gnu.org> <20191013164424.4vyxdnm6ievyvjyf@Ergus> <837e58lgql.fsf@gnu.org> <20191013182542.34euwh2gihawyots@Ergus> <831rvglbom.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32067"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 13 21:42:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJjke-0008Ci-Vc for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 21:42:01 +0200 Original-Received: from localhost ([::1]:41910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJjkd-0000Q9-QP for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 15:41:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35730) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJjk7-0000Px-NW for emacs-devel@gnu.org; Sun, 13 Oct 2019 15:41:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJjk6-0003Jw-4G for emacs-devel@gnu.org; Sun, 13 Oct 2019 15:41:27 -0400 Original-Received: from sonic312-26.consmr.mail.ir2.yahoo.com ([77.238.178.97]:39176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJjk5-0003Gu-U8 for emacs-devel@gnu.org; Sun, 13 Oct 2019 15:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1570995684; bh=gOgNRcMbA+EKQpXDAn4ZL8DrSS3wq9Pe6CLDtGyfsoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=hPepja0l3yyW8ggoXX6C+JA+ppKJC5mrpGs5BZ/n+mL9TOKGxLp24JEExNRe96KpOOwQQ6I2BR0Cdx1iOJWPg3vKqZWlx9dIZtLxavsOM6u2hCKihcIjrL68TmJSxBax5Z8L3aedW/V03YTY3GKVFtdI7nc+m+Izi10apeNmLuGg5VL/eHq2D85moxIYMe8vx7i5wmXn/b5+qLFzUzosxyhqWnkM1MNEj7fQOQS8rnqyoPILcYAH2Ux+2ZQEMcF8RvCqzoHlFQoeMqp8kLFgikKFQLa8ZZfcdmUGS0in7z4sLO0C7QV4k+t+T3Ia2F5mdt8Ts8R0mLFb8dS/hvmL4A== X-YMail-OSG: JMWPJA4VM1n7gCkpCeLrIH9Fdw7D2MKuim9hMV9YsVXlGkehbImRo9RABFXoLBQ WC4WHd0MFEzSthRuZYm6g5u85BCQtXvH9XWgK5Xh.O9dzShJuLgUK9R.astOGF_4yYxFSpp_Idu1 qb2aNF.aGm.zix7DNkRHUfyZ0ki0ueTdWlk3D95jVSC.mRwdYdtsvIOe7P7S1L3vs8oQTxIWtfuR OhwV5FLZY27wfNi_gILuFx5KXFbRirDsgPgCYw.ea9UL3_lQ.vsJzTfV66OlJpTgGoNccXSfPZhe 1zSd1CMhZpzb1qfZGWzUHXCZxEnpFD.ODHyid1pEBIVPXW9xyHv8s9XQUjWAflRcDhupcE_1UJDk bY1uOeZrq6ynhiJ_BsIDNesL44ec05Wh_ZS5ZkAaXylj9asT0CLakKERexzJ7ovxdM7JfRF2zOis gYad5U44xtdV9Fxw7A9VBZAVA33cq_MW3o7bCkE4ZjZp_85ZCy9UoVLjt5NPBleAECTG1_AFkl9F W8iYsb6W9zaQo.2bGh6h0lrL.JE319D_9QS6UKP7itqkJLZdzCaZthEj9_uF5erEZOZvO_gL7UdG .QXD.kbS4jtlxZcb5Fckz_C1lKQd9QQ0CQVvk0FJRzrgJSLXlvP6SAxb5HnM0FCnOZKLYrlaBTQE 0ptimz_..W.oMSTnVj53vehaWTqoZGlmfsfvw6NAt3er6V79gahc8HVrYnpkUpCSV0e7g_ta_bBF Y7XjpjycgQcCTBcn74Ojjzpw5lNBZF6n4lhL3sCCjkZwaH6TeWls1E7E2eXWVbOGbkuhciREzldy 5vyTF0q3Hmf3rN5wUQOFnLG8X9drQ3AQTouT2T2rxe Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Sun, 13 Oct 2019 19:41:24 +0000 Original-Received: by smtp421.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 7b5d78ba8c8a956407bc95cb585c88e1; Sun, 13 Oct 2019 19:41:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <831rvglbom.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.178.97 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240979 Archived-At: On Sun, Oct 13, 2019 at 09:53:13PM +0300, Eli Zaretskii wrote: >> Date: Sun, 13 Oct 2019 20:25:42 +0200 >> From: Ergus >> Cc: rudalics@gmx.at, emacs-devel@gnu.org >> >> >Then looking at the position that causes the error will probably tell >> >you what's wrong. (Is OBJECT passed to Fget_text_property a string? >> >if not, position of zero is invalid.) >> > >> >> Actually conditioning the call to face_at_pos to when IT_CHARPOS (*it) >> != 0 seems to fix the issue with magit... but maybe we are just hiding >> something under the carpet here. Can you imagine something more general >> than that just this condition? > >How did it happen that IT_CHARPOS(*it) is zero? If we are iterating >over a buffer, that cannot happen, because we begin from 1 and go >forward. > If you see the bt I sent before the problem is in display_mode_line. >Is it->sp zero or higher? If it's higher, then we are not iterating >over a buffer, but something else (a string, an image, or something >similar). What are the values of it->method and it->what? Can you >show the result of > > (gdb) pgrowx it->glyph_row >