From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sat, 12 Oct 2019 20:16:18 +0200 Message-ID: <20191012181618.kdid42a7epdcf6ev@Ergus> References: <20190917021725.xxhhhxcz3nr6sb7z@Ergus> <83blvjw8x9.fsf@gnu.org> <83v9tmqcv7.fsf@gnu.org> <20190921215551.ruu6ji6sjpxydpng@Ergus> <20190926163204.gdb4gxbjtdbysk3y@Ergus> <83zhiohfnx.fsf@gnu.org> <20190929103034.jw5qolfjtbjkbk5p@Ergus> <83impbfjzh.fsf@gnu.org> <20191007154054.zfbsuktkaue5ymbr@Ergus> <835zkywatq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="74811"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 12 20:17:23 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJLxC-000JCP-HV for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 20:17:23 +0200 Original-Received: from localhost ([::1]:35308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJLxA-0002G8-DL for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 14:17:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42618) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJLwY-0002Fa-OD for emacs-devel@gnu.org; Sat, 12 Oct 2019 14:16:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJLwX-0004So-1x for emacs-devel@gnu.org; Sat, 12 Oct 2019 14:16:42 -0400 Original-Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:45695) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJLwW-0004SL-Qk for emacs-devel@gnu.org; Sat, 12 Oct 2019 14:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1570904198; bh=Lyt1g28E1oK+XVFAGQjgmM714a3AOUEiTfWTIQmaqvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=G59ICqgy7JDLQ4wg+x+qC2VVYhPDMd36SNoIJwE8RvsRM9gdX41uPipoKHFH8Xpw7YrZtUqHSuj8O9x0126v7xu0EbaJYQedUX0xlPzeOpQyqZlvIGHXhqTx3CvZA6I2d8C2mtKS/tbIBPp7UurnFwcWc6B2FwtGiOF4Hd4yLLKL7LH2YQDK7SrMLyBeiqRMCGRtAwpMx+yAHyuUQUuyE9Dvz0Kp9eoYtEbIUlVeFSMW0fUUWHbLFYwmkK3zFR92L6F1dAMqNycjKG1GFDMN8NvFWn6SlMCCZemyK0qCReEplNxqRKXXDq2qvx4RvGN8LqlGME6SNvNLiAnP/2vR8g== X-YMail-OSG: Hr393lgVM1lizMORB4SBoyXOo0rfLzT1sHJaSWPYt161J1FuSSGRNEwgpX_wVV5 T9Stm2XrlCBQ7133DaWZVQfIz5va4788YVcCzDtPdzDJvObxo5JwZx.2DqgzpCHqnUX8c46nNjoM mu6uaDzj0trxxalrn4Sk4HrniJmn9xGeHk9eFxpzy5ciBTX2S8h9kwKNurdxYtMB19vwWVhyeXGi QKhnHmPcYGu196NMxLNwRVNZLxcbcTS1eJBmKKlS8vPFiRXnp9d.JSPLIoa6rNzGfyk4.ZwTfo7. PdOonVsj_b5H3nccZ__LzYuI0ynVUxIJCBBOWvXa0.gsYpGw7r0_zcask8qtYGaIU52Y8fvwmwaR MYrm2YdwX7coceBQ4VfkR4q.qe52lWvxaeRl0HIIFxhybA5DUVbbaqEXe0Fn07RhNw5OTLML4htO EJ4nplsLPalAs8XR1PQJhVJtXvf1I.ecXWJFHwMuQP5EfCcRcitqAvw9shH2TIZXD4.zygA3E6sk WMmTih41YCFbaOEWDMgnxdHmXPCV.BBiCUmA2K9ma7oVeDlzmu8iegmtqEfSpX.QJolS9R6Jc9Pq UAWbbhoyGlCTPgKCvnGgV67oGNhXeSVOTBVmAHAdeNNETPQdQYSLZ_qjyKICceIYGQSFndXC8x9a vmZooapAqZ5s_.Iam4FoCuI8Gyd9DaQnGdB7SZOPvewxDxlFdhXw51BdX0e_b2YptDcRT0ZY30S7 EJ7xdM_c5qqG7BMv9lBQPlr6EBSfq_Yc9ujoCP6BBEgvM9UuLWl6PFsg4IgvJQ7z4IwiQ3f1v5pk Mjkgk5CgirkvkOCIoNTV.gTO42URqYV9UWDDIvRs.E Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Sat, 12 Oct 2019 18:16:38 +0000 Original-Received: by smtp405.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 0094fe3a7e66ed0fdc8f57b8476c5c5e; Sat, 12 Oct 2019 18:16:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <835zkywatq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.177.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240931 Archived-At: Hi Eli: I haven't merged this yet because 2 days ago I found that there is a bug in the code very difficult to locate for me and I have not understand what's going on. The problem is that emacs just freezes in the magit-log buffer in tui. (M-x magit-log-all for example.) This seems to be a weird issue because in gui it doesn't happen only in the terminal interface (which should be agnostic to magit). And I have only observed it in magit-log. And if this happens for magit-log I am wondering that there should be other possible situations that produce the same problem. After some tests and moving in the history of my changes I got that the issue is the call to handle_face_prop in extend_face_to_end_of_line. Trying the next in current master I got the same issue: // =============================== diff --git a/src/xdisp.c b/src/xdisp.c index 893ce9269c..af50dd0bcd 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -21587,6 +21587,7 @@ extend_face_to_end_of_line (struct it *it) || WINDOW_RIGHT_MARGIN_WIDTH (it->w) > 0)) return; + handle_face_prop (it); /* Face extension extends the background and box of IT->face_id to the end of the line. If the background equals the background of the frame, we don't have to do anything. */ // =============================== In gdb I saee that it goes in a very complex inf loop within the display engine functions and emacs becomes completely unresponsive (No C-g or ESC ESC ESC) the only solution is to kill it from outside. Magit provides a way to execute emacs loading only magit (magit-emacs-Q-command), so it is nothing in my config... but something probably tricky used in magit-log that exposes the issue. Could you give a look please?