unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, juri@linkov.net, emacs-devel@gnu.org
Subject: Re: Tabs
Date: Wed, 9 Oct 2019 15:55:39 +0200	[thread overview]
Message-ID: <20191009135539.c2i6ob52td6p34ab@Ergus> (raw)
In-Reply-To: <83o8yqumdl.fsf@gnu.org>

On Wed, Oct 09, 2019 at 03:36:06PM +0300, Eli Zaretskii wrote:
>> Date: Wed, 9 Oct 2019 14:05:34 +0200
>> From: Ergus <spacibba@aol.com>
>> Cc: michael_heerdegen@web.de, juri@linkov.net, emacs-devel@gnu.org
>>
>> >diff --git a/src/xdisp.c b/src/xdisp.c
>> >index 893ce92..f94f651 100644
>> >--- a/src/xdisp.c
>> >+++ b/src/xdisp.c
>> >@@ -11796,7 +11796,7 @@ clear_garbaged_frames (void)
>> >
>> > 	  if (FRAME_VISIBLE_P (f) && FRAME_GARBAGED_P (f))
>> > 	    {
>> >-	      if (f->resized_p
>> >+	      if ((f->resized_p || f->tab_bar_resized)
>> > 		  /* It makes no sense to redraw a non-selected TTY
>> > 		     frame, since that will actually clear the
>> > 		     selected frame, and might leave the selected
>>
>> No, this does nothing
>
>If you set a breakpoint in this fragment from clear_garbaged_frames:
>
>	  if (FRAME_VISIBLE_P (f) && FRAME_GARBAGED_P (f))
>	    {
>	      if ((f->resized_p || f->tab_bar_resized)
>		  /* It makes no sense to redraw a non-selected TTY
>		     frame, since that will actually clear the
>		     selected frame, and might leave the selected
>		     frame with corrupted display, if it happens not
>		     to be marked garbaged.  */
>		  && !(f != sf && (FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f))))
>		redraw_frame (f);  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>	      else
>		clear_current_matrices (f);
>
>does the breakpoint fire after you type "C-x 6 f"?

Yes:

Thread 1 "emacs" hit Breakpoint 1, clear_garbaged_frames () at ../../src/xdisp.c:11805
11805                   redraw_frame (f);
(gdb) bt
#0  0x00005555555ed30c in clear_garbaged_frames () at ../../src/xdisp.c:11805
#1  0x00005555555f33c9 in redisplay_internal () at ../../src/xdisp.c:15237
#2  0x00005555555f2564 in redisplay () at ../../src/xdisp.c:14825
#3  0x0000555555775f6f in read_char (commandflag=1, map=0x55555691f1e3, prev_event=0x0, used_mouse_menu=0x7fffffffd171, end_time=0x0) at ../../src/keyboard.c:2473
#4  0x00005555557858d0 in read_key_sequence (keybuf=0x7fffffffd3a0, prompt=0x0, dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true, prevent_redisplay=false)
    at ../../src/keyboard.c:9527
#5  0x0000555555772fbe in command_loop_1 () at ../../src/keyboard.c:1345
#6  0x0000555555896deb in internal_condition_case (bfun=0x555555772b76 <command_loop_1>, handlers=0x90, hfun=0x5555557722e9 <cmd_error>) at ../../src/eval.c:1355
#7  0x000055555577283b in command_loop_2 (ignore=0x0) at ../../src/keyboard.c:1091
#8  0x000055555589665c in internal_catch (tag=0xd470, func=0x55555577280e <command_loop_2>, arg=0x0) at ../../src/eval.c:1116
#9  0x00005555557727d9 in command_loop () at ../../src/keyboard.c:1070
#10 0x0000555555771eb8 in recursive_edit_1 () at ../../src/keyboard.c:714
#11 0x000055555577203c in Frecursive_edit () at ../../src/keyboard.c:786
#12 0x000055555576a4a7 in main (argc=2, argv=0x7fffffffd818) at ../../src/emacs.c:2055
(gdb) c
Continuing.

Thread 1 "emacs" hit Breakpoint 1, clear_garbaged_frames () at ../../src/xdisp.c:11805
11805                   redraw_frame (f);
(gdb) bt
#0  0x00005555555ed30c in clear_garbaged_frames () at ../../src/xdisp.c:11805
#1  0x00005555555f33c9 in redisplay_internal () at ../../src/xdisp.c:15237
#2  0x00005555555f2564 in redisplay () at ../../src/xdisp.c:14825
#3  0x0000555555775f6f in read_char (commandflag=1, map=0x55555691f1e3, prev_event=0x0, used_mouse_menu=0x7fffffffd171, end_time=0x0) at ../../src/keyboard.c:2473
#4  0x00005555557858d0 in read_key_sequence (keybuf=0x7fffffffd3a0, prompt=0x0, dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true, prevent_redisplay=false)
    at ../../src/keyboard.c:9527
#5  0x0000555555772fbe in command_loop_1 () at ../../src/keyboard.c:1345
#6  0x0000555555896deb in internal_condition_case (bfun=0x555555772b76 <command_loop_1>, handlers=0x90, hfun=0x5555557722e9 <cmd_error>) at ../../src/eval.c:1355
#7  0x000055555577283b in command_loop_2 (ignore=0x0) at ../../src/keyboard.c:1091
#8  0x000055555589665c in internal_catch (tag=0xd470, func=0x55555577280e <command_loop_2>, arg=0x0) at ../../src/eval.c:1116
#9  0x00005555557727d9 in command_loop () at ../../src/keyboard.c:1070
#10 0x0000555555771eb8 in recursive_edit_1 () at ../../src/keyboard.c:714
#11 0x000055555577203c in Frecursive_edit () at ../../src/keyboard.c:786
#12 0x000055555576a4a7 in main (argc=2, argv=0x7fffffffd818) at ../../src/emacs.c:2055
(gdb) c
Continuing.



  reply	other threads:[~2019-10-09 13:55 UTC|newest]

Thread overview: 211+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 20:45 Tabs Juri Linkov
2019-09-01  8:12 ` Tabs martin rudalics
2019-09-01 14:40   ` Tabs Eli Zaretskii
2019-09-01 19:57   ` Tabs Juri Linkov
2019-09-02  0:40     ` Tabs Stefan Kangas
2019-09-02 10:11       ` Tabs Elias Mårtenson
2019-09-02 11:16         ` Tabs Dmitry Gutov
2019-09-02 19:27         ` Tabs Juri Linkov
2019-09-03  5:21           ` Tabs Jean Louis
2019-09-03 19:40             ` Tabs Juri Linkov
2019-09-03 20:14               ` Tabs Jean Louis
2019-09-02 19:17       ` Tabs Juri Linkov
2019-09-03  5:45         ` Tabs Yuri Khan
2019-09-03 19:45           ` Tabs Juri Linkov
2019-09-15 16:44         ` Tabs Stefan Kangas
2019-09-15 21:17           ` Tabs Juri Linkov
2019-09-02  2:29     ` Tabs Eli Zaretskii
2019-09-02 19:29       ` Tabs Juri Linkov
2019-09-03  2:27         ` Tabs Eli Zaretskii
2019-09-01  8:59 ` Tabs (on macos) Jean-Christophe Helary
2019-09-01 20:11   ` Juri Linkov
2019-09-16 13:41     ` Stefan Kangas
2019-09-16 20:33       ` Juri Linkov
2019-09-17  9:11         ` Stefan Kangas
2019-09-17  9:29           ` Stefan Kangas
2019-09-17 20:28             ` Juri Linkov
2019-09-17 22:38               ` Stefan Kangas
2019-09-20 18:26               ` Alan Third
2019-09-17 23:29             ` Stefan Kangas
2019-09-01  9:28 ` Tabs Alan Mackenzie
2019-09-01 19:18   ` Tabs Juri Linkov
2019-09-01 12:31 ` Tabs Ergus
2019-09-01 19:31   ` Tabs Juri Linkov
2019-09-02  4:51     ` Tabs Ergus
2019-09-02 19:33       ` Tabs Juri Linkov
2019-09-02 21:06         ` Tabs Stefan Monnier
2019-09-03 19:56           ` Tabs Juri Linkov
2019-09-03  2:30         ` Tabs Eli Zaretskii
2019-09-03 19:58           ` Tabs Juri Linkov
2019-09-03  5:39         ` Tabs Ergus
2019-09-05 22:24         ` Tabs Ergus
2019-09-07 20:14           ` Tabs Juri Linkov
2019-09-02 12:41     ` Tabs Stefan Monnier
2019-09-02 19:39       ` Tabs Juri Linkov
2019-09-02 21:03         ` Tabs Stefan Monnier
2019-09-03 12:22 ` Tabs Robert Pluim
2019-09-03 20:21   ` Tabs Juri Linkov
2019-09-15 19:21 ` Tabs Stefan Kangas
2019-09-15 21:32   ` Tabs Juri Linkov
2019-09-16  4:19     ` Tabs Yuri Khan
2019-09-16 20:59       ` Tabs Juri Linkov
2019-09-17  5:29         ` Tabs Yuri Khan
2019-09-17 20:37           ` Tabs Juri Linkov
2019-09-17 22:53             ` Tabs Drew Adams
2019-09-28 17:06     ` Tabs Stefan Kangas
2019-09-28 19:52       ` Tabs Juri Linkov
2019-10-20 22:38         ` Tabs Juri Linkov
2019-11-02 21:40       ` Tabs Juri Linkov
2019-09-19 23:57 ` Tabs Michael Heerdegen
2019-09-21 22:45   ` Tabs Juri Linkov
2019-09-22  0:31     ` Tabs Michael Heerdegen
2019-09-25 20:15       ` Tabs Juri Linkov
2019-10-05 13:57         ` Tabs Michael Heerdegen
2019-10-05 22:12           ` Tabs Juri Linkov
2019-10-06  8:22             ` Tabs Michael Heerdegen
2019-10-06 12:09               ` Tabs Michael Heerdegen
2019-10-06 15:16                 ` Tabs Michael Heerdegen
2019-10-06 17:49                 ` Tabs Eli Zaretskii
2019-10-06 17:55                   ` Tabs Juri Linkov
2019-10-06 18:05                     ` Tabs Juri Linkov
2019-10-06 18:58                       ` Tabs Eli Zaretskii
2019-10-06 18:59                       ` Tabs Eli Zaretskii
2019-10-06 19:08                         ` Tabs Michael Heerdegen
2019-10-06 19:11                         ` Tabs Juri Linkov
2019-10-06 19:21                           ` Tabs Eli Zaretskii
2019-10-06 19:58                             ` Tabs Juri Linkov
2019-10-07 16:05                               ` Tabs Eli Zaretskii
2019-10-07 16:53                                 ` Tabs Michael Heerdegen
2019-10-07 17:12                                   ` Tabs Ergus
2019-10-07 18:24                                     ` Tabs Eli Zaretskii
2019-10-07 19:28                                       ` Tabs Ergus
2019-10-08  7:42                                         ` Tabs Eli Zaretskii
2019-10-08  8:56                                           ` Tabs Ergus
2019-10-08  9:18                                             ` Tabs Eli Zaretskii
2019-10-08 13:58                                               ` Tabs Eli Zaretskii
2019-10-08 16:00                                               ` Tabs Ergus
2019-10-08 16:18                                                 ` Tabs Eli Zaretskii
2019-10-08 16:40                                                   ` Tabs Ergus
2019-10-08 17:03                                                     ` Tabs Eli Zaretskii
2019-10-08 23:43                                                       ` Tabs Ergus
2019-10-09  8:37                                                         ` Tabs Eli Zaretskii
2019-10-09 10:39                                                           ` Tabs Ergus
2019-10-09 11:35                                                             ` Tabs Eli Zaretskii
2019-10-09 12:05                                                               ` Tabs Ergus
2019-10-09 12:18                                                                 ` Tabs Eli Zaretskii
2019-10-09 12:32                                                                 ` Tabs Eli Zaretskii
2019-10-09 18:12                                                                   ` Tabs martin rudalics
2019-10-09 18:46                                                                     ` Tabs Eli Zaretskii
2019-10-10  9:15                                                                       ` Tabs martin rudalics
2019-10-10  9:59                                                                         ` Tabs Eli Zaretskii
2019-10-10 10:38                                                                           ` Tabs martin rudalics
2019-10-10 11:33                                                                             ` Tabs Eli Zaretskii
2019-10-10 11:53                                                                               ` Tabs Eli Zaretskii
2019-10-10 14:58                                                                                 ` Tabs martin rudalics
2019-10-09 12:36                                                                 ` Tabs Eli Zaretskii
2019-10-09 13:55                                                                   ` Ergus [this message]
2019-10-09 14:21                                                                     ` Tabs Eli Zaretskii
2019-10-09 15:15                                                                       ` Tabs Ergus
2019-10-09 15:35                                                                         ` Tabs Eli Zaretskii
2019-10-10 11:52                                                                           ` Tabs Eli Zaretskii
2019-10-10 13:12                                                                             ` Tabs Ergus
2019-10-10 13:54                                                                               ` Tabs Eli Zaretskii
2019-10-10 14:19                                                                                 ` Tabs Ergus
2019-10-10 15:03                                                                                   ` Tabs Eli Zaretskii
2019-10-10 15:35                                                                                     ` Tabs martin rudalics
2019-10-10 15:46                                                                                       ` Tabs Ergus
2019-10-10 18:14                                                                                         ` Tabs martin rudalics
2019-10-10 18:26                                                                                           ` Tabs Eli Zaretskii
2019-10-11  8:18                                                                                             ` Tabs martin rudalics
2019-10-11  9:16                                                                                               ` Tabs Eli Zaretskii
2019-10-16  9:16                                                                                   ` Tabs martin rudalics
2019-10-10 13:29                                                                             ` Tabs Ergus
2019-10-10 13:47                                                                               ` Tabs Eli Zaretskii
2019-10-10 14:15                                                                                 ` Tabs Ergus
2019-10-10 14:40                                                                                 ` Tabs Ergus
2019-10-10 15:11                                                                                   ` Tabs Eli Zaretskii
2019-10-10 20:54                                                                                   ` Tabs Juri Linkov
2019-10-11  7:08                                                                                     ` Tabs Eli Zaretskii
2019-10-13 20:57                                                                                       ` Tabs Juri Linkov
2019-10-09 22:37                                                                       ` Tabs Juri Linkov
2019-10-10  7:51                                                                         ` Tabs Eli Zaretskii
2019-10-10 22:35                                                                           ` Tabs Juri Linkov
2019-10-11  8:18                                                                             ` Tabs martin rudalics
2019-10-12 22:42                                                                               ` Tabs Juri Linkov
2019-10-13  8:16                                                                                 ` Tabs martin rudalics
2019-10-14 18:02                                                                                   ` Tabs martin rudalics
2019-10-14 18:29                                                                                     ` Tabs Eli Zaretskii
2019-10-15  9:47                                                                                       ` Tabs martin rudalics
2019-10-14 19:35                                                                                     ` Tabs Juri Linkov
2019-10-14 21:17                                                                                       ` Tabs T.V Raman
2019-10-14 21:53                                                                                         ` Tabs Phil Sainty
2019-10-14 22:00                                                                                           ` Tabs Juri Linkov
2019-10-14 22:36                                                                                             ` Tabs T.V Raman
2019-10-15 20:39                                                                                               ` Tabs Juri Linkov
2019-10-16  0:14                                                                                                 ` Tabs T.V Raman
2019-10-15  6:12                                                                                         ` Tabs Eli Zaretskii
2019-10-15  9:47                                                                                       ` Tabs martin rudalics
2019-10-15 17:45                                                                                         ` Tabs Juri Linkov
2019-10-16  9:16                                                                                           ` Tabs martin rudalics
2019-10-14 19:00                                                                                   ` Tabs Juri Linkov
2019-10-15  9:47                                                                                     ` Tabs martin rudalics
2019-10-11  9:20                                                                             ` Tabs Eli Zaretskii
2019-10-12 22:47                                                                               ` Tabs Juri Linkov
2019-10-13  6:51                                                                                 ` Tabs Eli Zaretskii
2019-10-13 20:48                                                                                   ` Tabs Juri Linkov
2019-10-13 21:09                                                                                     ` Tabs Eli Zaretskii
2019-10-13 21:33                                                                                       ` Tabs Juri Linkov
2019-10-14  8:24                                                                                         ` Tabs Eli Zaretskii
2019-10-07 17:58                                   ` Tabs Eli Zaretskii
2019-10-07 19:11                                 ` Tabs Juri Linkov
2019-10-06 18:38                     ` Tabs Michael Heerdegen
2019-10-06 19:03                       ` Tabs Eli Zaretskii
2019-10-06 18:56                     ` Tabs Eli Zaretskii
2019-10-08 19:15               ` Tabs Michael Heerdegen
2019-10-09 22:48                 ` Tabs Juri Linkov
2019-10-10 11:06                   ` Tabs Michael Heerdegen
2019-10-10 20:59                     ` Tabs Juri Linkov
2019-10-13  9:32                       ` Tabs Michael Heerdegen
2019-10-13 20:24                         ` Tabs Juri Linkov
2019-10-15 14:42                           ` Tabs Michael Heerdegen
2019-10-19 22:51                             ` Tabs Juri Linkov
2019-10-25 11:19                               ` Tabs Michael Heerdegen
2019-10-26 22:40                                 ` Tabs Juri Linkov
2019-10-29 19:09                                   ` Tabs Michael Heerdegen
2019-11-05 23:24                                     ` Tabs Juri Linkov
2019-11-08 18:45                                       ` Tabs Michael Heerdegen
2019-11-08 19:56                                         ` Tabs Michael Heerdegen
2019-11-12 21:31                                           ` Tabs Juri Linkov
2019-11-13 16:47                                             ` Tabs Michael Heerdegen
2019-11-13 22:10                                               ` Tabs Juri Linkov
2019-11-14  9:20                                                 ` Tabs martin rudalics
  -- strict thread matches above, loose matches on Subject: below --
2019-09-02 13:31 Tabs Angelo Graziosi
2019-09-02 19:46 ` Tabs Juri Linkov
2019-09-03  8:49   ` Tabs Angelo Graziosi
2019-09-03 19:48     ` Tabs Juri Linkov
2019-09-04  8:22       ` Tabs Angelo Graziosi
2019-09-04 19:05         ` Tabs Juri Linkov
2019-09-04 22:41           ` Tabs Angelo Graziosi
2019-09-05 21:40           ` Tabs Angelo Graziosi
2019-09-06 20:16             ` Tabs Angelo Graziosi
2019-09-07 20:28             ` Tabs Juri Linkov
2019-09-08 20:19             ` Tabs Juri Linkov
2019-09-16  7:56               ` Tabs Angelo Graziosi
2019-09-16  8:45                 ` Tabs Angelo Graziosi
2019-09-16 20:43                   ` Tabs Juri Linkov
2019-10-13 14:49                     ` Tabs Angelo Graziosi
2019-10-13 15:07                       ` Tabs Eli Zaretskii
2019-10-13 21:09                         ` Tabs Angelo Graziosi
2019-10-14  8:23                           ` Tabs Eli Zaretskii
2019-10-15 21:38                             ` Tabs Angelo Graziosi
2019-10-16  6:53                               ` Tabs Eli Zaretskii
2019-10-13 22:08                         ` Tabs Juri Linkov
2019-10-14  6:37                           ` Tabs Eli Zaretskii
2019-10-15  7:55                             ` Tabs Eli Zaretskii
2019-10-15 19:44                               ` Tabs Juri Linkov
2019-10-16  6:23                                 ` Tabs Eli Zaretskii
2019-10-16 22:17                                   ` Tabs Juri Linkov
2019-10-17  7:17                                     ` Tabs Eli Zaretskii
2019-10-13 22:01                       ` Tabs Juri Linkov
2019-09-03  9:20 Tabs Angelo Graziosi
     [not found] <<87a7bpysm8.fsf@mail.linkov.net>
     [not found] ` <<d0768d60-979b-8635-b2b5-474742827552@gmx.at>
     [not found]   ` <<87o903dc2j.fsf@mail.linkov.net>
     [not found]     ` <<CADwFkmmgvyMzc_RZwz-AD6=cpUGfxdx5VZAv2eau4T9dAkTKQg@mail.gmail.com>
     [not found]       ` <<CADtN0WKCHd9fA-tCaGckHFQ59+6ns72NdGrvAdKHss0GLYFZ6g@mail.gmail.com>
     [not found]         ` <<87tv9ubirx.fsf@mail.linkov.net>
     [not found]           ` <<courier.000000005D6DF86C.00005323@protected.rcdrun.com>
2019-09-03 15:24             ` Tabs Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191009135539.c2i6ob52td6p34ab@Ergus \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).